All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Kurth <lars.kurth.xen@gmail.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	andre.przywara@linaro.org, xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU
Date: Wed, 17 Jan 2018 12:23:33 +0000	[thread overview]
Message-ID: <7F2FA84A-2CBA-45EC-9073-7FC86205BE5A@gmail.com> (raw)
In-Reply-To: <3f287ea5-f122-b375-4d98-e33733516816@linaro.org>


[-- Attachment #1.1: Type: text/plain, Size: 1476 bytes --]



> On 17 Jan 2018, at 10:31, Julien Grall <julien.grall@linaro.org> wrote:
> 
> Hi Stefano,
> 
> On 16/01/18 23:55, Stefano Stabellini wrote:
>> On Tue, 16 Jan 2018, Julien Grall wrote:
>>> Once Xen knows what features/workarounds present on the platform, it
>>> might be necessary to configure each online CPU.
>>> 
>>> Introduce a new callback "enable" that will be called on each online CPU to
>>> configure the "capability".
>>> 
>>> The code is based on Linux v4.14 (where cpufeature.c comes from), the
>>> explanation of why using stop_machine_run is kept as we have similar
>>> problem in the future.
>>> 
>>> Lastly introduce enable_errata_workaround that will be called once CPUs
>>> have booted and before the hardware domain is created.
>>> 
>>> This is part of XSA-254.
>>> 
>>> Signed-of-by: Julien Grall <julien.grall@linaro.org>
>> If you took the code from Linux, you need to add the original
>> Signed-off-by from the Linux commit. Aside from that:
> 
> There are multiple commits touching this function. So I followed what we did in similar situation. By that I mean, mentioning the code was taken from Linux and not gathered the signed-off-by.
> 
> If you really want, I can gather all the signed-off-by of the commit touching this function.

If there are a lot of then, you may want to consider adding a README.source file instead. There are a few examples in tree and they are also mentioned in CONTRIBUTING files
Lars


[-- Attachment #1.2: Type: text/html, Size: 5917 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-01-17 12:23 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 14:23 [PATCH 0/5] xen/arm64: Branch predictor hardening (XSA-254 variant 2) Julien Grall
2018-01-16 14:23 ` [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU Julien Grall
2018-01-16 23:55   ` Stefano Stabellini
2018-01-17 10:31     ` Julien Grall
2018-01-17 12:23       ` Lars Kurth [this message]
2018-01-17 12:31         ` Julien Grall
2018-01-17 14:31           ` Lars Kurth
2018-01-17 17:16             ` Stefano Stabellini
2018-01-17 21:47               ` Stefano Stabellini
2018-01-18 12:34                 ` XSA-254 SP2 for ARM (was Re: [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU) Julien Grall
2018-01-18 20:28                   ` Stefano Stabellini
2018-01-19  9:48                     ` Jan Beulich
2018-01-19 17:23                       ` Stefano Stabellini
2018-01-24 22:14                   ` Stefano Stabellini
2018-01-24 22:21                     ` Julien Grall
2018-01-24 22:43                       ` Stefano Stabellini
2018-01-25 11:03                         ` Julien Grall
2018-01-25 17:23                           ` Stefano Stabellini
2018-01-18 10:56             ` [PATCH 1/5] xen/arm: Introduce enable callback to enable a capabilities on each online CPU Julien Grall
2018-01-24 17:05               ` Lars Kurth
2018-01-16 14:23 ` [PATCH 2/5] xen/arm64: Add missing MIDR values for Cortex-A72, A73 and A75 Julien Grall
2018-01-16 21:35   ` Stefano Stabellini
2018-01-16 14:23 ` [PATCH 3/5] xen/arm: cpuerrata: Add MIDR_ALL_VERSIONS Julien Grall
2018-01-16 21:38   ` Stefano Stabellini
2018-01-16 14:23 ` [PATCH 4/5] xen/arm64: Add skeleton to harden the branch predictor aliasing attacks Julien Grall
2018-01-17 18:26   ` Stefano Stabellini
2018-01-18 11:54     ` Julien Grall
2018-01-16 14:23 ` [PATCH 5/5] xen/arm64: Implement branch predictor hardening for affected Cortex-A CPUs Julien Grall
2018-01-17  0:42   ` Stefano Stabellini
2018-01-17 10:52     ` Julien Grall
2018-01-17 17:11       ` Stefano Stabellini
2018-01-18 11:19         ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7F2FA84A-2CBA-45EC-9073-7FC86205BE5A@gmail.com \
    --to=lars.kurth.xen@gmail.com \
    --cc=andre.przywara@linaro.org \
    --cc=julien.grall@linaro.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.