* [PATCH/RFC 1/4] dt-bindings: i2c: renesas,riic: Add interrupt-names
2021-07-14 13:19 [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Geert Uytterhoeven
@ 2021-07-14 13:20 ` Geert Uytterhoeven
2021-07-16 19:19 ` Rob Herring
2021-07-14 13:20 ` [PATCH/RFC 2/4] ARM: dts: rza: Add I2C interrupt-names Geert Uytterhoeven
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14 13:20 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring, Chris Brandt, Biju Das
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
interrupts. Hence document the "interrupt-names" property, to make it
easier to review the interrupt mappings in DTS files.
Note that this property cannot be made required yet, as the RIIC nodes
in all DTS files lack the property.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
.../devicetree/bindings/i2c/renesas,riic.yaml | 29 ++++++++++++++-----
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index 52d92ec7ec0b2112..70f998f006305c25 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -27,14 +27,25 @@ properties:
interrupts:
items:
- - description: Transmit End Interrupt (TEI)
- - description: Receive Data Full Interrupt (RI)
- - description: Transmit Data Empty Interrupt (TI)
- - description: Stop Condition Detection Interrupt (SPI)
- - description: Start Condition Detection Interrupt (STI)
- - description: NACK Reception Interrupt (NAKI)
- - description: Arbitration-Lost Interrupt (ALI)
- - description: Timeout Interrupt (TMOI)
+ - description: Transmit End Interrupt
+ - description: Receive Data Full Interrupt
+ - description: Transmit Data Empty Interrupt
+ - description: Stop Condition Detection Interrupt
+ - description: Start Condition Detection Interrupt
+ - description: NACK Reception Interrupt
+ - description: Arbitration-Lost Interrupt
+ - description: Timeout Interrupt
+
+ interrupt-names:
+ items:
+ - const: tei
+ - const: ri
+ - const: ti
+ - const: spi
+ - const: sti
+ - const: naki
+ - const: ali
+ - const: tmoi
clock-frequency:
description:
@@ -85,6 +96,8 @@ examples:
<GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti", "naki", "ali",
+ "tmoi";
clocks = <&mstp9_clks R7S72100_CLK_I2C0>;
clock-frequency = <100000>;
power-domains = <&cpg_clocks>;
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH/RFC 1/4] dt-bindings: i2c: renesas,riic: Add interrupt-names
2021-07-14 13:20 ` [PATCH/RFC 1/4] " Geert Uytterhoeven
@ 2021-07-16 19:19 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2021-07-16 19:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, devicetree, Wolfram Sang, linux-i2c, Chris Brandt,
linux-renesas-soc, Rob Herring
On Wed, 14 Jul 2021 15:20:00 +0200, Geert Uytterhoeven wrote:
> The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
> interrupts. Hence document the "interrupt-names" property, to make it
> easier to review the interrupt mappings in DTS files.
>
> Note that this property cannot be made required yet, as the RIIC nodes
> in all DTS files lack the property.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> .../devicetree/bindings/i2c/renesas,riic.yaml | 29 ++++++++++++++-----
> 1 file changed, 21 insertions(+), 8 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH/RFC 2/4] ARM: dts: rza: Add I2C interrupt-names
2021-07-14 13:19 [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Geert Uytterhoeven
2021-07-14 13:20 ` [PATCH/RFC 1/4] " Geert Uytterhoeven
@ 2021-07-14 13:20 ` Geert Uytterhoeven
2021-07-14 13:20 ` [PATCH/RFC 3/4] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14 13:20 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring, Chris Brandt, Biju Das
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
Add "interrupt-names" properties to the I2C device nodes of the RZ/A1H
and RZ/A2M DTS files, to make it easier to review the interrupt mappings.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm/boot/dts/r7s72100.dtsi | 8 ++++++++
arch/arm/boot/dts/r7s9210.dtsi | 8 ++++++++
2 files changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi
index 45cf75b5824cbe7f..b07b71307f24ad59 100644
--- a/arch/arm/boot/dts/r7s72100.dtsi
+++ b/arch/arm/boot/dts/r7s72100.dtsi
@@ -608,6 +608,8 @@ i2c0: i2c@fcfee000 {
<GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 164 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&mstp9_clks R7S72100_CLK_I2C0>;
clock-frequency = <100000>;
power-domains = <&cpg_clocks>;
@@ -627,6 +629,8 @@ i2c1: i2c@fcfee400 {
<GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 171 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&mstp9_clks R7S72100_CLK_I2C1>;
clock-frequency = <100000>;
power-domains = <&cpg_clocks>;
@@ -646,6 +650,8 @@ i2c2: i2c@fcfee800 {
<GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&mstp9_clks R7S72100_CLK_I2C2>;
clock-frequency = <100000>;
power-domains = <&cpg_clocks>;
@@ -665,6 +671,8 @@ i2c3: i2c@fcfeec00 {
<GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&mstp9_clks R7S72100_CLK_I2C3>;
clock-frequency = <100000>;
power-domains = <&cpg_clocks>;
diff --git a/arch/arm/boot/dts/r7s9210.dtsi b/arch/arm/boot/dts/r7s9210.dtsi
index 85c0399b1339585b..fdeb0bc12cb794d6 100644
--- a/arch/arm/boot/dts/r7s9210.dtsi
+++ b/arch/arm/boot/dts/r7s9210.dtsi
@@ -236,6 +236,8 @@ i2c0: i2c@e803a000 {
<GIC_SPI 237 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 238 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 239 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD 87>;
power-domains = <&cpg>;
clock-frequency = <100000>;
@@ -255,6 +257,8 @@ i2c1: i2c@e803a400 {
<GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 247 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD 86>;
power-domains = <&cpg>;
clock-frequency = <100000>;
@@ -274,6 +278,8 @@ i2c2: i2c@e803a800 {
<GIC_SPI 253 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 254 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 255 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD 85>;
power-domains = <&cpg>;
clock-frequency = <100000>;
@@ -293,6 +299,8 @@ i2c3: i2c@e803ac00 {
<GIC_SPI 261 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 263 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD 84>;
power-domains = <&cpg>;
clock-frequency = <100000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH/RFC 3/4] arm64: dts: renesas: r9a07g044: Add I2C interrupt-names
2021-07-14 13:19 [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Geert Uytterhoeven
2021-07-14 13:20 ` [PATCH/RFC 1/4] " Geert Uytterhoeven
2021-07-14 13:20 ` [PATCH/RFC 2/4] ARM: dts: rza: Add I2C interrupt-names Geert Uytterhoeven
@ 2021-07-14 13:20 ` Geert Uytterhoeven
2021-07-14 17:21 ` Biju Das
2021-07-14 13:20 ` [PATCH/RFC 4/4] dt-bindings: i2c: renesas,riic: Make interrupt-names required Geert Uytterhoeven
2021-08-11 14:23 ` [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Wolfram Sang
4 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14 13:20 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring, Chris Brandt, Biju Das
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
Add "interrupt-names" properties to the I2C device nodes, to make it
easier to review the interrupt mappings.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 9a7489dc70d10882..0dd181739fdfc0f6 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -102,6 +102,8 @@ i2c0: i2c@10058000 {
<GIC_SPI 351 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD R9A07G044_I2C0_PCLK>;
clock-frequency = <100000>;
resets = <&cpg R9A07G044_I2C0_MRST>;
@@ -122,6 +124,8 @@ i2c1: i2c@10058400 {
<GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 362 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD R9A07G044_I2C1_PCLK>;
clock-frequency = <100000>;
resets = <&cpg R9A07G044_I2C1_MRST>;
@@ -142,6 +146,8 @@ i2c2: i2c@10058800 {
<GIC_SPI 367 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD R9A07G044_I2C2_PCLK>;
clock-frequency = <100000>;
resets = <&cpg R9A07G044_I2C2_MRST>;
@@ -162,6 +168,8 @@ i2c3: i2c@10058c00 {
<GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "tei", "ri", "ti", "spi", "sti",
+ "naki", "ali", "tmoi";
clocks = <&cpg CPG_MOD R9A07G044_I2C3_PCLK>;
clock-frequency = <100000>;
resets = <&cpg R9A07G044_I2C3_MRST>;
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* RE: [PATCH/RFC 3/4] arm64: dts: renesas: r9a07g044: Add I2C interrupt-names
2021-07-14 13:20 ` [PATCH/RFC 3/4] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
@ 2021-07-14 17:21 ` Biju Das
0 siblings, 0 replies; 11+ messages in thread
From: Biju Das @ 2021-07-14 17:21 UTC (permalink / raw)
To: Geert Uytterhoeven, Wolfram Sang, Rob Herring, Chris Brandt
Cc: linux-renesas-soc, linux-i2c, devicetree
Hi Geert,
Thanks for the patch.
> Subject: [PATCH/RFC 3/4] arm64: dts: renesas: r9a07g044: Add I2C
> interrupt-names
>
> Add "interrupt-names" properties to the I2C device nodes, to make it
> easier to review the interrupt mappings.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> index 9a7489dc70d10882..0dd181739fdfc0f6 100644
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -102,6 +102,8 @@ i2c0: i2c@10058000 {
> <GIC_SPI 351 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 354 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 355 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tei", "ri", "ti", "spi", "sti",
> + "naki", "ali", "tmoi";
> clocks = <&cpg CPG_MOD R9A07G044_I2C0_PCLK>;
> clock-frequency = <100000>;
> resets = <&cpg R9A07G044_I2C0_MRST>; @@ -122,6 +124,8 @@
> i2c1: i2c@10058400 {
> <GIC_SPI 359 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 362 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tei", "ri", "ti", "spi", "sti",
> + "naki", "ali", "tmoi";
> clocks = <&cpg CPG_MOD R9A07G044_I2C1_PCLK>;
> clock-frequency = <100000>;
> resets = <&cpg R9A07G044_I2C1_MRST>; @@ -142,6 +146,8 @@
> i2c2: i2c@10058800 {
> <GIC_SPI 367 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 371 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tei", "ri", "ti", "spi", "sti",
> + "naki", "ali", "tmoi";
> clocks = <&cpg CPG_MOD R9A07G044_I2C2_PCLK>;
> clock-frequency = <100000>;
> resets = <&cpg R9A07G044_I2C2_MRST>; @@ -162,6 +168,8 @@
> i2c3: i2c@10058c00 {
> <GIC_SPI 375 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 378 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 379 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tei", "ri", "ti", "spi", "sti",
> + "naki", "ali", "tmoi";
> clocks = <&cpg CPG_MOD R9A07G044_I2C3_PCLK>;
> clock-frequency = <100000>;
> resets = <&cpg R9A07G044_I2C3_MRST>;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH/RFC 4/4] dt-bindings: i2c: renesas,riic: Make interrupt-names required
2021-07-14 13:19 [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Geert Uytterhoeven
` (2 preceding siblings ...)
2021-07-14 13:20 ` [PATCH/RFC 3/4] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
@ 2021-07-14 13:20 ` Geert Uytterhoeven
2021-07-16 19:20 ` Rob Herring
2021-08-11 14:23 ` [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Wolfram Sang
4 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-07-14 13:20 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring, Chris Brandt, Biju Das
Cc: linux-renesas-soc, linux-i2c, devicetree, Geert Uytterhoeven
Now the I2C device nodes in all DTS files have gained "interrupt-names"
properties, the "interrupt-names" property can be made required.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index 70f998f006305c25..402fd125e0104a6a 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -62,6 +62,7 @@ required:
- compatible
- reg
- interrupts
+ - interrupt-names
- clocks
- clock-frequency
- power-domains
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH/RFC 4/4] dt-bindings: i2c: renesas,riic: Make interrupt-names required
2021-07-14 13:20 ` [PATCH/RFC 4/4] dt-bindings: i2c: renesas,riic: Make interrupt-names required Geert Uytterhoeven
@ 2021-07-16 19:20 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2021-07-16 19:20 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: linux-i2c, linux-renesas-soc, devicetree, Wolfram Sang,
Chris Brandt, Rob Herring, Biju Das
On Wed, 14 Jul 2021 15:20:03 +0200, Geert Uytterhoeven wrote:
> Now the I2C device nodes in all DTS files have gained "interrupt-names"
> properties, the "interrupt-names" property can be made required.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names
2021-07-14 13:19 [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Geert Uytterhoeven
` (3 preceding siblings ...)
2021-07-14 13:20 ` [PATCH/RFC 4/4] dt-bindings: i2c: renesas,riic: Make interrupt-names required Geert Uytterhoeven
@ 2021-08-11 14:23 ` Wolfram Sang
2021-08-11 15:29 ` Geert Uytterhoeven
4 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2021-08-11 14:23 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Chris Brandt, Biju Das, linux-renesas-soc,
linux-i2c, devicetree
[-- Attachment #1: Type: text/plain, Size: 897 bytes --]
Hi Geert,
> The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
> interrupts. So I think it makes sense to use "interrupt-names"
> property, to make it easier to review the interrupt mappings in DTS
> files.
>
> Hence this series documents the "interrupt-names" property in the DT
> bindings, adds the property to the DTS files, and marks it required in
> the DT bindings. Obviously the last step cannot be applied until all
> earlier patches are upstream.
>
> What do you think?
I like it and I'd think it is good to go. It is probably easiest if you
take the series via your tree to avoid merge conflicts and/or subsystem
dependencies. It's unlikely the YAML file will see further updates. So,
for the series:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Let me know if you think another way is better.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names
2021-08-11 14:23 ` [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names Wolfram Sang
@ 2021-08-11 15:29 ` Geert Uytterhoeven
2021-08-11 19:04 ` Wolfram Sang
0 siblings, 1 reply; 11+ messages in thread
From: Geert Uytterhoeven @ 2021-08-11 15:29 UTC (permalink / raw)
To: Wolfram Sang, Rob Herring, Chris Brandt, Biju Das, Linux-Renesas,
Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hi Wolfram,
On Wed, Aug 11, 2021 at 4:23 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > The Renesas RZ/A and RZ/G2L I2C Bus Interface has no less than 8
> > interrupts. So I think it makes sense to use "interrupt-names"
> > property, to make it easier to review the interrupt mappings in DTS
> > files.
> >
> > Hence this series documents the "interrupt-names" property in the DT
> > bindings, adds the property to the DTS files, and marks it required in
> > the DT bindings. Obviously the last step cannot be applied until all
> > earlier patches are upstream.
> >
> > What do you think?
>
> I like it and I'd think it is good to go. It is probably easiest if you
> take the series via your tree to avoid merge conflicts and/or subsystem
> dependencies. It's unlikely the YAML file will see further updates. So,
> for the series:
Probably it is not worth doing this in lockstep (1/4 in v5.15 through
i2c, 2/4 and 3/4 in v5.16 through renesas-devel, and 4/4 in v5.17
through i2c).
I have different branches for DT binding and DTS, but I guess it
doesn't hurt to deviate and apply both to renesas-arm-dt-for-v5.15...
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH/RFC 0/4] dt-bindings: i2c: renesas,riic: Add interrupt-names
2021-08-11 15:29 ` Geert Uytterhoeven
@ 2021-08-11 19:04 ` Wolfram Sang
0 siblings, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2021-08-11 19:04 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Chris Brandt, Biju Das, Linux-Renesas, Linux I2C,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
[-- Attachment #1: Type: text/plain, Size: 366 bytes --]
Hi Geert,
> Probably it is not worth doing this in lockstep (1/4 in v5.15 through
> i2c, 2/4 and 3/4 in v5.16 through renesas-devel, and 4/4 in v5.17
> through i2c).
I agree!
> I have different branches for DT binding and DTS, but I guess it
> doesn't hurt to deviate and apply both to renesas-arm-dt-for-v5.15...
Sounds good, thanks!
All the best,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread