All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] Use macros for pinctrl configuration on Exynos7
       [not found] <CGME20170118053944epcas1p1bed1518b3ba444434bfbe4048b6fe4bd@epcas1p1.samsung.com>
@ 2017-01-18  5:42   ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel, devicetree
  Cc: krzk, kgene, robh+dt, sanath, javier, s.nawrocki, alim.akhtar,
	Pankaj Dubey

Currently Exynos7 DTSi files are using hard-coded values for pinctrl
configurations such as pin-function, pin-pud and pin-drv. These hard
coded values are difficult to understand without datasheet, lets use
macros for such configurations. 

While doing this observed that Exynos7 has different drive strengths
values *ONLY* for FSYS1 blocks pins, so adding new macro definition
for the same in patch[2/3]

Also some of sd0_xxxx pin definition is using drive strength as 0x3 but
as per datasheet of Exynos7, FSYS1 block's pin does not support 0x3 value
for drive strenth so fixing the same in patch[1/3].

I have verified these patches for boot on Exynos7 based espresso board.

Pankaj Dubey (3):
  arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
  pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro
    definitions
  arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7

 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
 include/dt-bindings/pinctrl/samsung.h           |   8 +
 3 files changed, 162 insertions(+), 152 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 0/3] Use macros for pinctrl configuration on Exynos7
@ 2017-01-18  5:42   ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-arm-kernel

Currently Exynos7 DTSi files are using hard-coded values for pinctrl
configurations such as pin-function, pin-pud and pin-drv. These hard
coded values are difficult to understand without datasheet, lets use
macros for such configurations. 

While doing this observed that Exynos7 has different drive strengths
values *ONLY* for FSYS1 blocks pins, so adding new macro definition
for the same in patch[2/3]

Also some of sd0_xxxx pin definition is using drive strength as 0x3 but
as per datasheet of Exynos7, FSYS1 block's pin does not support 0x3 value
for drive strenth so fixing the same in patch[1/3].

I have verified these patches for boot on Exynos7 based espresso board.

Pankaj Dubey (3):
  arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
  pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro
    definitions
  arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7

 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
 include/dt-bindings/pinctrl/samsung.h           |   8 +
 3 files changed, 162 insertions(+), 152 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
       [not found]   ` <CGME20170118053953epcas1p18e06184783a0edc6a2cfc3b6a9d9ce31@epcas1p1.samsung.com>
@ 2017-01-18  5:42         ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA
  Cc: krzk-DgEjT+Ai2ygdnm+yROfE0A, kgene-DgEjT+Ai2ygdnm+yROfE0A,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, sanath-Sze3O3UU22JBDgjK7y7TUQ,
	javier-JPH+aEBZ4P+UEJcrhfAQsw, s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ,
	alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ, Pankaj Dubey

As per Exynos7 datasheet FSYS1 pinctrl block does not support drive
strength value of 0x3. This patch fixes this and update the correct
drive strength for sd0_xxx pin definitions.

Signed-off-by: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
index 8232198..7ebb939 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
@@ -497,49 +497,49 @@
 		samsung,pins = "gpr0-0";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <0>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_cmd: sd0-cmd {
 		samsung,pins = "gpr0-1";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_ds: sd0-ds {
 		samsung,pins = "gpr0-2";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <1>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_qrdy: sd0-qrdy {
 		samsung,pins = "gpr0-3";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <1>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_bus1: sd0-bus-width1 {
 		samsung,pins = "gpr1-0";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_bus4: sd0-bus-width4 {
 		samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_bus8: sd0-bus-width8 {
 		samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd1_clk: sd1-clk {
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
@ 2017-01-18  5:42         ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-arm-kernel

As per Exynos7 datasheet FSYS1 pinctrl block does not support drive
strength value of 0x3. This patch fixes this and update the correct
drive strength for sd0_xxx pin definitions.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
index 8232198..7ebb939 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
@@ -497,49 +497,49 @@
 		samsung,pins = "gpr0-0";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <0>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_cmd: sd0-cmd {
 		samsung,pins = "gpr0-1";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_ds: sd0-ds {
 		samsung,pins = "gpr0-2";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <1>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_qrdy: sd0-qrdy {
 		samsung,pins = "gpr0-3";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <1>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_bus1: sd0-bus-width1 {
 		samsung,pins = "gpr1-0";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_bus4: sd0-bus-width4 {
 		samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd0_bus8: sd0-bus-width8 {
 		samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
 		samsung,pin-function = <2>;
 		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-drv = <4>;
 	};
 
 	sd1_clk: sd1-clk {
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
       [not found]   ` <CGME20170118054002epcas5p3b08e2f419976e17a3c584d64776810fd@epcas5p3.samsung.com>
@ 2017-01-18  5:42       ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel, devicetree
  Cc: krzk, kgene, robh+dt, sanath, javier, s.nawrocki, alim.akhtar,
	Pankaj Dubey

Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
pinctrl driver strength related macros which will be used in Exynos7
DTSi files.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h
index 6276eb7..3f1d583 100644
--- a/include/dt-bindings/pinctrl/samsung.h
+++ b/include/dt-bindings/pinctrl/samsung.h
@@ -54,4 +54,12 @@
 #define EXYNOS_PIN_FUNC_6		6
 #define EXYNOS_PIN_FUNC_F		0xf
 
+/* Drive strengths for Exynos7 FSYS1 block */
+#define EXYNOS7_FSYS1_PIN_DRV_LV1	0
+#define EXYNOS7_FSYS1_PIN_DRV_LV2	4
+#define EXYNOS7_FSYS1_PIN_DRV_LV3	2
+#define EXYNOS7_FSYS1_PIN_DRV_LV4	6
+#define EXYNOS7_FSYS1_PIN_DRV_LV5	1
+#define EXYNOS7_FSYS1_PIN_DRV_LV6	5
+
 #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-01-18  5:42       ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-arm-kernel

Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
pinctrl driver strength related macros which will be used in Exynos7
DTSi files.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h
index 6276eb7..3f1d583 100644
--- a/include/dt-bindings/pinctrl/samsung.h
+++ b/include/dt-bindings/pinctrl/samsung.h
@@ -54,4 +54,12 @@
 #define EXYNOS_PIN_FUNC_6		6
 #define EXYNOS_PIN_FUNC_F		0xf
 
+/* Drive strengths for Exynos7 FSYS1 block */
+#define EXYNOS7_FSYS1_PIN_DRV_LV1	0
+#define EXYNOS7_FSYS1_PIN_DRV_LV2	4
+#define EXYNOS7_FSYS1_PIN_DRV_LV3	2
+#define EXYNOS7_FSYS1_PIN_DRV_LV4	6
+#define EXYNOS7_FSYS1_PIN_DRV_LV5	1
+#define EXYNOS7_FSYS1_PIN_DRV_LV6	5
+
 #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
       [not found]   ` <CGME20170118054013epcas5p3b20dca776ee350f4ba863db24d3dea67@epcas5p3.samsung.com>
@ 2017-01-18  5:42       ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-samsung-soc, linux-arm-kernel, devicetree
  Cc: alim.akhtar, Pankaj Dubey, krzk, javier, robh+dt, kgene,
	s.nawrocki, sanath

Usage of DTS macros instead of hard-coded numbers makes code easier to
read.  One does not have to remember which value means pull-up/down or
specific driver strength.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
 2 files changed, 154 insertions(+), 152 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index c528dd5..1b2db9f0 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -328,8 +328,8 @@
 &pinctrl_alive {
 	pmic_irq: pmic-irq {
 		samsung,pins = "gpa0-2";
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
index 7ebb939..8f58850 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
@@ -12,6 +12,8 @@
  * published by the Free Software Foundation.
 */
 
+#include <dt-bindings/pinctrl/samsung.h>
+
 &pinctrl_alive {
 	gpa0: gpa0 {
 		gpio-controller;
@@ -187,163 +189,163 @@
 
 	hs_i2c10_bus: hs-i2c10-bus {
 		samsung,pins = "gpb0-1", "gpb0-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c11_bus: hs-i2c11-bus {
 		samsung,pins = "gpb0-3", "gpb0-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c2_bus: hs-i2c2-bus {
 		samsung,pins = "gpd0-3", "gpd0-2";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart0_data: uart0-data {
 		samsung,pins = "gpd0-0", "gpd0-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart0_fctl: uart0-fctl {
 		samsung,pins = "gpd0-2", "gpd0-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart2_data: uart2-data {
 		samsung,pins = "gpd1-4", "gpd1-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c3_bus: hs-i2c3-bus {
 		samsung,pins = "gpd1-3", "gpd1-2";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart1_data: uart1-data {
 		samsung,pins = "gpd1-0", "gpd1-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart1_fctl: uart1-fctl {
 		samsung,pins = "gpd1-2", "gpd1-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c0_bus: hs-i2c0-bus {
 		samsung,pins = "gpd2-1", "gpd2-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c1_bus: hs-i2c1-bus {
 		samsung,pins = "gpd2-3", "gpd2-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c9_bus: hs-i2c9-bus {
 		samsung,pins = "gpd2-7", "gpd2-6";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm0_out: pwm0-out {
 		samsung,pins = "gpd2-4";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm1_out: pwm1-out {
 		samsung,pins = "gpd2-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm2_out: pwm2-out {
 		samsung,pins = "gpd2-6";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm3_out: pwm3-out {
 		samsung,pins = "gpd2-7";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c8_bus: hs-i2c8-bus {
 		samsung,pins = "gpd5-3", "gpd5-2";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart3_data: uart3-data {
 		samsung,pins = "gpd5-0", "gpd5-1";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	spi2_bus: spi2-bus {
 		samsung,pins = "gpd5-0", "gpd5-1", "gpd5-2", "gpd5-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	spi1_bus: spi1-bus {
 		samsung,pins = "gpd6-2", "gpd6-3", "gpd6-4", "gpd6-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	spi0_bus: spi0-bus {
 		samsung,pins = "gpd8-0", "gpd8-1", "gpd6-0", "gpd6-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c4_bus: hs-i2c4-bus {
 		samsung,pins = "gpg3-1", "gpg3-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c5_bus: hs-i2c5-bus {
 		samsung,pins = "gpg3-3", "gpg3-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -358,9 +360,9 @@
 
 	hs_i2c6_bus: hs-i2c6-bus {
 		samsung,pins = "gpj0-1", "gpj0-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -375,9 +377,9 @@
 
 	hs_i2c7_bus: hs-i2c7-bus {
 		samsung,pins = "gpj1-1", "gpj1-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -392,9 +394,9 @@
 
 	spi3_bus: spi3-bus {
 		samsung,pins = "gpg4-0", "gpg4-1", "gpg4-2", "gpg4-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -409,9 +411,9 @@
 
 	spi4_bus: spi4-bus {
 		samsung,pins = "gpv7-0", "gpv7-1", "gpv7-2", "gpv7-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -426,37 +428,37 @@
 
 	sd2_clk: sd2-clk {
 		samsung,pins = "gpr4-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_cmd: sd2-cmd {
 		samsung,pins = "gpr4-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_cd: sd2-cd {
 		samsung,pins = "gpr4-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_bus1: sd2-bus-width1 {
 		samsung,pins = "gpr4-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_bus4: sd2-bus-width4 {
 		samsung,pins = "gpr4-4", "gpr4-5", "gpr4-6";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 };
 
@@ -495,107 +497,107 @@
 
 	sd0_clk: sd0-clk {
 		samsung,pins = "gpr0-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_cmd: sd0-cmd {
 		samsung,pins = "gpr0-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_ds: sd0-ds {
 		samsung,pins = "gpr0-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_qrdy: sd0-qrdy {
 		samsung,pins = "gpr0-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_bus1: sd0-bus-width1 {
 		samsung,pins = "gpr1-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_bus4: sd0-bus-width4 {
 		samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_bus8: sd0-bus-width8 {
 		samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd1_clk: sd1-clk {
 		samsung,pins = "gpr2-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_cmd: sd1-cmd {
 		samsung,pins = "gpr2-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_ds: sd1-ds {
 		samsung,pins = "gpr2-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <6>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
 	};
 
 	sd1_qrdy: sd1-qrdy {
 		samsung,pins = "gpr2-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <6>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
 	};
 
 	sd1_int: sd1-int {
 		samsung,pins = "gpr2-4";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <6>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
 	};
 
 	sd1_bus1: sd1-bus-width1 {
 		samsung,pins = "gpr3-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_bus4: sd1-bus-width4 {
 		samsung,pins = "gpr3-1", "gpr3-2", "gpr3-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_bus8: sd1-bus-width8 {
 		samsung,pins = "gpr3-4", "gpr3-5", "gpr3-6", "gpr3-7";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 };
 
@@ -682,22 +684,22 @@
 
 	spi5_bus: spi5-bus {
 		samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	ufs_refclk_out: ufs-refclk-out {
 		samsung,pins = "gpg2-4";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV2>;
 	};
 
 	ufs_rst_n: ufs-rst-n {
 		samsung,pins = "gph1-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
@ 2017-01-18  5:42       ` Pankaj Dubey
  0 siblings, 0 replies; 28+ messages in thread
From: Pankaj Dubey @ 2017-01-18  5:42 UTC (permalink / raw)
  To: linux-arm-kernel

Usage of DTS macros instead of hard-coded numbers makes code easier to
read.  One does not have to remember which value means pull-up/down or
specific driver strength.

Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
 2 files changed, 154 insertions(+), 152 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
index c528dd5..1b2db9f0 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
@@ -328,8 +328,8 @@
 &pinctrl_alive {
 	pmic_irq: pmic-irq {
 		samsung,pins = "gpa0-2";
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
 	};
 };
 
diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
index 7ebb939..8f58850 100644
--- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
@@ -12,6 +12,8 @@
  * published by the Free Software Foundation.
 */
 
+#include <dt-bindings/pinctrl/samsung.h>
+
 &pinctrl_alive {
 	gpa0: gpa0 {
 		gpio-controller;
@@ -187,163 +189,163 @@
 
 	hs_i2c10_bus: hs-i2c10-bus {
 		samsung,pins = "gpb0-1", "gpb0-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c11_bus: hs-i2c11-bus {
 		samsung,pins = "gpb0-3", "gpb0-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c2_bus: hs-i2c2-bus {
 		samsung,pins = "gpd0-3", "gpd0-2";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart0_data: uart0-data {
 		samsung,pins = "gpd0-0", "gpd0-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart0_fctl: uart0-fctl {
 		samsung,pins = "gpd0-2", "gpd0-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart2_data: uart2-data {
 		samsung,pins = "gpd1-4", "gpd1-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c3_bus: hs-i2c3-bus {
 		samsung,pins = "gpd1-3", "gpd1-2";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart1_data: uart1-data {
 		samsung,pins = "gpd1-0", "gpd1-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart1_fctl: uart1-fctl {
 		samsung,pins = "gpd1-2", "gpd1-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c0_bus: hs-i2c0-bus {
 		samsung,pins = "gpd2-1", "gpd2-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c1_bus: hs-i2c1-bus {
 		samsung,pins = "gpd2-3", "gpd2-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c9_bus: hs-i2c9-bus {
 		samsung,pins = "gpd2-7", "gpd2-6";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm0_out: pwm0-out {
 		samsung,pins = "gpd2-4";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm1_out: pwm1-out {
 		samsung,pins = "gpd2-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm2_out: pwm2-out {
 		samsung,pins = "gpd2-6";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	pwm3_out: pwm3-out {
 		samsung,pins = "gpd2-7";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c8_bus: hs-i2c8-bus {
 		samsung,pins = "gpd5-3", "gpd5-2";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	uart3_data: uart3-data {
 		samsung,pins = "gpd5-0", "gpd5-1";
-		samsung,pin-function = <3>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	spi2_bus: spi2-bus {
 		samsung,pins = "gpd5-0", "gpd5-1", "gpd5-2", "gpd5-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	spi1_bus: spi1-bus {
 		samsung,pins = "gpd6-2", "gpd6-3", "gpd6-4", "gpd6-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	spi0_bus: spi0-bus {
 		samsung,pins = "gpd8-0", "gpd8-1", "gpd6-0", "gpd6-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c4_bus: hs-i2c4-bus {
 		samsung,pins = "gpg3-1", "gpg3-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	hs_i2c5_bus: hs-i2c5-bus {
 		samsung,pins = "gpg3-3", "gpg3-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -358,9 +360,9 @@
 
 	hs_i2c6_bus: hs-i2c6-bus {
 		samsung,pins = "gpj0-1", "gpj0-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -375,9 +377,9 @@
 
 	hs_i2c7_bus: hs-i2c7-bus {
 		samsung,pins = "gpj1-1", "gpj1-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -392,9 +394,9 @@
 
 	spi3_bus: spi3-bus {
 		samsung,pins = "gpg4-0", "gpg4-1", "gpg4-2", "gpg4-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -409,9 +411,9 @@
 
 	spi4_bus: spi4-bus {
 		samsung,pins = "gpv7-0", "gpv7-1", "gpv7-2", "gpv7-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
 
@@ -426,37 +428,37 @@
 
 	sd2_clk: sd2-clk {
 		samsung,pins = "gpr4-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_cmd: sd2-cmd {
 		samsung,pins = "gpr4-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_cd: sd2-cd {
 		samsung,pins = "gpr4-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_bus1: sd2-bus-width1 {
 		samsung,pins = "gpr4-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 
 	sd2_bus4: sd2-bus-width4 {
 		samsung,pins = "gpr4-4", "gpr4-5", "gpr4-6";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <3>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
 	};
 };
 
@@ -495,107 +497,107 @@
 
 	sd0_clk: sd0-clk {
 		samsung,pins = "gpr0-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_cmd: sd0-cmd {
 		samsung,pins = "gpr0-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_ds: sd0-ds {
 		samsung,pins = "gpr0-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_qrdy: sd0-qrdy {
 		samsung,pins = "gpr0-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_bus1: sd0-bus-width1 {
 		samsung,pins = "gpr1-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_bus4: sd0-bus-width4 {
 		samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd0_bus8: sd0-bus-width8 {
 		samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <4>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
 	};
 
 	sd1_clk: sd1-clk {
 		samsung,pins = "gpr2-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_cmd: sd1-cmd {
 		samsung,pins = "gpr2-1";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_ds: sd1-ds {
 		samsung,pins = "gpr2-2";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <6>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
 	};
 
 	sd1_qrdy: sd1-qrdy {
 		samsung,pins = "gpr2-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <6>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
 	};
 
 	sd1_int: sd1-int {
 		samsung,pins = "gpr2-4";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <1>;
-		samsung,pin-drv = <6>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
 	};
 
 	sd1_bus1: sd1-bus-width1 {
 		samsung,pins = "gpr3-0";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_bus4: sd1-bus-width4 {
 		samsung,pins = "gpr3-1", "gpr3-2", "gpr3-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 
 	sd1_bus8: sd1-bus-width8 {
 		samsung,pins = "gpr3-4", "gpr3-5", "gpr3-6", "gpr3-7";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
 	};
 };
 
@@ -682,22 +684,22 @@
 
 	spi5_bus: spi5-bus {
 		samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 
 	ufs_refclk_out: ufs-refclk-out {
 		samsung,pins = "gpg2-4";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <0>;
-		samsung,pin-drv = <2>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV2>;
 	};
 
 	ufs_rst_n: ufs-rst-n {
 		samsung,pins = "gph1-5";
-		samsung,pin-function = <2>;
-		samsung,pin-pud = <3>;
-		samsung,pin-drv = <0>;
+		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
 	};
 };
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 28+ messages in thread
* Re: [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
  2017-01-18  5:42         ` Pankaj Dubey
@ 2017-01-18 13:40             ` Alim Akhtar
  -1 siblings, 0 replies; 28+ messages in thread
From: Alim Akhtar @ 2017-01-18 13:40 UTC (permalink / raw)
  To: Pankaj Dubey
  Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Alim Akhtar,
	Krzysztof Kozlowski, Javier Martinez Canillas, robh+dt, kgene,
	Sylwester Nawrocki, sanath-Sze3O3UU22JBDgjK7y7TUQ

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> As per Exynos7 datasheet FSYS1 pinctrl block does not support drive
> strength value of 0x3. This patch fixes this and update the correct
> drive strength for sd0_xxx pin definitions.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> index 8232198..7ebb939 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> @@ -497,49 +497,49 @@
>                 samsung,pins = "gpr0-0";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_cmd: sd0-cmd {
>                 samsung,pins = "gpr0-1";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_ds: sd0-ds {
>                 samsung,pins = "gpr0-2";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <1>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_qrdy: sd0-qrdy {
>                 samsung,pins = "gpr0-3";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <1>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus1: sd0-bus-width1 {
>                 samsung,pins = "gpr1-0";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus4: sd0-bus-width4 {
>                 samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus8: sd0-bus-width8 {
>                 samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd1_clk: sd1-clk {
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions
@ 2017-01-18 13:40             ` Alim Akhtar
  0 siblings, 0 replies; 28+ messages in thread
From: Alim Akhtar @ 2017-01-18 13:40 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> As per Exynos7 datasheet FSYS1 pinctrl block does not support drive
> strength value of 0x3. This patch fixes this and update the correct
> drive strength for sd0_xxx pin definitions.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> index 8232198..7ebb939 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> @@ -497,49 +497,49 @@
>                 samsung,pins = "gpr0-0";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_cmd: sd0-cmd {
>                 samsung,pins = "gpr0-1";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_ds: sd0-ds {
>                 samsung,pins = "gpr0-2";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <1>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_qrdy: sd0-qrdy {
>                 samsung,pins = "gpr0-3";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <1>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus1: sd0-bus-width1 {
>                 samsung,pins = "gpr1-0";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus4: sd0-bus-width4 {
>                 samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd0_bus8: sd0-bus-width8 {
>                 samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
>                 samsung,pin-function = <2>;
>                 samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-drv = <4>;
>         };
>
>         sd1_clk: sd1-clk {
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Regards,
Alim

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
  2017-01-18  5:42       ` Pankaj Dubey
@ 2017-01-18 13:42           ` Alim Akhtar
  -1 siblings, 0 replies; 28+ messages in thread
From: Alim Akhtar @ 2017-01-18 13:42 UTC (permalink / raw)
  To: Pankaj Dubey
  Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Krzysztof Kozlowski, kgene,
	robh+dt, sanath-Sze3O3UU22JBDgjK7y7TUQ, Javier Martinez Canillas,
	Sylwester Nawrocki, Alim Akhtar

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> pinctrl driver strength related macros which will be used in Exynos7
> DTSi files.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h
> index 6276eb7..3f1d583 100644
> --- a/include/dt-bindings/pinctrl/samsung.h
> +++ b/include/dt-bindings/pinctrl/samsung.h
> @@ -54,4 +54,12 @@
>  #define EXYNOS_PIN_FUNC_6              6
>  #define EXYNOS_PIN_FUNC_F              0xf
>
> +/* Drive strengths for Exynos7 FSYS1 block */
> +#define EXYNOS7_FSYS1_PIN_DRV_LV1      0
> +#define EXYNOS7_FSYS1_PIN_DRV_LV2      4
> +#define EXYNOS7_FSYS1_PIN_DRV_LV3      2
> +#define EXYNOS7_FSYS1_PIN_DRV_LV4      6
> +#define EXYNOS7_FSYS1_PIN_DRV_LV5      1
> +#define EXYNOS7_FSYS1_PIN_DRV_LV6      5
> +
>  #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Regards,
Alim
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-01-18 13:42           ` Alim Akhtar
  0 siblings, 0 replies; 28+ messages in thread
From: Alim Akhtar @ 2017-01-18 13:42 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> pinctrl driver strength related macros which will be used in Exynos7
> DTSi files.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/samsung.h b/include/dt-bindings/pinctrl/samsung.h
> index 6276eb7..3f1d583 100644
> --- a/include/dt-bindings/pinctrl/samsung.h
> +++ b/include/dt-bindings/pinctrl/samsung.h
> @@ -54,4 +54,12 @@
>  #define EXYNOS_PIN_FUNC_6              6
>  #define EXYNOS_PIN_FUNC_F              0xf
>
> +/* Drive strengths for Exynos7 FSYS1 block */
> +#define EXYNOS7_FSYS1_PIN_DRV_LV1      0
> +#define EXYNOS7_FSYS1_PIN_DRV_LV2      4
> +#define EXYNOS7_FSYS1_PIN_DRV_LV3      2
> +#define EXYNOS7_FSYS1_PIN_DRV_LV4      6
> +#define EXYNOS7_FSYS1_PIN_DRV_LV5      1
> +#define EXYNOS7_FSYS1_PIN_DRV_LV6      5
> +
>  #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Regards,
Alim

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
  2017-01-18  5:42       ` Pankaj Dubey
@ 2017-01-18 13:43         ` Alim Akhtar
  -1 siblings, 0 replies; 28+ messages in thread
From: Alim Akhtar @ 2017-01-18 13:43 UTC (permalink / raw)
  To: Pankaj Dubey
  Cc: devicetree, linux-samsung-soc, Sylwester Nawrocki,
	Krzysztof Kozlowski, Javier Martinez Canillas, robh+dt, kgene,
	Alim Akhtar, sanath, linux-arm-kernel

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier to
> read.  One does not have to remember which value means pull-up/down or
> specific driver strength.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
>  2 files changed, 154 insertions(+), 152 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index c528dd5..1b2db9f0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -328,8 +328,8 @@
>  &pinctrl_alive {
>         pmic_irq: pmic-irq {
>                 samsung,pins = "gpa0-2";
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
>         };
>  };
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> index 7ebb939..8f58850 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> @@ -12,6 +12,8 @@
>   * published by the Free Software Foundation.
>  */
>
> +#include <dt-bindings/pinctrl/samsung.h>
> +
>  &pinctrl_alive {
>         gpa0: gpa0 {
>                 gpio-controller;
> @@ -187,163 +189,163 @@
>
>         hs_i2c10_bus: hs-i2c10-bus {
>                 samsung,pins = "gpb0-1", "gpb0-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c11_bus: hs-i2c11-bus {
>                 samsung,pins = "gpb0-3", "gpb0-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c2_bus: hs-i2c2-bus {
>                 samsung,pins = "gpd0-3", "gpd0-2";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart0_data: uart0-data {
>                 samsung,pins = "gpd0-0", "gpd0-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart0_fctl: uart0-fctl {
>                 samsung,pins = "gpd0-2", "gpd0-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart2_data: uart2-data {
>                 samsung,pins = "gpd1-4", "gpd1-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c3_bus: hs-i2c3-bus {
>                 samsung,pins = "gpd1-3", "gpd1-2";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart1_data: uart1-data {
>                 samsung,pins = "gpd1-0", "gpd1-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart1_fctl: uart1-fctl {
>                 samsung,pins = "gpd1-2", "gpd1-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c0_bus: hs-i2c0-bus {
>                 samsung,pins = "gpd2-1", "gpd2-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c1_bus: hs-i2c1-bus {
>                 samsung,pins = "gpd2-3", "gpd2-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c9_bus: hs-i2c9-bus {
>                 samsung,pins = "gpd2-7", "gpd2-6";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm0_out: pwm0-out {
>                 samsung,pins = "gpd2-4";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm1_out: pwm1-out {
>                 samsung,pins = "gpd2-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm2_out: pwm2-out {
>                 samsung,pins = "gpd2-6";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm3_out: pwm3-out {
>                 samsung,pins = "gpd2-7";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c8_bus: hs-i2c8-bus {
>                 samsung,pins = "gpd5-3", "gpd5-2";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart3_data: uart3-data {
>                 samsung,pins = "gpd5-0", "gpd5-1";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         spi2_bus: spi2-bus {
>                 samsung,pins = "gpd5-0", "gpd5-1", "gpd5-2", "gpd5-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         spi1_bus: spi1-bus {
>                 samsung,pins = "gpd6-2", "gpd6-3", "gpd6-4", "gpd6-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         spi0_bus: spi0-bus {
>                 samsung,pins = "gpd8-0", "gpd8-1", "gpd6-0", "gpd6-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c4_bus: hs-i2c4-bus {
>                 samsung,pins = "gpg3-1", "gpg3-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c5_bus: hs-i2c5-bus {
>                 samsung,pins = "gpg3-3", "gpg3-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -358,9 +360,9 @@
>
>         hs_i2c6_bus: hs-i2c6-bus {
>                 samsung,pins = "gpj0-1", "gpj0-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -375,9 +377,9 @@
>
>         hs_i2c7_bus: hs-i2c7-bus {
>                 samsung,pins = "gpj1-1", "gpj1-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -392,9 +394,9 @@
>
>         spi3_bus: spi3-bus {
>                 samsung,pins = "gpg4-0", "gpg4-1", "gpg4-2", "gpg4-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -409,9 +411,9 @@
>
>         spi4_bus: spi4-bus {
>                 samsung,pins = "gpv7-0", "gpv7-1", "gpv7-2", "gpv7-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -426,37 +428,37 @@
>
>         sd2_clk: sd2-clk {
>                 samsung,pins = "gpr4-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_cmd: sd2-cmd {
>                 samsung,pins = "gpr4-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_cd: sd2-cd {
>                 samsung,pins = "gpr4-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_bus1: sd2-bus-width1 {
>                 samsung,pins = "gpr4-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_bus4: sd2-bus-width4 {
>                 samsung,pins = "gpr4-4", "gpr4-5", "gpr4-6";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>  };
>
> @@ -495,107 +497,107 @@
>
>         sd0_clk: sd0-clk {
>                 samsung,pins = "gpr0-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_cmd: sd0-cmd {
>                 samsung,pins = "gpr0-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_ds: sd0-ds {
>                 samsung,pins = "gpr0-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_qrdy: sd0-qrdy {
>                 samsung,pins = "gpr0-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_bus1: sd0-bus-width1 {
>                 samsung,pins = "gpr1-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_bus4: sd0-bus-width4 {
>                 samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_bus8: sd0-bus-width8 {
>                 samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd1_clk: sd1-clk {
>                 samsung,pins = "gpr2-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_cmd: sd1-cmd {
>                 samsung,pins = "gpr2-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_ds: sd1-ds {
>                 samsung,pins = "gpr2-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <6>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
>         };
>
>         sd1_qrdy: sd1-qrdy {
>                 samsung,pins = "gpr2-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <6>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
>         };
>
>         sd1_int: sd1-int {
>                 samsung,pins = "gpr2-4";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <6>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
>         };
>
>         sd1_bus1: sd1-bus-width1 {
>                 samsung,pins = "gpr3-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_bus4: sd1-bus-width4 {
>                 samsung,pins = "gpr3-1", "gpr3-2", "gpr3-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_bus8: sd1-bus-width8 {
>                 samsung,pins = "gpr3-4", "gpr3-5", "gpr3-6", "gpr3-7";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>  };
>
> @@ -682,22 +684,22 @@
>
>         spi5_bus: spi5-bus {
>                 samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         ufs_refclk_out: ufs-refclk-out {
>                 samsung,pins = "gpg2-4";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV2>;
>         };
>
>         ufs_rst_n: ufs-rst-n {
>                 samsung,pins = "gph1-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Regards,
Alim

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
@ 2017-01-18 13:43         ` Alim Akhtar
  0 siblings, 0 replies; 28+ messages in thread
From: Alim Akhtar @ 2017-01-18 13:43 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On Wed, Jan 18, 2017 at 2:42 PM, Pankaj Dubey <pankaj.dubey@samsung.com> wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier to
> read.  One does not have to remember which value means pull-up/down or
> specific driver strength.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Looks good.
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
>  2 files changed, 154 insertions(+), 152 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index c528dd5..1b2db9f0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -328,8 +328,8 @@
>  &pinctrl_alive {
>         pmic_irq: pmic-irq {
>                 samsung,pins = "gpa0-2";
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
>         };
>  };
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> index 7ebb939..8f58850 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi
> @@ -12,6 +12,8 @@
>   * published by the Free Software Foundation.
>  */
>
> +#include <dt-bindings/pinctrl/samsung.h>
> +
>  &pinctrl_alive {
>         gpa0: gpa0 {
>                 gpio-controller;
> @@ -187,163 +189,163 @@
>
>         hs_i2c10_bus: hs-i2c10-bus {
>                 samsung,pins = "gpb0-1", "gpb0-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c11_bus: hs-i2c11-bus {
>                 samsung,pins = "gpb0-3", "gpb0-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c2_bus: hs-i2c2-bus {
>                 samsung,pins = "gpd0-3", "gpd0-2";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart0_data: uart0-data {
>                 samsung,pins = "gpd0-0", "gpd0-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart0_fctl: uart0-fctl {
>                 samsung,pins = "gpd0-2", "gpd0-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart2_data: uart2-data {
>                 samsung,pins = "gpd1-4", "gpd1-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c3_bus: hs-i2c3-bus {
>                 samsung,pins = "gpd1-3", "gpd1-2";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart1_data: uart1-data {
>                 samsung,pins = "gpd1-0", "gpd1-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart1_fctl: uart1-fctl {
>                 samsung,pins = "gpd1-2", "gpd1-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c0_bus: hs-i2c0-bus {
>                 samsung,pins = "gpd2-1", "gpd2-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c1_bus: hs-i2c1-bus {
>                 samsung,pins = "gpd2-3", "gpd2-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c9_bus: hs-i2c9-bus {
>                 samsung,pins = "gpd2-7", "gpd2-6";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm0_out: pwm0-out {
>                 samsung,pins = "gpd2-4";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm1_out: pwm1-out {
>                 samsung,pins = "gpd2-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm2_out: pwm2-out {
>                 samsung,pins = "gpd2-6";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         pwm3_out: pwm3-out {
>                 samsung,pins = "gpd2-7";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c8_bus: hs-i2c8-bus {
>                 samsung,pins = "gpd5-3", "gpd5-2";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         uart3_data: uart3-data {
>                 samsung,pins = "gpd5-0", "gpd5-1";
> -               samsung,pin-function = <3>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         spi2_bus: spi2-bus {
>                 samsung,pins = "gpd5-0", "gpd5-1", "gpd5-2", "gpd5-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         spi1_bus: spi1-bus {
>                 samsung,pins = "gpd6-2", "gpd6-3", "gpd6-4", "gpd6-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         spi0_bus: spi0-bus {
>                 samsung,pins = "gpd8-0", "gpd8-1", "gpd6-0", "gpd6-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c4_bus: hs-i2c4-bus {
>                 samsung,pins = "gpg3-1", "gpg3-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         hs_i2c5_bus: hs-i2c5-bus {
>                 samsung,pins = "gpg3-3", "gpg3-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -358,9 +360,9 @@
>
>         hs_i2c6_bus: hs-i2c6-bus {
>                 samsung,pins = "gpj0-1", "gpj0-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -375,9 +377,9 @@
>
>         hs_i2c7_bus: hs-i2c7-bus {
>                 samsung,pins = "gpj1-1", "gpj1-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -392,9 +394,9 @@
>
>         spi3_bus: spi3-bus {
>                 samsung,pins = "gpg4-0", "gpg4-1", "gpg4-2", "gpg4-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -409,9 +411,9 @@
>
>         spi4_bus: spi4-bus {
>                 samsung,pins = "gpv7-0", "gpv7-1", "gpv7-2", "gpv7-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
>
> @@ -426,37 +428,37 @@
>
>         sd2_clk: sd2-clk {
>                 samsung,pins = "gpr4-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_cmd: sd2-cmd {
>                 samsung,pins = "gpr4-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_cd: sd2-cd {
>                 samsung,pins = "gpr4-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_bus1: sd2-bus-width1 {
>                 samsung,pins = "gpr4-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>
>         sd2_bus4: sd2-bus-width4 {
>                 samsung,pins = "gpr4-4", "gpr4-5", "gpr4-6";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <3>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV4>;
>         };
>  };
>
> @@ -495,107 +497,107 @@
>
>         sd0_clk: sd0-clk {
>                 samsung,pins = "gpr0-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_cmd: sd0-cmd {
>                 samsung,pins = "gpr0-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_ds: sd0-ds {
>                 samsung,pins = "gpr0-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_qrdy: sd0-qrdy {
>                 samsung,pins = "gpr0-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_bus1: sd0-bus-width1 {
>                 samsung,pins = "gpr1-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_bus4: sd0-bus-width4 {
>                 samsung,pins = "gpr1-1", "gpr1-2", "gpr1-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd0_bus8: sd0-bus-width8 {
>                 samsung,pins = "gpr1-4", "gpr1-5", "gpr1-6", "gpr1-7";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <4>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV2>;
>         };
>
>         sd1_clk: sd1-clk {
>                 samsung,pins = "gpr2-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_cmd: sd1-cmd {
>                 samsung,pins = "gpr2-1";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_ds: sd1-ds {
>                 samsung,pins = "gpr2-2";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <6>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
>         };
>
>         sd1_qrdy: sd1-qrdy {
>                 samsung,pins = "gpr2-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <6>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
>         };
>
>         sd1_int: sd1-int {
>                 samsung,pins = "gpr2-4";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <1>;
> -               samsung,pin-drv = <6>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV4>;
>         };
>
>         sd1_bus1: sd1-bus-width1 {
>                 samsung,pins = "gpr3-0";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_bus4: sd1-bus-width4 {
>                 samsung,pins = "gpr3-1", "gpr3-2", "gpr3-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>
>         sd1_bus8: sd1-bus-width8 {
>                 samsung,pins = "gpr3-4", "gpr3-5", "gpr3-6", "gpr3-7";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS7_FSYS1_PIN_DRV_LV3>;
>         };
>  };
>
> @@ -682,22 +684,22 @@
>
>         spi5_bus: spi5-bus {
>                 samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>
>         ufs_refclk_out: ufs-refclk-out {
>                 samsung,pins = "gpg2-4";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <0>;
> -               samsung,pin-drv = <2>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV2>;
>         };
>
>         ufs_rst_n: ufs-rst-n {
>                 samsung,pins = "gph1-5";
> -               samsung,pin-function = <2>;
> -               samsung,pin-pud = <3>;
> -               samsung,pin-drv = <0>;
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_2>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
>         };
>  };
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel



-- 
Regards,
Alim

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
  2017-01-18  5:42       ` Pankaj Dubey
@ 2017-01-18 14:19         ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-18 14:19 UTC (permalink / raw)
  To: Pankaj Dubey
  Cc: devicetree, linux-samsung-soc, alim.akhtar, robh+dt, javier,
	kgene, krzk, s.nawrocki, sanath, linux-arm-kernel

On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> pinctrl driver strength related macros which will be used in Exynos7
> DTSi files.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

I will need this header, so Sylwester if it is okay with you, could you
provide a tag with it (or ack it)?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-01-18 14:19         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-18 14:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> pinctrl driver strength related macros which will be used in Exynos7
> DTSi files.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

I will need this header, so Sylwester if it is okay with you, could you
provide a tag with it (or ack it)?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
  2017-01-18  5:42       ` Pankaj Dubey
@ 2017-01-18 15:01         ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-18 15:01 UTC (permalink / raw)
  To: Pankaj Dubey
  Cc: linux-samsung-soc, linux-arm-kernel, devicetree, krzk, kgene,
	robh+dt, sanath, javier, s.nawrocki, alim.akhtar

On Wed, Jan 18, 2017 at 11:12:21AM +0530, Pankaj Dubey wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier to
> read.  One does not have to remember which value means pull-up/down or
> specific driver strength.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
>  2 files changed, 154 insertions(+), 152 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index c528dd5..1b2db9f0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -328,8 +328,8 @@
>  &pinctrl_alive {
>  	pmic_irq: pmic-irq {
>  		samsung,pins = "gpa0-2";
> -		samsung,pin-pud = <3>;
> -		samsung,pin-drv = <3>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
>  	};
>  };

This is not equal (value 3 => 1). If the change was intended, please do
in separate patch.

Rest looks fine.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
@ 2017-01-18 15:01         ` Krzysztof Kozlowski
  0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-18 15:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Jan 18, 2017 at 11:12:21AM +0530, Pankaj Dubey wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier to
> read.  One does not have to remember which value means pull-up/down or
> specific driver strength.
> 
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
>  2 files changed, 154 insertions(+), 152 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> index c528dd5..1b2db9f0 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
> @@ -328,8 +328,8 @@
>  &pinctrl_alive {
>  	pmic_irq: pmic-irq {
>  		samsung,pins = "gpa0-2";
> -		samsung,pin-pud = <3>;
> -		samsung,pin-drv = <3>;
> +		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
>  	};
>  };

This is not equal (value 3 => 1). If the change was intended, please do
in separate patch.

Rest looks fine.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
  2017-01-18 15:01         ` Krzysztof Kozlowski
@ 2017-01-20  3:19           ` pankaj.dubey
  -1 siblings, 0 replies; 28+ messages in thread
From: pankaj.dubey @ 2017-01-20  3:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: devicetree, linux-samsung-soc, alim.akhtar, javier, robh+dt,
	kgene, s.nawrocki, sanath, linux-arm-kernel

Hi Krzysztof,

On Wednesday 18 January 2017 08:31 PM, Krzysztof Kozlowski wrote:
> On Wed, Jan 18, 2017 at 11:12:21AM +0530, Pankaj Dubey wrote:
>> Usage of DTS macros instead of hard-coded numbers makes code easier to
>> read.  One does not have to remember which value means pull-up/down or
>> specific driver strength.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
>>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
>>  2 files changed, 154 insertions(+), 152 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>> index c528dd5..1b2db9f0 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>> @@ -328,8 +328,8 @@
>>  &pinctrl_alive {
>>  	pmic_irq: pmic-irq {
>>  		samsung,pins = "gpa0-2";
>> -		samsung,pin-pud = <3>;
>> -		samsung,pin-drv = <3>;
>> +		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
>>  	};
>>  };
> 
> This is not equal (value 3 => 1). If the change was intended, please do
> in separate patch.
> 

This was not an intended change. It should be EXYNOS4_PIN_DRV_LV4, I
will submit another set after fixing this.

Thanks,
Pankaj Dubey

> Rest looks fine.
> 
> Best regards,
> Krzysztof
> 
> 
> 

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7
@ 2017-01-20  3:19           ` pankaj.dubey
  0 siblings, 0 replies; 28+ messages in thread
From: pankaj.dubey @ 2017-01-20  3:19 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Krzysztof,

On Wednesday 18 January 2017 08:31 PM, Krzysztof Kozlowski wrote:
> On Wed, Jan 18, 2017 at 11:12:21AM +0530, Pankaj Dubey wrote:
>> Usage of DTS macros instead of hard-coded numbers makes code easier to
>> read.  One does not have to remember which value means pull-up/down or
>> specific driver strength.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |   4 +-
>>  arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 302 ++++++++++++------------
>>  2 files changed, 154 insertions(+), 152 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>> index c528dd5..1b2db9f0 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>> @@ -328,8 +328,8 @@
>>  &pinctrl_alive {
>>  	pmic_irq: pmic-irq {
>>  		samsung,pins = "gpa0-2";
>> -		samsung,pin-pud = <3>;
>> -		samsung,pin-drv = <3>;
>> +		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
>> +		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
>>  	};
>>  };
> 
> This is not equal (value 3 => 1). If the change was intended, please do
> in separate patch.
> 

This was not an intended change. It should be EXYNOS4_PIN_DRV_LV4, I
will submit another set after fixing this.

Thanks,
Pankaj Dubey

> Rest looks fine.
> 
> Best regards,
> Krzysztof
> 
> 
> 

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
  2017-01-18 14:19         ` Krzysztof Kozlowski
@ 2017-01-27 12:25           ` Sylwester Nawrocki
  -1 siblings, 0 replies; 28+ messages in thread
From: Sylwester Nawrocki @ 2017-01-27 12:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: devicetree, linux-samsung-soc, Pankaj Dubey, Linus Walleij,
	javier, robh+dt, kgene, alim.akhtar, sanath, linux-arm-kernel

On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
> On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
>> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
>> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
>> pinctrl driver strength related macros which will be used in Exynos7
>> DTSi files.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
> 
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> I will need this header, so Sylwester if it is okay with you, could you
> provide a tag with it (or ack it)?

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

I don't have pinctrl/samsung git tree, Linus applies patches directly.

-- 
Regards,
Sylwester

> diff --git a/include/dt-bindings/pinctrl/samsung.h
b/include/dt-bindings/pinctrl/samsung.h
> index 6276eb7..3f1d583 100644
> --- a/include/dt-bindings/pinctrl/samsung.h
> +++ b/include/dt-bindings/pinctrl/samsung.h
> @@ -54,4 +54,12 @@
>  #define EXYNOS_PIN_FUNC_6		6
>  #define EXYNOS_PIN_FUNC_F		0xf
>
> +/* Drive strengths for Exynos7 FSYS1 block */
> +#define EXYNOS7_FSYS1_PIN_DRV_LV1	0
> +#define EXYNOS7_FSYS1_PIN_DRV_LV2	4
> +#define EXYNOS7_FSYS1_PIN_DRV_LV3	2
> +#define EXYNOS7_FSYS1_PIN_DRV_LV4	6
> +#define EXYNOS7_FSYS1_PIN_DRV_LV5	1
> +#define EXYNOS7_FSYS1_PIN_DRV_LV6	5
> +
>  #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
> -- 2.7.4

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-01-27 12:25           ` Sylwester Nawrocki
  0 siblings, 0 replies; 28+ messages in thread
From: Sylwester Nawrocki @ 2017-01-27 12:25 UTC (permalink / raw)
  To: linux-arm-kernel

On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
> On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
>> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
>> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
>> pinctrl driver strength related macros which will be used in Exynos7
>> DTSi files.
>>
>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> ---
>>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
> 
> Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> I will need this header, so Sylwester if it is okay with you, could you
> provide a tag with it (or ack it)?

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

I don't have pinctrl/samsung git tree, Linus applies patches directly.

-- 
Regards,
Sylwester

> diff --git a/include/dt-bindings/pinctrl/samsung.h
b/include/dt-bindings/pinctrl/samsung.h
> index 6276eb7..3f1d583 100644
> --- a/include/dt-bindings/pinctrl/samsung.h
> +++ b/include/dt-bindings/pinctrl/samsung.h
> @@ -54,4 +54,12 @@
>  #define EXYNOS_PIN_FUNC_6		6
>  #define EXYNOS_PIN_FUNC_F		0xf
>
> +/* Drive strengths for Exynos7 FSYS1 block */
> +#define EXYNOS7_FSYS1_PIN_DRV_LV1	0
> +#define EXYNOS7_FSYS1_PIN_DRV_LV2	4
> +#define EXYNOS7_FSYS1_PIN_DRV_LV3	2
> +#define EXYNOS7_FSYS1_PIN_DRV_LV4	6
> +#define EXYNOS7_FSYS1_PIN_DRV_LV5	1
> +#define EXYNOS7_FSYS1_PIN_DRV_LV6	5
> +
>  #endif /* __DT_BINDINGS_PINCTRL_SAMSUNG_H__ */
> -- 2.7.4

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
  2017-01-27 12:25           ` Sylwester Nawrocki
@ 2017-01-27 14:41             ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-27 14:41 UTC (permalink / raw)
  To: Sylwester Nawrocki, Linus Walleij
  Cc: Pankaj Dubey, linux-samsung-soc, linux-arm-kernel, devicetree,
	kgene, robh+dt, sanath, javier, alim.akhtar

On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote:
> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> >> pinctrl driver strength related macros which will be used in Exynos7
> >> DTSi files.
> >>
> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >> ---
> >>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >>
> > 
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > I will need this header, so Sylwester if it is okay with you, could you
> > provide a tag with it (or ack it)?
> 
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> I don't have pinctrl/samsung git tree, Linus applies patches directly.

Oh, my mistake.

Linus,
This is similar case as "pinctrl: dt-bindings: samsung: add drive
strength macros for Exynos5433" [1].

Best regards,
Krzysztof

[1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=for-v4.11/pinctrl-macros

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-01-27 14:41             ` Krzysztof Kozlowski
  0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-27 14:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote:
> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> >> pinctrl driver strength related macros which will be used in Exynos7
> >> DTSi files.
> >>
> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >> ---
> >>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
> >>  1 file changed, 8 insertions(+)
> >>
> > 
> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> > 
> > I will need this header, so Sylwester if it is okay with you, could you
> > provide a tag with it (or ack it)?
> 
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> 
> I don't have pinctrl/samsung git tree, Linus applies patches directly.

Oh, my mistake.

Linus,
This is similar case as "pinctrl: dt-bindings: samsung: add drive
strength macros for Exynos5433" [1].

Best regards,
Krzysztof

[1] https://git.kernel.org/cgit/linux/kernel/git/krzk/linux.git/log/?h=for-v4.11/pinctrl-macros

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
  2017-01-27 14:41             ` Krzysztof Kozlowski
@ 2017-02-01 12:51               ` Linus Walleij
  -1 siblings, 0 replies; 28+ messages in thread
From: Linus Walleij @ 2017-02-01 12:51 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Sylwester Nawrocki, Pankaj Dubey, linux-samsung-soc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Kukjin Kim, Rob Herring,
	sanath-Sze3O3UU22JBDgjK7y7TUQ, Javier Martinez Canillas, root

On Fri, Jan 27, 2017 at 3:41 PM, Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote:
>> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
>> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
>> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
>> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
>> >> pinctrl driver strength related macros which will be used in Exynos7
>> >> DTSi files.
>> >>
>> >> Signed-off-by: Pankaj Dubey <pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> >> ---
>> >>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>> >>  1 file changed, 8 insertions(+)
>> >>
>> >
>> > Acked-by: Krzysztof Kozlowski <krzk-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> >
>> > I will need this header, so Sylwester if it is okay with you, could you
>> > provide a tag with it (or ack it)?
>>
>> Acked-by: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>
>> I don't have pinctrl/samsung git tree, Linus applies patches directly.
>
> Oh, my mistake.
>
> Linus,
> This is similar case as "pinctrl: dt-bindings: samsung: add drive
> strength macros for Exynos5433" [1].

OK
Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

I expect that you take it through ARM SoC and/or send me a pull
request for it on an immutable branch, whatever is best.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-02-01 12:51               ` Linus Walleij
  0 siblings, 0 replies; 28+ messages in thread
From: Linus Walleij @ 2017-02-01 12:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jan 27, 2017 at 3:41 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote:
>> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
>> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
>> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
>> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
>> >> pinctrl driver strength related macros which will be used in Exynos7
>> >> DTSi files.
>> >>
>> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>> >> ---
>> >>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
>> >>  1 file changed, 8 insertions(+)
>> >>
>> >
>> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>> > I will need this header, so Sylwester if it is okay with you, could you
>> > provide a tag with it (or ack it)?
>>
>> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
>>
>> I don't have pinctrl/samsung git tree, Linus applies patches directly.
>
> Oh, my mistake.
>
> Linus,
> This is similar case as "pinctrl: dt-bindings: samsung: add drive
> strength macros for Exynos5433" [1].

OK
Acked-by: Linus Walleij <linus.walleij@linaro.org>

I expect that you take it through ARM SoC and/or send me a pull
request for it on an immutable branch, whatever is best.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 28+ messages in thread
* Re: [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
  2017-02-01 12:51               ` Linus Walleij
@ 2017-02-02 17:05                 ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-02-02 17:05 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Sylwester Nawrocki, Pankaj Dubey, linux-samsung-soc,
	linux-arm-kernel, devicetree, Kukjin Kim, Rob Herring, sanath,
	Javier Martinez Canillas, root

On Wed, Feb 01, 2017 at 01:51:00PM +0100, Linus Walleij wrote:
> On Fri, Jan 27, 2017 at 3:41 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote:
> >> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
> >> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
> >> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> >> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> >> >> pinctrl driver strength related macros which will be used in Exynos7
> >> >> DTSi files.
> >> >>
> >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >> >> ---
> >> >>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
> >> >>  1 file changed, 8 insertions(+)
> >> >>
> >> >
> >> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> >> >
> >> > I will need this header, so Sylwester if it is okay with you, could you
> >> > provide a tag with it (or ack it)?
> >>
> >> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >>
> >> I don't have pinctrl/samsung git tree, Linus applies patches directly.
> >
> > Oh, my mistake.
> >
> > Linus,
> > This is similar case as "pinctrl: dt-bindings: samsung: add drive
> > strength macros for Exynos5433" [1].
> 
> OK
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I expect that you take it through ARM SoC and/or send me a pull
> request for it on an immutable branch, whatever is best.

Yes, I'll include them in my pull request to arm-soc.

Below is stable tag if you need it:


The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

  Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-pinctrl-4.11

for you to fetch changes up to 860ac88abecab5d3d0e07306365f55cbc690c220:

  pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions (2017-02-02 18:59:49 +0200)

----------------------------------------------------------------
Defines for GPIO drive strengths on Exynos5433 and Exynos7, used in Device Tree
sources.

----------------------------------------------------------------
Andi Shyti (1):
      pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433

Pankaj Dubey (1):
      pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions

 include/dt-bindings/pinctrl/samsung.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

^ permalink raw reply	[flat|nested] 28+ messages in thread
* [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions
@ 2017-02-02 17:05                 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2017-02-02 17:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 01, 2017 at 01:51:00PM +0100, Linus Walleij wrote:
> On Fri, Jan 27, 2017 at 3:41 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > On Fri, Jan 27, 2017 at 01:25:42PM +0100, Sylwester Nawrocki wrote:
> >> On 01/18/2017 03:19 PM, Krzysztof Kozlowski wrote:
> >> > On Wed, Jan 18, 2017 at 11:12:20AM +0530, Pankaj Dubey wrote:
> >> >> Exynos7 SoC pinctrl configurations are similar to existing Exynos4/5 except
> >> >> for FSYS1 pinctrl drive strengths. So adding Exynos7 specific FSYS1 blocks
> >> >> pinctrl driver strength related macros which will be used in Exynos7
> >> >> DTSi files.
> >> >>
> >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >> >> ---
> >> >>  include/dt-bindings/pinctrl/samsung.h | 8 ++++++++
> >> >>  1 file changed, 8 insertions(+)
> >> >>
> >> >
> >> > Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
> >> >
> >> > I will need this header, so Sylwester if it is okay with you, could you
> >> > provide a tag with it (or ack it)?
> >>
> >> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >>
> >> I don't have pinctrl/samsung git tree, Linus applies patches directly.
> >
> > Oh, my mistake.
> >
> > Linus,
> > This is similar case as "pinctrl: dt-bindings: samsung: add drive
> > strength macros for Exynos5433" [1].
> 
> OK
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I expect that you take it through ARM SoC and/or send me a pull
> request for it on an immutable branch, whatever is best.

Yes, I'll include them in my pull request to arm-soc.

Below is stable tag if you need it:


The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

  Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git tags/samsung-pinctrl-4.11

for you to fetch changes up to 860ac88abecab5d3d0e07306365f55cbc690c220:

  pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions (2017-02-02 18:59:49 +0200)

----------------------------------------------------------------
Defines for GPIO drive strengths on Exynos5433 and Exynos7, used in Device Tree
sources.

----------------------------------------------------------------
Andi Shyti (1):
      pinctrl: dt-bindings: samsung: add drive strength macros for Exynos5433

Pankaj Dubey (1):
      pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions

 include/dt-bindings/pinctrl/samsung.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

^ permalink raw reply	[flat|nested] 28+ messages in thread
end of thread, other threads:[~2017-02-02 17:05 UTC | newest]

Thread overview: 28+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20170118053944epcas1p1bed1518b3ba444434bfbe4048b6fe4bd@epcas1p1.samsung.com>
2017-01-18  5:42 ` [PATCH 0/3] Use macros for pinctrl configuration on Exynos7 Pankaj Dubey
2017-01-18  5:42   ` Pankaj Dubey
     [not found]   ` <CGME20170118053953epcas1p18e06184783a0edc6a2cfc3b6a9d9ce31@epcas1p1.samsung.com>
     [not found]     ` <1484718141-28785-1-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-18  5:42       ` [PATCH 1/3] arm64: dts: exynos: Fix drive strength of sd0_xxx pin definitions Pankaj Dubey
2017-01-18  5:42         ` Pankaj Dubey
     [not found]         ` <1484718141-28785-2-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-18 13:40           ` Alim Akhtar
2017-01-18 13:40             ` Alim Akhtar
     [not found]   ` <CGME20170118054002epcas5p3b08e2f419976e17a3c584d64776810fd@epcas5p3.samsung.com>
2017-01-18  5:42     ` [PATCH 2/3] pinctrl: dt-bindings: samsung: Add Exynos7 specific pinctrl macro definitions Pankaj Dubey
2017-01-18  5:42       ` Pankaj Dubey
     [not found]       ` <1484718141-28785-3-git-send-email-pankaj.dubey-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-18 13:42         ` Alim Akhtar
2017-01-18 13:42           ` Alim Akhtar
2017-01-18 14:19       ` Krzysztof Kozlowski
2017-01-18 14:19         ` Krzysztof Kozlowski
2017-01-27 12:25         ` Sylwester Nawrocki
2017-01-27 12:25           ` Sylwester Nawrocki
2017-01-27 14:41           ` Krzysztof Kozlowski
2017-01-27 14:41             ` Krzysztof Kozlowski
2017-02-01 12:51             ` Linus Walleij
2017-02-01 12:51               ` Linus Walleij
2017-02-02 17:05               ` Krzysztof Kozlowski
2017-02-02 17:05                 ` Krzysztof Kozlowski
     [not found]   ` <CGME20170118054013epcas5p3b20dca776ee350f4ba863db24d3dea67@epcas5p3.samsung.com>
2017-01-18  5:42     ` [PATCH 3/3] arm64: dts: exynos: Use macros for pinctrl configuration on Exynos7 Pankaj Dubey
2017-01-18  5:42       ` Pankaj Dubey
2017-01-18 13:43       ` Alim Akhtar
2017-01-18 13:43         ` Alim Akhtar
2017-01-18 15:01       ` Krzysztof Kozlowski
2017-01-18 15:01         ` Krzysztof Kozlowski
2017-01-20  3:19         ` pankaj.dubey
2017-01-20  3:19           ` pankaj.dubey

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.