Re: [PATCH 0/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

Re: [PATCH 0/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

Sorry, wrong post, it should go to bitbake mailing list.

// Robert

On 11/30/18 11:39 AM, Robert Yang wrote:
> Hi RP,
> 
> I'd like to change the fatal message to be an event, the benefits are:
> - Things like report-error.bbclass can catch the error
> - It's easier to get bbappends list from an event message than from console log.
> 
> What's your opinion, please ?
> 
> // Robert
> 
> The following changes since commit 41d89552620bfbc94031d314e6b3d0324f7a330e:
> 
>    bitbake: fetch2: Avoid warning about incorrect character escaping in regex (2018-11-27 22:15:34 +0000)
> 
> are available in the git repository at:
> 
>    git://git.pokylinux.org/poky-contrib rbt/append
>    http://git.pokylinux.org/cgit.cgi//log/?h=rbt/append
> 
> Robert Yang (1):
>    cooker: simplify BB_DANGLINGAPPENDS_WARNONLY
> 
>   bitbake/lib/bb/cooker.py | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 

✗ patchtest: failure for cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Patchwork]

== Series Details ==

Series: cooker: simplify BB_DANGLINGAPPENDS_WARNONLY
Revision: 1
URL   : https://patchwork.openembedded.org/series/15147/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series sent to the wrong mailing list or some patches from the series correspond to different mailing lists [test_target_mailing_list] 
  Suggested fix    Send the series again to the correct mailing list (ML)
  Suggested ML     bitbake-devel@lists.openembedded.org [http://git.openembedded.org/bitbake/]
  Patch's path:    bitbake/lib/bb/cooker.py

* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at 21387613fe)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

[PATCH 0/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

Hi RP,

I'd like to change the fatal message to be an event, the benefits are:
- Things like report-error.bbclass can catch the error
- It's easier to get bbappends list from an event message than from console log.

What's your opinion, please ?

// Robert

The following changes since commit 41d89552620bfbc94031d314e6b3d0324f7a330e:

  bitbake: fetch2: Avoid warning about incorrect character escaping in regex (2018-11-27 22:15:34 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib rbt/append
  http://git.pokylinux.org/cgit.cgi//log/?h=rbt/append

Robert Yang (1):
  cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

 bitbake/lib/bb/cooker.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.7.4

[PATCH 1/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

- d.getVar('BB_DANGLINGAPPENDS_WARNONLY', False) -> d.getVar('BB_DANGLINGAPPENDS_WARNONLY')
  There is no reason to use 'False'.

- Use bb.utils.to_boolean for warn_only.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/cooker.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 16681ba..28a16c5 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -928,9 +928,8 @@ class BBCooker:
 
         if appends_without_recipes:
             msg = 'No recipes available for:\n  %s' % '\n  '.join(appends_without_recipes)
-            warn_only = self.data.getVar("BB_DANGLINGAPPENDS_WARNONLY", \
-                 False) or "no"
-            if warn_only.lower() in ("1", "yes", "true"):
+            warn_only = self.data.getVar("BB_DANGLINGAPPENDS_WARNONLY")
+            if bb.utils.to_boolean(warn_only):
                 bb.warn(msg)
             else:
                 bb.fatal(msg)
-- 
2.7.4

[PATCH 0/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

Hi RP,

I'd like to change the fatal message to be an event, the benefits are:
- Things like report-error.bbclass can catch the error
- It's easier to get bbappends list from an event message than from console log.

What's your opinion, please ?

// Robert

The following changes since commit 41d89552620bfbc94031d314e6b3d0324f7a330e:

  bitbake: fetch2: Avoid warning about incorrect character escaping in regex (2018-11-27 22:15:34 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib rbt/append
  http://git.pokylinux.org/cgit.cgi//log/?h=rbt/append

Robert Yang (1):
  cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

 bitbake/lib/bb/cooker.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.7.4

[PATCH 1/1] cooker: simplify BB_DANGLINGAPPENDS_WARNONLY

[Robert Yang]

- d.getVar('BB_DANGLINGAPPENDS_WARNONLY', False) -> d.getVar('BB_DANGLINGAPPENDS_WARNONLY')
  There is no reason to use 'False'.

- Use bb.utils.to_boolean for warn_only.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 bitbake/lib/bb/cooker.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 16681ba..28a16c5 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -928,9 +928,8 @@ class BBCooker:
 
         if appends_without_recipes:
             msg = 'No recipes available for:\n  %s' % '\n  '.join(appends_without_recipes)
-            warn_only = self.data.getVar("BB_DANGLINGAPPENDS_WARNONLY", \
-                 False) or "no"
-            if warn_only.lower() in ("1", "yes", "true"):
+            warn_only = self.data.getVar("BB_DANGLINGAPPENDS_WARNONLY")
+            if bb.utils.to_boolean(warn_only):
                 bb.warn(msg)
             else:
                 bb.fatal(msg)
-- 
2.7.4