All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCHv2 1/5] smart-gateway-mt7688: Rework build time check for overwriting factory data
@ 2019-11-19  1:02 Tom Rini
  2019-11-19  1:02 ` [U-Boot] [PATCHv2 2/5] env: Remove useless CONFIG_ENV_SIZE_REDUND and fix ENV_IS_REDUND check Tom Rini
                   ` (5 more replies)
  0 siblings, 6 replies; 19+ messages in thread
From: Tom Rini @ 2019-11-19  1:02 UTC (permalink / raw)
  To: u-boot

The board file has a build time check to ensure that we do not have the
redundant environment overwriting the factory data.  However, using the
symbol CONFIG_ENV_SIZE_REDUND isn't strictly needed as that is always
the same as CONFIG_ENV_SIZE.  Use CONFIG_ENV_SIZE instead so that we can
later drop CONFIG_ENV_SIZE_REDUND.

Cc: Stefan Roese <sr@denx.de>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Changes in v2:
- As pointed out by Stefan's review, I should address the usage of
  ENV_SIZE_REDUND here first and remove it second.
---
 board/gardena/smart-gateway-mt7688/board.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/gardena/smart-gateway-mt7688/board.c b/board/gardena/smart-gateway-mt7688/board.c
index bd494c84fc80..e9ffd42a8a68 100644
--- a/board/gardena/smart-gateway-mt7688/board.c
+++ b/board/gardena/smart-gateway-mt7688/board.c
@@ -18,7 +18,7 @@
 
 #define FACTORY_DATA_OFFS	0xc0000
 #define FACTORY_DATA_SECT_SIZE	0x10000
-#if ((CONFIG_ENV_OFFSET_REDUND + CONFIG_ENV_SIZE_REDUND) > FACTORY_DATA_OFFS)
+#if ((CONFIG_ENV_OFFSET_REDUND + CONFIG_ENV_SIZE) > FACTORY_DATA_OFFS)
 #error "U-Boot image with environment too big (overlapping with factory-data)!"
 #endif
 #define FACTORY_DATA_USER_OFFS	0x140
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2019-11-21 17:17 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19  1:02 [U-Boot] [PATCHv2 1/5] smart-gateway-mt7688: Rework build time check for overwriting factory data Tom Rini
2019-11-19  1:02 ` [U-Boot] [PATCHv2 2/5] env: Remove useless CONFIG_ENV_SIZE_REDUND and fix ENV_IS_REDUND check Tom Rini
2019-11-19  1:21   ` Simon Glass
2019-11-19  3:26   ` Joe Hershberger
2019-11-21 17:16   ` Tom Rini
2019-11-19  1:02 ` [U-Boot] [PATCHv2 3/5] fsl: layerscape: guard *env_sf_get_env_addr() on CONFIG_ENV_IS_IN_SPI_FLASH Tom Rini
2019-11-21 17:17   ` Tom Rini
2019-11-19  1:02 ` [U-Boot] [PATCHv2 4/5] T1042RDB_PI_NAND_SECURE_BOOT: Guard t104xrdb SPL env code Tom Rini
2019-11-19  5:51   ` Priyanka Jain
2019-11-21 17:17   ` Tom Rini
2019-11-19  1:02 ` [U-Boot] [PATCHv2 5/5] env: Finish migration of common ENV options Tom Rini
2019-11-19 19:57   ` Joseph Hershberger
2019-11-19 21:39   ` Simon Goldschmidt
2019-11-19 21:52     ` Tom Rini
2019-11-20 19:39       ` Simon Goldschmidt
2019-11-20 19:56         ` Tom Rini
2019-11-21 17:17   ` Tom Rini
2019-11-19  6:07 ` [U-Boot] [PATCHv2 1/5] smart-gateway-mt7688: Rework build time check for overwriting factory data Stefan Roese
2019-11-21 17:16 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.