All of lore.kernel.org
 help / color / mirror / Atom feed
From: mawupeng <mawupeng1@huawei.com>
To: <ardb@kernel.org>
Cc: <akpm@linux-foundation.org>, <catalin.marinas@arm.com>,
	<will@kernel.org>, <corbet@lwn.net>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <dvhart@infradead.org>, <andy@infradead.org>,
	<rppt@kernel.org>, <paulmck@kernel.org>, <peterz@infradead.org>,
	<jroedel@suse.de>, <songmuchun@bytedance.com>,
	<macro@orcam.me.uk>, <frederic@kernel.org>, <W_Armin@gmx.de>,
	<john.garry@huawei.com>, <seanjc@google.com>,
	<tsbogend@alpha.franken.de>, <anshuman.khandual@arm.com>,
	<chenhuacai@kernel.org>, <david@redhat.com>,
	<gpiccoli@igalia.com>, <mark.rutland@arm.com>,
	<wangkefeng.wang@huawei.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-efi@vger.kernel.org>, <linux-ia64@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
	<mawupeng1@huawei.com>
Subject: Re: [PATCH 0/2] Add support to relocate kernel image to mirrored region
Date: Mon, 23 May 2022 09:18:37 +0800	[thread overview]
Message-ID: <7a1ce182-343a-75f9-5447-f7ca12cb0c36@huawei.com> (raw)
In-Reply-To: <CAMj1kXHnL12j6FPGtEeSQB2-kHzoVF+LJMUF9YBq43Yi1UntDg@mail.gmail.com>



在 2022/5/20 14:52, Ard Biesheuvel 写道:
> On Thu, 19 May 2022 at 13:09, mawupeng <mawupeng1@huawei.com> wrote:
>>
>>
>>
>> 在 2022/5/7 17:28, mawupeng 写道:
>>>
>>>
>>> 在 2022/5/3 17:58, Ard Biesheuvel 写道:
>>>> On Tue, 19 Apr 2022 at 08:43, Wupeng Ma <mawupeng1@huawei.com> wrote:
>>>>>
>>>>> From: Ma Wupeng <mawupeng1@huawei.com>
>>>>>
>>>>> Now system image will perfer to be located to mirrored regions both KASLR
>>>>> on and off.
>>>>>
>>>>
>>>> Hello Ma Wupeng,
>>>>
>>>> I wonder if we could simplify this as follows:
>>>> - ignore the non-KASLR case for now, and rely on the bootloader  > load the image into mirrored memory if it exists;
>>>
>>> In grub, memory for static image is allocated via the following path:
>>>
>>> grub_cmd_linux
>>>     kernel = grub_malloc(filelen)
>>>     kernel_alloc_addr = grub_efi_allocate_any_pages (kernel_alloc_pages)
>>>     grub_memcpy (kernel_addr, kernel, grub_min(filelen, kernel_size))
>>>      grub_loader_set (grub_linux_boot, grub_linux_unload, 0)
>>>
>>> Can we get memory from mirrored region by the following steps:
>>> 1. get memory map by calling grub_efi_get_memory_map()
>>> 2. iter all memory map to find a suitable mirrored memory area
>>> 3. locate kernel image to this area
>>>
>>> So, if kaslr is not enabled
>>>    - grub will load kernel into mirrored region
>>> else
>>>    - arm64-stub.c will relocate kernel image to mirrored region
>>>
>>> Is this feasible?
>>
>> Is this a feasible proposal to relocate the static kernel image itself
>> into more reliable memory?
>>
> 
> I'm not sure, it all depends on the firmware.
> 
> When GRUB calls LoadImage(), the firmware will reallocate the image
> and unpack it there. So it is really the firmware's job to ensure that
> the image is loaded into a suitable location.
> 
> I have some code here that implements a EFI based decompressor, and
> which loads the kernel image into mirrored memory if it exists,
> without the need to move it again. It could trivially be modified to
> deal with non-randomized loads as well.
> 
> But the bottom line is that UEFI should expose the ability to target
> mirrored memory, hacking around it like this is not a sustainable
> approach.

Since firmware is responsible for put kernel static image into mirrored
region and kernel is responsible for relocate this image into mirrored
region if kaslr is enabled. There is no conflict between these two.

Can we integrate the kernel part(introduce mirrored support to arm64) first?

> .

WARNING: multiple messages have this Message-ID (diff)
From: mawupeng <mawupeng1@huawei.com>
To: <ardb@kernel.org>
Cc: <akpm@linux-foundation.org>, <catalin.marinas@arm.com>,
	<will@kernel.org>,  <corbet@lwn.net>, <tglx@linutronix.de>,
	<mingo@redhat.com>, <bp@alien8.de>, <dave.hansen@linux.intel.com>,
	<x86@kernel.org>, <dvhart@infradead.org>, <andy@infradead.org>,
	<rppt@kernel.org>, <paulmck@kernel.org>, <peterz@infradead.org>,
	<jroedel@suse.de>, <songmuchun@bytedance.com>,
	<macro@orcam.me.uk>, <frederic@kernel.org>, <W_Armin@gmx.de>,
	<john.garry@huawei.com>, <seanjc@google.com>,
	<tsbogend@alpha.franken.de>, <anshuman.khandual@arm.com>,
	<chenhuacai@kernel.org>, <david@redhat.com>,
	<gpiccoli@igalia.com>, <mark.rutland@arm.com>,
	<wangkefeng.wang@huawei.com>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-efi@vger.kernel.org>, <linux-ia64@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <linux-mm@kvack.org>,
	<mawupeng1@huawei.com>
Subject: Re: [PATCH 0/2] Add support to relocate kernel image to mirrored region
Date: Mon, 23 May 2022 09:18:37 +0800	[thread overview]
Message-ID: <7a1ce182-343a-75f9-5447-f7ca12cb0c36@huawei.com> (raw)
In-Reply-To: <CAMj1kXHnL12j6FPGtEeSQB2-kHzoVF+LJMUF9YBq43Yi1UntDg@mail.gmail.com>



在 2022/5/20 14:52, Ard Biesheuvel 写道:
> On Thu, 19 May 2022 at 13:09, mawupeng <mawupeng1@huawei.com> wrote:
>>
>>
>>
>> 在 2022/5/7 17:28, mawupeng 写道:
>>>
>>>
>>> 在 2022/5/3 17:58, Ard Biesheuvel 写道:
>>>> On Tue, 19 Apr 2022 at 08:43, Wupeng Ma <mawupeng1@huawei.com> wrote:
>>>>>
>>>>> From: Ma Wupeng <mawupeng1@huawei.com>
>>>>>
>>>>> Now system image will perfer to be located to mirrored regions both KASLR
>>>>> on and off.
>>>>>
>>>>
>>>> Hello Ma Wupeng,
>>>>
>>>> I wonder if we could simplify this as follows:
>>>> - ignore the non-KASLR case for now, and rely on the bootloader  > load the image into mirrored memory if it exists;
>>>
>>> In grub, memory for static image is allocated via the following path:
>>>
>>> grub_cmd_linux
>>>     kernel = grub_malloc(filelen)
>>>     kernel_alloc_addr = grub_efi_allocate_any_pages (kernel_alloc_pages)
>>>     grub_memcpy (kernel_addr, kernel, grub_min(filelen, kernel_size))
>>>      grub_loader_set (grub_linux_boot, grub_linux_unload, 0)
>>>
>>> Can we get memory from mirrored region by the following steps:
>>> 1. get memory map by calling grub_efi_get_memory_map()
>>> 2. iter all memory map to find a suitable mirrored memory area
>>> 3. locate kernel image to this area
>>>
>>> So, if kaslr is not enabled
>>>    - grub will load kernel into mirrored region
>>> else
>>>    - arm64-stub.c will relocate kernel image to mirrored region
>>>
>>> Is this feasible?
>>
>> Is this a feasible proposal to relocate the static kernel image itself
>> into more reliable memory?
>>
> 
> I'm not sure, it all depends on the firmware.
> 
> When GRUB calls LoadImage(), the firmware will reallocate the image
> and unpack it there. So it is really the firmware's job to ensure that
> the image is loaded into a suitable location.
> 
> I have some code here that implements a EFI based decompressor, and
> which loads the kernel image into mirrored memory if it exists,
> without the need to move it again. It could trivially be modified to
> deal with non-randomized loads as well.
> 
> But the bottom line is that UEFI should expose the ability to target
> mirrored memory, hacking around it like this is not a sustainable
> approach.

Since firmware is responsible for put kernel static image into mirrored
region and kernel is responsible for relocate this image into mirrored
region if kaslr is enabled. There is no conflict between these two.

Can we integrate the kernel part(introduce mirrored support to arm64) first?

> .

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: mawupeng <mawupeng1@huawei.com>
To: ardb@kernel.org
Cc: akpm@linux-foundation.org, catalin.marinas@arm.com,
	will@kernel.org, corbet@lwn.net, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, dvhart@infradead.org, andy@infradead.org,
	rppt@kernel.org, paulmck@kernel.org, peterz@infradead.org,
	jroedel@suse.de, songmuchun@bytedance.com, macro@orcam.me.uk,
	frederic@kernel.org, W_Armin@gmx.de, john.garry@huawei.com,
	seanjc@google.com, tsbogend@alpha.franken.de,
	anshuman.khandual@arm.com, chenhuacai@kernel.org,
	david@redhat.com, gpiccoli@igalia.com, mark.rutland@arm.com,
	wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
	linux-ia64@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-mm@kvack.org, mawupeng1@huawei.com
Subject: Re: [PATCH 0/2] Add support to relocate kernel image to mirrored region
Date: Mon, 23 May 2022 01:18:37 +0000	[thread overview]
Message-ID: <7a1ce182-343a-75f9-5447-f7ca12cb0c36@huawei.com> (raw)
In-Reply-To: <CAMj1kXHnL12j6FPGtEeSQB2-kHzoVF+LJMUF9YBq43Yi1UntDg@mail.gmail.com>



在 2022/5/20 14:52, Ard Biesheuvel 写道:
> On Thu, 19 May 2022 at 13:09, mawupeng <mawupeng1@huawei.com> wrote:
>>
>>
>>
>> 在 2022/5/7 17:28, mawupeng 写道:
>>>
>>>
>>> 在 2022/5/3 17:58, Ard Biesheuvel 写道:
>>>> On Tue, 19 Apr 2022 at 08:43, Wupeng Ma <mawupeng1@huawei.com> wrote:
>>>>>
>>>>> From: Ma Wupeng <mawupeng1@huawei.com>
>>>>>
>>>>> Now system image will perfer to be located to mirrored regions both KASLR
>>>>> on and off.
>>>>>
>>>>
>>>> Hello Ma Wupeng,
>>>>
>>>> I wonder if we could simplify this as follows:
>>>> - ignore the non-KASLR case for now, and rely on the bootloader  > load the image into mirrored memory if it exists;
>>>
>>> In grub, memory for static image is allocated via the following path:
>>>
>>> grub_cmd_linux
>>>     kernel = grub_malloc(filelen)
>>>     kernel_alloc_addr = grub_efi_allocate_any_pages (kernel_alloc_pages)
>>>     grub_memcpy (kernel_addr, kernel, grub_min(filelen, kernel_size))
>>>      grub_loader_set (grub_linux_boot, grub_linux_unload, 0)
>>>
>>> Can we get memory from mirrored region by the following steps:
>>> 1. get memory map by calling grub_efi_get_memory_map()
>>> 2. iter all memory map to find a suitable mirrored memory area
>>> 3. locate kernel image to this area
>>>
>>> So, if kaslr is not enabled
>>>    - grub will load kernel into mirrored region
>>> else
>>>    - arm64-stub.c will relocate kernel image to mirrored region
>>>
>>> Is this feasible?
>>
>> Is this a feasible proposal to relocate the static kernel image itself
>> into more reliable memory?
>>
> 
> I'm not sure, it all depends on the firmware.
> 
> When GRUB calls LoadImage(), the firmware will reallocate the image
> and unpack it there. So it is really the firmware's job to ensure that
> the image is loaded into a suitable location.
> 
> I have some code here that implements a EFI based decompressor, and
> which loads the kernel image into mirrored memory if it exists,
> without the need to move it again. It could trivially be modified to
> deal with non-randomized loads as well.
> 
> But the bottom line is that UEFI should expose the ability to target
> mirrored memory, hacking around it like this is not a sustainable
> approach.

Since firmware is responsible for put kernel static image into mirrored
region and kernel is responsible for relocate this image into mirrored
region if kaslr is enabled. There is no conflict between these two.

Can we integrate the kernel part(introduce mirrored support to arm64) first?

> .

  parent reply	other threads:[~2022-05-23  1:18 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14  9:54 [PATCH v2 0/9] introduce mirrored memory support for arm64 Wupeng Ma
2022-04-14 10:13 ` Wupeng Ma
2022-04-14 10:13 ` Wupeng Ma
2022-04-14  9:54 ` [PATCH v2 1/9] efi: Make efi_print_memmap() public Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:54 ` [PATCH v2 2/9] arm64: efi: Add fake memory support Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:54 ` [PATCH v2 3/9] efi: Make efi_find_mirror() public Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:54 ` [PATCH v2 4/9] arm64/mirror: arm64 enabling - find mirrored memory ranges Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:55 ` [PATCH v2 9/9] ia64/efi: Code simplification in efi_init Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:55 ` [PATCH v2 5/9] mm: Ratelimited mirrored memory related warning messages Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:56 ` [PATCH v2 6/9] mm: Demote warning message in vmemmap_verify() to debug level Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14  9:56 ` [PATCH v2 7/9] mm: Calc the right pfn if page size is not 4K Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-19  9:59   ` David Hildenbrand
2022-04-19  9:59     ` David Hildenbrand
2022-04-19  9:59     ` David Hildenbrand
2022-04-19 11:14   ` Anshuman Khandual
2022-04-19 11:26     ` Anshuman Khandual
2022-04-19 11:14     ` Anshuman Khandual
2022-04-19 18:29     ` Ard Biesheuvel
2022-04-19 18:29       ` Ard Biesheuvel
2022-04-19 18:29       ` Ard Biesheuvel
2022-04-20 22:27       ` Andrew Morton
2022-04-20 22:27         ` Andrew Morton
2022-04-20 22:27         ` Andrew Morton
2022-04-20 22:39         ` Ard Biesheuvel
2022-04-20 22:39           ` Ard Biesheuvel
2022-04-20 22:39           ` Ard Biesheuvel
2022-04-14  9:56 ` [PATCH v2 8/9] efi: Disable mirror feature if kernelcore is not specified Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:13   ` Wupeng Ma
2022-04-14 10:22 ` [PATCH v2 0/9] introduce mirrored memory support for arm64 Ard Biesheuvel
2022-04-14 10:22   ` Ard Biesheuvel
2022-04-14 10:22   ` Ard Biesheuvel
2022-04-16  1:32   ` mawupeng
2022-04-16  1:32     ` mawupeng
2022-04-16  1:32     ` mawupeng
2022-04-19 18:32     ` Ard Biesheuvel
2022-04-19 18:32       ` Ard Biesheuvel
2022-04-19 18:32       ` Ard Biesheuvel
2022-04-20  2:13       ` mawupeng
2022-04-20  2:13         ` mawupeng
2022-04-20  2:13         ` mawupeng
2022-04-19  6:42   ` [PATCH 0/2] Add support to relocate kernel image to mirrored region Wupeng Ma
2022-04-19  7:01     ` Wupeng Ma
2022-04-19  7:01     ` Wupeng Ma
2022-04-19  6:42     ` [PATCH 2/2] arm64/boot: Add support to relocate kernel image to mirrored region without kaslr Wupeng Ma
2022-04-19  7:01       ` Wupeng Ma
2022-04-19  7:01       ` Wupeng Ma
2022-04-19  6:42     ` [PATCH 1/2] arm64/boot/KASLR: Add support to relocate kernel image to mirrored region Wupeng Ma
2022-04-19  7:01       ` Wupeng Ma
2022-04-19  7:01       ` Wupeng Ma
2022-05-03  9:58     ` [PATCH 0/2] " Ard Biesheuvel
2022-05-03  9:58       ` Ard Biesheuvel
2022-05-03  9:58       ` Ard Biesheuvel
2022-05-07  9:28       ` mawupeng
2022-05-07  9:28         ` mawupeng
2022-05-07  9:28         ` mawupeng
2022-05-19 11:09         ` mawupeng
2022-05-19 11:09           ` mawupeng
2022-05-19 11:09           ` mawupeng
2022-05-20  6:52           ` Ard Biesheuvel
2022-05-20  6:52             ` Ard Biesheuvel
2022-05-20  6:52             ` Ard Biesheuvel
2022-05-20  6:52             ` Ard Biesheuvel
2022-05-20  6:52               ` Ard Biesheuvel
2022-05-20  6:52               ` Ard Biesheuvel
2022-05-23 11:48               ` mawupeng
2022-05-23 11:48                 ` mawupeng
2022-05-23 11:48                 ` mawupeng
2022-05-23  1:18             ` mawupeng [this message]
2022-05-23  1:18               ` mawupeng
2022-05-23  1:18               ` mawupeng
2022-05-23 14:41               ` Ard Biesheuvel
2022-05-23 14:41                 ` Ard Biesheuvel
2022-05-23 14:41                 ` Ard Biesheuvel
2022-05-24  1:11                 ` mawupeng
2022-05-24  1:11                   ` mawupeng
2022-05-24  1:11                   ` mawupeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a1ce182-343a-75f9-5447-f7ca12cb0c36@huawei.com \
    --to=mawupeng1@huawei.com \
    --cc=W_Armin@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=andy@infradead.org \
    --cc=anshuman.khandual@arm.com \
    --cc=ardb@kernel.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=dvhart@infradead.org \
    --cc=frederic@kernel.org \
    --cc=gpiccoli@igalia.com \
    --cc=john.garry@huawei.com \
    --cc=jroedel@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=macro@orcam.me.uk \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=seanjc@google.com \
    --cc=songmuchun@bytedance.com \
    --cc=tglx@linutronix.de \
    --cc=tsbogend@alpha.franken.de \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.