All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Price <steven.price@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
	James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Dave Martin <Dave.Martin@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Haibo Xu <Haibo.Xu@arm.com>, Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH v14 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage()
Date: Wed, 9 Jun 2021 09:56:43 +0100	[thread overview]
Message-ID: <7a3f14de-211b-94f9-6886-393d233193d5@arm.com> (raw)
In-Reply-To: <20210607170714.GA17957@arm.com>

On 07/06/2021 18:07, Catalin Marinas wrote:
> On Mon, Jun 07, 2021 at 12:08:10PM +0100, Steven Price wrote:
>> From: Catalin Marinas <catalin.marinas@arm.com>
>>
>> Currently, on an anonymous page fault, the kernel allocates a zeroed
>> page and maps it in user space. If the mapping is tagged (PROT_MTE),
>> set_pte_at() additionally clears the tags under a spinlock to avoid a
>> race on the page->flags. In order to optimise the lock, clear the page
>> tags on allocation in __alloc_zeroed_user_highpage() if the vma flags
>> have VM_MTE set.
>>
>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>> Signed-off-by: Steven Price <steven.price@arm.com>
> 
> I think you can drop this patch now that Peter's series has been queued
> via the arm64 tree:
> 
> https://lore.kernel.org/r/20210602235230.3928842-4-pcc@google.com
> 

Thanks for the heads up - I hadn't seen that land. I'll drop this patch
from the next posting.

Steve

WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Andrew Jones <drjones@redhat.com>, Haibo Xu <Haibo.Xu@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	qemu-devel@nongnu.org, Marc Zyngier <maz@kernel.org>,
	Juan Quintela <quintela@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	linux-kernel@vger.kernel.org, Dave Martin <Dave.Martin@arm.com>,
	James Morse <james.morse@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu,
	Julien Thierry <julien.thierry.kdev@gmail.com>
Subject: Re: [PATCH v14 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage()
Date: Wed, 9 Jun 2021 09:56:43 +0100	[thread overview]
Message-ID: <7a3f14de-211b-94f9-6886-393d233193d5@arm.com> (raw)
In-Reply-To: <20210607170714.GA17957@arm.com>

On 07/06/2021 18:07, Catalin Marinas wrote:
> On Mon, Jun 07, 2021 at 12:08:10PM +0100, Steven Price wrote:
>> From: Catalin Marinas <catalin.marinas@arm.com>
>>
>> Currently, on an anonymous page fault, the kernel allocates a zeroed
>> page and maps it in user space. If the mapping is tagged (PROT_MTE),
>> set_pte_at() additionally clears the tags under a spinlock to avoid a
>> race on the page->flags. In order to optimise the lock, clear the page
>> tags on allocation in __alloc_zeroed_user_highpage() if the vma flags
>> have VM_MTE set.
>>
>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>> Signed-off-by: Steven Price <steven.price@arm.com>
> 
> I think you can drop this patch now that Peter's series has been queued
> via the arm64 tree:
> 
> https://lore.kernel.org/r/20210602235230.3928842-4-pcc@google.com
> 

Thanks for the heads up - I hadn't seen that land. I'll drop this patch
from the next posting.

Steve


WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	qemu-devel@nongnu.org, Marc Zyngier <maz@kernel.org>,
	Juan Quintela <quintela@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	linux-kernel@vger.kernel.org, Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Will Deacon <will@kernel.org>,
	kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v14 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage()
Date: Wed, 9 Jun 2021 09:56:43 +0100	[thread overview]
Message-ID: <7a3f14de-211b-94f9-6886-393d233193d5@arm.com> (raw)
In-Reply-To: <20210607170714.GA17957@arm.com>

On 07/06/2021 18:07, Catalin Marinas wrote:
> On Mon, Jun 07, 2021 at 12:08:10PM +0100, Steven Price wrote:
>> From: Catalin Marinas <catalin.marinas@arm.com>
>>
>> Currently, on an anonymous page fault, the kernel allocates a zeroed
>> page and maps it in user space. If the mapping is tagged (PROT_MTE),
>> set_pte_at() additionally clears the tags under a spinlock to avoid a
>> race on the page->flags. In order to optimise the lock, clear the page
>> tags on allocation in __alloc_zeroed_user_highpage() if the vma flags
>> have VM_MTE set.
>>
>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>> Signed-off-by: Steven Price <steven.price@arm.com>
> 
> I think you can drop this patch now that Peter's series has been queued
> via the arm64 tree:
> 
> https://lore.kernel.org/r/20210602235230.3928842-4-pcc@google.com
> 

Thanks for the heads up - I hadn't seen that land. I'll drop this patch
from the next posting.

Steve
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

WARNING: multiple messages have this Message-ID (diff)
From: Steven Price <steven.price@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
	James Morse <james.morse@arm.com>,
	Julien Thierry <julien.thierry.kdev@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	kvmarm@lists.cs.columbia.edu,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Dave Martin <Dave.Martin@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Peter Maydell <peter.maydell@linaro.org>,
	Haibo Xu <Haibo.Xu@arm.com>, Andrew Jones <drjones@redhat.com>
Subject: Re: [PATCH v14 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage()
Date: Wed, 9 Jun 2021 09:56:43 +0100	[thread overview]
Message-ID: <7a3f14de-211b-94f9-6886-393d233193d5@arm.com> (raw)
In-Reply-To: <20210607170714.GA17957@arm.com>

On 07/06/2021 18:07, Catalin Marinas wrote:
> On Mon, Jun 07, 2021 at 12:08:10PM +0100, Steven Price wrote:
>> From: Catalin Marinas <catalin.marinas@arm.com>
>>
>> Currently, on an anonymous page fault, the kernel allocates a zeroed
>> page and maps it in user space. If the mapping is tagged (PROT_MTE),
>> set_pte_at() additionally clears the tags under a spinlock to avoid a
>> race on the page->flags. In order to optimise the lock, clear the page
>> tags on allocation in __alloc_zeroed_user_highpage() if the vma flags
>> have VM_MTE set.
>>
>> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
>> Signed-off-by: Steven Price <steven.price@arm.com>
> 
> I think you can drop this patch now that Peter's series has been queued
> via the arm64 tree:
> 
> https://lore.kernel.org/r/20210602235230.3928842-4-pcc@google.com
> 

Thanks for the heads up - I hadn't seen that land. I'll drop this patch
from the next posting.

Steve

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-09  8:56 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07 11:08 [PATCH v14 0/8] MTE support for KVM guest Steven Price
2021-06-07 11:08 ` Steven Price
2021-06-07 11:08 ` Steven Price
2021-06-07 11:08 ` Steven Price
2021-06-07 11:08 ` [PATCH v14 1/8] arm64: mte: Handle race when synchronising tags Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-09 10:30   ` Marc Zyngier
2021-06-09 10:30     ` Marc Zyngier
2021-06-09 10:30     ` Marc Zyngier
2021-06-09 10:30     ` Marc Zyngier
2021-06-09 10:51     ` Steven Price
2021-06-09 10:51       ` Steven Price
2021-06-09 10:51       ` Steven Price
2021-06-09 10:51       ` Steven Price
2021-06-09 11:19       ` Marc Zyngier
2021-06-09 11:19         ` Marc Zyngier
2021-06-09 11:19         ` Marc Zyngier
2021-06-09 11:19         ` Marc Zyngier
2021-06-09 17:41         ` Catalin Marinas
2021-06-09 17:41           ` Catalin Marinas
2021-06-09 17:41           ` Catalin Marinas
2021-06-09 17:41           ` Catalin Marinas
2021-06-10  8:05           ` Steven Price
2021-06-10  8:05             ` Steven Price
2021-06-10  8:05             ` Steven Price
2021-06-10  8:05             ` Steven Price
2021-06-10 14:07             ` Catalin Marinas
2021-06-10 14:07               ` Catalin Marinas
2021-06-10 14:07               ` Catalin Marinas
2021-06-10 14:07               ` Catalin Marinas
2021-06-07 11:08 ` [PATCH v14 2/8] arm64: Handle MTE tags zeroing in __alloc_zeroed_user_highpage() Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 17:07   ` Catalin Marinas
2021-06-07 17:07     ` Catalin Marinas
2021-06-07 17:07     ` Catalin Marinas
2021-06-07 17:07     ` Catalin Marinas
2021-06-09  8:56     ` Steven Price [this message]
2021-06-09  8:56       ` Steven Price
2021-06-09  8:56       ` Steven Price
2021-06-09  8:56       ` Steven Price
2021-06-07 11:08 ` [PATCH v14 3/8] arm64: mte: Sync tags for pages where PTE is untagged Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08 ` [PATCH v14 4/8] KVM: arm64: Introduce MTE VM feature Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08 ` [PATCH v14 5/8] KVM: arm64: Save/restore MTE registers Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08 ` [PATCH v14 6/8] KVM: arm64: Expose KVM_ARM_CAP_MTE Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08 ` [PATCH v14 7/8] KVM: arm64: ioctl to fetch/store tags in a guest Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 17:21   ` Catalin Marinas
2021-06-07 17:21     ` Catalin Marinas
2021-06-07 17:21     ` Catalin Marinas
2021-06-07 17:21     ` Catalin Marinas
2021-06-07 11:08 ` [PATCH v14 8/8] KVM: arm64: Document MTE capability and ioctl Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 11:08   ` Steven Price
2021-06-07 17:32   ` Catalin Marinas
2021-06-07 17:32     ` Catalin Marinas
2021-06-07 17:32     ` Catalin Marinas
2021-06-07 17:32     ` Catalin Marinas
2021-06-09  8:56     ` Steven Price
2021-06-09  8:56       ` Steven Price
2021-06-09  8:56       ` Steven Price
2021-06-09  8:56       ` Steven Price

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a3f14de-211b-94f9-6886-393d233193d5@arm.com \
    --to=steven.price@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=Haibo.Xu@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dgilbert@redhat.com \
    --cc=drjones@redhat.com \
    --cc=james.morse@arm.com \
    --cc=julien.thierry.kdev@gmail.com \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.