From: Paolo Bonzini <pbonzini@redhat.com> To: Sasha Levin <sashal@kernel.org> Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Mike Christie <michael.christie@oracle.com>, Jason Wang <jasowang@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper Date: Sun, 29 Nov 2020 18:34:01 +0100 [thread overview] Message-ID: <7a4c3d84-8ff7-abd9-7340-3a6d7c65cfa7@redhat.com> (raw) In-Reply-To: <20201129041314.GO643756@sasha-vm> On 29/11/20 05:13, Sasha Levin wrote: >> Which doesn't seem to be suitable for stable either... Patch 3/5 in > > Why not? It was sent as a fix to Linus. Dunno, 120 lines of new code? Even if it's okay for an rc, I don't see why it is would be backported to stable releases and release it without any kind of testing. Maybe for 5.9 the chances of breaking things are low, but stuff like locking rules might have changed since older releases like 5.4 or 4.19. The autoselection bot does not know that, it basically crosses fingers that these larger-scale changes cause the patches not to apply or compile anymore. Maybe it's just me, but the whole "autoselect stable patches" and release them is very suspicious. You are basically crossing fingers and are ready to release any kind of untested crap, because you do not trust maintainers of marking stable patches right. Only then, when a backport is broken, it's maintainers who get the blame and have to fix it. Personally I don't care because I have asked you to opt KVM out of autoselection, but this is the opposite of what Greg brags about when he touts the virtues of the upstream stable process over vendor kernels. Paolo >> the series might be (vhost scsi: fix cmd completion race), so I can >> understand including 1/5 and 2/5 just in case, but not the rest. Does >> the bot not understand diffstats? > > Not on their own, no. What's wrong with the diffstats? >
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: Sasha Levin <sashal@kernel.org> Cc: kvm@vger.kernel.org, "Michael S . Tsirkin" <mst@redhat.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, virtualization@lists.linux-foundation.org, Stefan Hajnoczi <stefanha@redhat.com>, Mike Christie <michael.christie@oracle.com> Subject: Re: [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper Date: Sun, 29 Nov 2020 18:34:01 +0100 [thread overview] Message-ID: <7a4c3d84-8ff7-abd9-7340-3a6d7c65cfa7@redhat.com> (raw) In-Reply-To: <20201129041314.GO643756@sasha-vm> On 29/11/20 05:13, Sasha Levin wrote: >> Which doesn't seem to be suitable for stable either... Patch 3/5 in > > Why not? It was sent as a fix to Linus. Dunno, 120 lines of new code? Even if it's okay for an rc, I don't see why it is would be backported to stable releases and release it without any kind of testing. Maybe for 5.9 the chances of breaking things are low, but stuff like locking rules might have changed since older releases like 5.4 or 4.19. The autoselection bot does not know that, it basically crosses fingers that these larger-scale changes cause the patches not to apply or compile anymore. Maybe it's just me, but the whole "autoselect stable patches" and release them is very suspicious. You are basically crossing fingers and are ready to release any kind of untested crap, because you do not trust maintainers of marking stable patches right. Only then, when a backport is broken, it's maintainers who get the blame and have to fix it. Personally I don't care because I have asked you to opt KVM out of autoselection, but this is the opposite of what Greg brags about when he touts the virtues of the upstream stable process over vendor kernels. Paolo >> the series might be (vhost scsi: fix cmd completion race), so I can >> understand including 1/5 and 2/5 just in case, but not the rest. Does >> the bot not understand diffstats? > > Not on their own, no. What's wrong with the diffstats? > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-11-29 17:35 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-25 15:35 [PATCH AUTOSEL 5.9 01/33] HID: uclogic: Add ID for Trust Flex Design Tablet Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 02/33] HID: ite: Replace ABS_MISC 120/121 events with touchpad on/off keypresses Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 03/33] HID: cypress: Support Varmilo Keyboards' media hotkeys Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 04/33] HID: add support for Sega Saturn Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 05/33] Input: i8042 - allow insmod to succeed on devices without an i8042 controller Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 06/33] HID: hid-sensor-hub: Fix issue with devices with no report ID Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 07/33] staging: ralink-gdma: fix kconfig dependency bug for DMA_RALINK Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 08/33] HID: add HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE for Gamevice devices Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 09/33] dmaengine: xilinx_dma: use readl_poll_timeout_atomic variant Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 10/33] x86/xen: don't unbind uninitialized lock_kicker_irq Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 11/33] kunit: fix display of failed expectations for strings Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 12/33] HID: logitech-hidpp: Add HIDPP_CONSUMER_VENDOR_KEYS quirk for the Dinovo Edge Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 13/33] HID: Add Logitech Dinovo Edge battery quirk Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 14/33] proc: don't allow async path resolution of /proc/self components Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 15/33] nvme: free sq/cq dbbuf pointers when dbbuf set fails Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 16/33] io_uring: handle -EOPNOTSUPP on path resolution Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 17/33] net: stmmac: dwmac_lib: enlarge dma reset timeout Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 18/33] vdpasim: fix "mac_pton" undefined error Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 19/33] vhost: add helper to check if a vq has been setup Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 20/33] vhost scsi: alloc cmds per vq instead of session Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 21/33] vhost scsi: fix cmd completion race Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 22/33] vhost scsi: add lun parser helper Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 17:48 ` Paolo Bonzini 2020-11-25 17:48 ` Paolo Bonzini 2020-11-25 18:01 ` Sasha Levin 2020-11-25 18:01 ` Sasha Levin 2020-11-25 18:08 ` Paolo Bonzini 2020-11-25 18:08 ` Paolo Bonzini 2020-11-29 4:13 ` Sasha Levin 2020-11-29 4:13 ` Sasha Levin 2020-11-29 17:34 ` Paolo Bonzini [this message] 2020-11-29 17:34 ` Paolo Bonzini 2020-11-29 21:06 ` Sasha Levin 2020-11-29 21:06 ` Sasha Levin 2020-11-30 8:33 ` Paolo Bonzini 2020-11-30 8:33 ` Paolo Bonzini 2020-11-30 13:28 ` Greg KH 2020-11-30 13:28 ` Greg KH 2020-11-30 13:52 ` Paolo Bonzini 2020-11-30 13:52 ` Paolo Bonzini 2020-11-30 13:57 ` Greg KH 2020-11-30 13:57 ` Greg KH 2020-11-30 14:00 ` Paolo Bonzini 2020-11-30 14:00 ` Paolo Bonzini 2020-11-30 17:34 ` Sasha Levin 2020-11-30 17:34 ` Sasha Levin 2020-11-30 17:38 ` Sasha Levin 2020-11-30 17:38 ` Sasha Levin 2020-11-30 17:52 ` Paolo Bonzini 2020-11-30 17:52 ` Paolo Bonzini 2020-11-30 19:44 ` Mike Christie 2020-11-30 20:29 ` Paolo Bonzini 2020-11-30 20:29 ` Paolo Bonzini 2020-11-30 23:59 ` Sasha Levin 2020-11-30 23:59 ` Sasha Levin 2020-12-04 8:27 ` Paolo Bonzini 2020-12-04 8:27 ` Paolo Bonzini 2020-12-04 15:49 ` Sasha Levin 2020-12-04 15:49 ` Sasha Levin 2020-12-04 16:12 ` Joe Perches 2020-12-04 16:12 ` Joe Perches 2020-12-04 17:08 ` Paolo Bonzini 2020-12-04 17:08 ` Paolo Bonzini 2020-12-05 20:59 ` Sasha Levin 2020-12-05 20:59 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 23/33] vhost scsi: Add support for LUN resets Sasha Levin 2020-11-25 15:35 ` Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 24/33] cpuidle: tegra: Annotate tegra_pm_set_cpu_in_lp2() with RCU_NONIDLE Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 25/33] dmaengine: pl330: _prep_dma_memcpy: Fix wrong burst size Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 26/33] scsi: libiscsi: Fix NOP race condition Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 27/33] scsi: target: iscsi: Fix cmd abort fabric stop race Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 28/33] lockdep: Put graph lock/unlock under lock_recursion protection Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 29/33] perf/x86: fix sysfs type mismatches Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 30/33] xtensa: uaccess: Add missing __user to strncpy_from_user() prototype Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 31/33] x86/dumpstack: Do not try to access user space code of other tasks Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 32/33] net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset Sasha Levin 2020-11-25 15:35 ` [PATCH AUTOSEL 5.9 33/33] xfs: don't allow NOWAIT DIO across extent boundaries Sasha Levin 2020-11-25 21:52 ` Dave Chinner 2020-11-25 23:46 ` Sasha Levin 2020-11-26 7:13 ` Dave Chinner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7a4c3d84-8ff7-abd9-7340-3a6d7c65cfa7@redhat.com \ --to=pbonzini@redhat.com \ --cc=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=michael.christie@oracle.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=sashal@kernel.org \ --cc=stable@vger.kernel.org \ --cc=stefanha@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.