* [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
@ 2023-07-24 6:35 Alexander Stein
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
` (3 more replies)
0 siblings, 4 replies; 16+ messages in thread
From: Alexander Stein @ 2023-07-24 6:35 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones
Cc: Alexander Stein, linux-gpio, devicetree, linux-arm-kernel,
linux-leds, linux-stm32
This is a gpio-controller, so gpio-line-names should be allowed as well.
stmpe2403 supports up to 24 GPIOs.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Add min/maxItems
Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
index 22c0cae73425..4555f1644a4d 100644
--- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
@@ -28,6 +28,10 @@ properties:
gpio-controller: true
+ gpio-line-names:
+ minItems: 1
+ maxItems: 24
+
interrupt-controller: true
st,norequest-mask:
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
2023-07-24 6:35 [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Alexander Stein
@ 2023-07-24 6:35 ` Alexander Stein
2023-07-24 7:24 ` Krzysztof Kozlowski
` (3 more replies)
2023-07-24 7:23 ` [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 4 replies; 16+ messages in thread
From: Alexander Stein @ 2023-07-24 6:35 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones
Cc: Alexander Stein, linux-gpio, devicetree, linux-arm-kernel,
linux-leds, linux-stm32
This is a gpio-controller, so gpio-line-names should be allowed as well.
pca9532 supports up to 16 GPIOs.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Changes in v2:
* Add min/maxItems
Documentation/devicetree/bindings/leds/nxp,pca953x.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
index edf6f55df685..9610bca57dd5 100644
--- a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
+++ b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
@@ -29,6 +29,10 @@ properties:
gpio-controller: true
+ gpio-line-names:
+ minItems: 1
+ maxItems: 16
+
'#gpio-cells':
const: 2
--
2.34.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 6:35 [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Alexander Stein
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
@ 2023-07-24 7:23 ` Krzysztof Kozlowski
2023-07-24 7:58 ` Alexander Stein
2023-07-24 13:35 ` Krzysztof Kozlowski
2023-07-29 14:00 ` Bartosz Golaszewski
3 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 7:23 UTC (permalink / raw)
To: Alexander Stein, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Maxime Coquelin, Alexandre Torgue, Pavel Machek, Lee Jones
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On 24/07/2023 08:35, Alexander Stein wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> stmpe2403 supports up to 24 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Add min/maxItems
>
> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> index 22c0cae73425..4555f1644a4d 100644
> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> @@ -28,6 +28,10 @@ properties:
>
> gpio-controller: true
>
> + gpio-line-names:
> + minItems: 1
> + maxItems: 24
> +
I am sure there is no variant with one GPIO.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
@ 2023-07-24 7:24 ` Krzysztof Kozlowski
2023-07-24 13:36 ` Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 7:24 UTC (permalink / raw)
To: Alexander Stein, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Maxime Coquelin, Alexandre Torgue, Pavel Machek, Lee Jones
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On 24/07/2023 08:35, Alexander Stein wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> pca9532 supports up to 16 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Add min/maxItems
>
> Documentation/devicetree/bindings/leds/nxp,pca953x.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
> index edf6f55df685..9610bca57dd5 100644
> --- a/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
> +++ b/Documentation/devicetree/bindings/leds/nxp,pca953x.yaml
> @@ -29,6 +29,10 @@ properties:
>
> gpio-controller: true
>
> + gpio-line-names:
> + minItems: 1
GPIO expander which adds only one GPIO? That would be weird. Are sure?
Which model supports 1 GPIO?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 7:23 ` [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Krzysztof Kozlowski
@ 2023-07-24 7:58 ` Alexander Stein
2023-07-24 9:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Alexander Stein @ 2023-07-24 7:58 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones, Krzysztof Kozlowski
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
Hi,
Am Montag, 24. Juli 2023, 09:23:09 CEST schrieb Krzysztof Kozlowski:
> On 24/07/2023 08:35, Alexander Stein wrote:
> > This is a gpio-controller, so gpio-line-names should be allowed as well.
> > stmpe2403 supports up to 24 GPIOs.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Changes in v2:
> > * Add min/maxItems
> >
> > Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> > b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index
> > 22c0cae73425..4555f1644a4d 100644
> > --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> >
> > @@ -28,6 +28,10 @@ properties:
> > gpio-controller: true
> >
> > + gpio-line-names:
> > + minItems: 1
> > + maxItems: 24
> > +
>
> I am sure there is no variant with one GPIO.
That's true. But if only one GPIO is actually connected there is no use
enforcing to add empty entries.
AFAIK it is also allowed to provide an incomplete array.
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 7:58 ` Alexander Stein
@ 2023-07-24 9:54 ` Krzysztof Kozlowski
2023-07-24 11:44 ` Alexander Stein
0 siblings, 1 reply; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 9:54 UTC (permalink / raw)
To: Alexander Stein, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Maxime Coquelin, Alexandre Torgue, Pavel Machek, Lee Jones
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On 24/07/2023 09:58, Alexander Stein wrote:
> Hi,
>
> Am Montag, 24. Juli 2023, 09:23:09 CEST schrieb Krzysztof Kozlowski:
>> On 24/07/2023 08:35, Alexander Stein wrote:
>>> This is a gpio-controller, so gpio-line-names should be allowed as well.
>>> stmpe2403 supports up to 24 GPIOs.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>> Changes in v2:
>>> * Add min/maxItems
>>>
>>> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>> b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index
>>> 22c0cae73425..4555f1644a4d 100644
>>> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>>
>>> @@ -28,6 +28,10 @@ properties:
>>> gpio-controller: true
>>>
>>> + gpio-line-names:
>>> + minItems: 1
>>> + maxItems: 24
>>> +
>>
>> I am sure there is no variant with one GPIO.
>
> That's true. But if only one GPIO is actually connected there is no use
> enforcing to add empty entries.
> AFAIK it is also allowed to provide an incomplete array.
Did you test it? Linux prints warning. Warning means "not allowed".
The expectation is that the rest are named "NC".
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 9:54 ` Krzysztof Kozlowski
@ 2023-07-24 11:44 ` Alexander Stein
2023-07-24 13:35 ` Krzysztof Kozlowski
0 siblings, 1 reply; 16+ messages in thread
From: Alexander Stein @ 2023-07-24 11:44 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones, Krzysztof Kozlowski
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
Am Montag, 24. Juli 2023, 11:54:12 CEST schrieb Krzysztof Kozlowski:
> On 24/07/2023 09:58, Alexander Stein wrote:
> > Hi,
> >
> > Am Montag, 24. Juli 2023, 09:23:09 CEST schrieb Krzysztof Kozlowski:
> >> On 24/07/2023 08:35, Alexander Stein wrote:
> >>> This is a gpio-controller, so gpio-line-names should be allowed as well.
> >>> stmpe2403 supports up to 24 GPIOs.
> >>>
> >>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> >>> ---
> >>> Changes in v2:
> >>> * Add min/maxItems
> >>>
> >>> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
> >>> 1 file changed, 4 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> >>> b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index
> >>> 22c0cae73425..4555f1644a4d 100644
> >>> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> >>> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> >>>
> >>> @@ -28,6 +28,10 @@ properties:
> >>> gpio-controller: true
> >>>
> >>> + gpio-line-names:
> >>> + minItems: 1
> >>> + maxItems: 24
> >>> +
> >>
> >> I am sure there is no variant with one GPIO.
> >
> > That's true. But if only one GPIO is actually connected there is no use
> > enforcing to add empty entries.
> > AFAIK it is also allowed to provide an incomplete array.
>
> Did you test it? Linux prints warning. Warning means "not allowed".
I did and I don't see any warnings.
I using the following (modified) GPIO subnode on an stmpe811 chip:
gpio {
compatible = "st,stmpe-gpio";
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
#interrupt-cells = <2>;
/* GPIO 5-7 used for touch */
st,norequest-mask = <0xf0>;
gpio-line-names = "GPIO_ADC_I2C1_1";
};
I only see the warning "stmpe-gpio stmpe-gpio: DMA mask not set", but that's a
different matter.
Only GPIO 0-3 are connected. Original property is
gpio-line-names = "GPIO_ADC_I2C1_1",
"GPIO_ADC_I2C1_2",
"GPIO_ADC_I2C1_3",
"GPIO_ADC_I2C1_4";
Also gpioinfo shows that the gpiochip has 8 pins while only the first one is
named.
gpiochip7 - 8 lines:
line 0: "GPIO_ADC_I2C1_1" unused input active-high
line 1: unnamed unused input active-high
line 2: unnamed unused input active-high
line 3: unnamed unused input active-high
line 4: unnamed unused input active-high
line 5: unnamed unused input active-high
line 6: unnamed unused input active-high
line 7: unnamed unused input active-high
If 4 GPIOs are named the output shows names for lines 1-3 accordingly, but no
errors/warnings as well.
> The expectation is that the rest are named "NC".
Where does this expectation come from? Is there any pending change I am not
aware of?
Best regards,
Alexander
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 11:44 ` Alexander Stein
@ 2023-07-24 13:35 ` Krzysztof Kozlowski
0 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 13:35 UTC (permalink / raw)
To: Alexander Stein, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Maxime Coquelin, Alexandre Torgue, Pavel Machek, Lee Jones
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On 24/07/2023 13:44, Alexander Stein wrote:
>>>>> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
>>>>> 1 file changed, 4 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>>>> b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml index
>>>>> 22c0cae73425..4555f1644a4d 100644
>>>>> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>>>> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
>>>>>
>>>>> @@ -28,6 +28,10 @@ properties:
>>>>> gpio-controller: true
>>>>>
>>>>> + gpio-line-names:
>>>>> + minItems: 1
>>>>> + maxItems: 24
>>>>> +
>>>>
>>>> I am sure there is no variant with one GPIO.
>>>
>>> That's true. But if only one GPIO is actually connected there is no use
>>> enforcing to add empty entries.
>>> AFAIK it is also allowed to provide an incomplete array.
>>
>> Did you test it? Linux prints warning. Warning means "not allowed".
>
> I did and I don't see any warnings.
> I using the following (modified) GPIO subnode on an stmpe811 chip:
> gpio {
> compatible = "st,stmpe-gpio";
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> #interrupt-cells = <2>;
> /* GPIO 5-7 used for touch */
> st,norequest-mask = <0xf0>;
> gpio-line-names = "GPIO_ADC_I2C1_1";
> };
>
> I only see the warning "stmpe-gpio stmpe-gpio: DMA mask not set", but that's a
> different matter.
> Only GPIO 0-3 are connected. Original property is
> gpio-line-names = "GPIO_ADC_I2C1_1",
> "GPIO_ADC_I2C1_2",
> "GPIO_ADC_I2C1_3",
> "GPIO_ADC_I2C1_4";
>
> Also gpioinfo shows that the gpiochip has 8 pins while only the first one is
> named.
>
> gpiochip7 - 8 lines:
> line 0: "GPIO_ADC_I2C1_1" unused input active-high
> line 1: unnamed unused input active-high
> line 2: unnamed unused input active-high
> line 3: unnamed unused input active-high
> line 4: unnamed unused input active-high
> line 5: unnamed unused input active-high
> line 6: unnamed unused input active-high
> line 7: unnamed unused input active-high
>
>
> If 4 GPIOs are named the output shows names for lines 1-3 accordingly, but no
> errors/warnings as well.
>
>> The expectation is that the rest are named "NC".
>
> Where does this expectation come from? Is there any pending change I am not
> aware of?
>
Hm, indeed, I mistaken the case for multiple gpio chips in one device
(so having an offset). Bindings are actually explicitly allowing array
for only some GPIOs.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 6:35 [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Alexander Stein
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
2023-07-24 7:23 ` [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Krzysztof Kozlowski
@ 2023-07-24 13:35 ` Krzysztof Kozlowski
2023-07-29 14:00 ` Bartosz Golaszewski
3 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 13:35 UTC (permalink / raw)
To: Alexander Stein, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Maxime Coquelin, Alexandre Torgue, Pavel Machek, Lee Jones
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On 24/07/2023 08:35, Alexander Stein wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> stmpe2403 supports up to 24 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
2023-07-24 7:24 ` Krzysztof Kozlowski
@ 2023-07-24 13:36 ` Krzysztof Kozlowski
2023-08-07 8:56 ` Linus Walleij
2023-08-17 11:49 ` Lee Jones
3 siblings, 0 replies; 16+ messages in thread
From: Krzysztof Kozlowski @ 2023-07-24 13:36 UTC (permalink / raw)
To: Alexander Stein, Linus Walleij, Bartosz Golaszewski,
Andy Shevchenko, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Maxime Coquelin, Alexandre Torgue, Pavel Machek, Lee Jones
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On 24/07/2023 08:35, Alexander Stein wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> pca9532 supports up to 16 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
2023-07-24 6:35 [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Alexander Stein
@ 2023-07-29 14:00 ` Bartosz Golaszewski
2023-07-24 7:23 ` [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 16+ messages in thread
From: Bartosz Golaszewski @ 2023-07-29 14:00 UTC (permalink / raw)
To: Alexander Stein
Cc: Linus Walleij, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Coquelin, Alexandre Torgue, Pavel Machek,
Lee Jones, linux-gpio, devicetree, linux-arm-kernel, linux-leds,
linux-stm32
On Mon, Jul 24, 2023 at 8:35 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> stmpe2403 supports up to 24 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Add min/maxItems
>
> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> index 22c0cae73425..4555f1644a4d 100644
> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> @@ -28,6 +28,10 @@ properties:
>
> gpio-controller: true
>
> + gpio-line-names:
> + minItems: 1
> + maxItems: 24
> +
> interrupt-controller: true
>
> st,norequest-mask:
> --
> 2.34.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO
@ 2023-07-29 14:00 ` Bartosz Golaszewski
0 siblings, 0 replies; 16+ messages in thread
From: Bartosz Golaszewski @ 2023-07-29 14:00 UTC (permalink / raw)
To: Alexander Stein
Cc: Linus Walleij, Andy Shevchenko, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Coquelin, Alexandre Torgue, Pavel Machek,
Lee Jones, linux-gpio, devicetree, linux-arm-kernel, linux-leds,
linux-stm32
On Mon, Jul 24, 2023 at 8:35 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> stmpe2403 supports up to 24 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Changes in v2:
> * Add min/maxItems
>
> Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> index 22c0cae73425..4555f1644a4d 100644
> --- a/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/st,stmpe-gpio.yaml
> @@ -28,6 +28,10 @@ properties:
>
> gpio-controller: true
>
> + gpio-line-names:
> + minItems: 1
> + maxItems: 24
> +
> interrupt-controller: true
>
> st,norequest-mask:
> --
> 2.34.1
>
Applied, thanks!
Bart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
@ 2023-08-07 8:56 ` Linus Walleij
2023-07-24 13:36 ` Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2023-08-07 8:56 UTC (permalink / raw)
To: Alexander Stein
Cc: Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones, linux-gpio,
devicetree, linux-arm-kernel, linux-leds, linux-stm32
On Mon, Jul 24, 2023 at 8:35 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> pca9532 supports up to 16 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
@ 2023-08-07 8:56 ` Linus Walleij
0 siblings, 0 replies; 16+ messages in thread
From: Linus Walleij @ 2023-08-07 8:56 UTC (permalink / raw)
To: Alexander Stein
Cc: Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones, linux-gpio,
devicetree, linux-arm-kernel, linux-leds, linux-stm32
On Mon, Jul 24, 2023 at 8:35 AM Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> pca9532 supports up to 16 GPIOs.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
@ 2023-08-17 11:49 ` Lee Jones
2023-07-24 13:36 ` Krzysztof Kozlowski
` (2 subsequent siblings)
3 siblings, 0 replies; 16+ messages in thread
From: Lee Jones @ 2023-08-17 11:49 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones, Alexander Stein
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On Mon, 24 Jul 2023 08:35:20 +0200, Alexander Stein wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> pca9532 supports up to 16 GPIOs.
>
>
Applied, thanks!
[2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
commit: 4aa8f7e24f07669d27945149a72903bc032fa6e9
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: (subset) [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
@ 2023-08-17 11:49 ` Lee Jones
0 siblings, 0 replies; 16+ messages in thread
From: Lee Jones @ 2023-08-17 11:49 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Coquelin,
Alexandre Torgue, Pavel Machek, Lee Jones, Alexander Stein
Cc: linux-gpio, devicetree, linux-arm-kernel, linux-leds, linux-stm32
On Mon, 24 Jul 2023 08:35:20 +0200, Alexander Stein wrote:
> This is a gpio-controller, so gpio-line-names should be allowed as well.
> pca9532 supports up to 16 GPIOs.
>
>
Applied, thanks!
[2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO
commit: 4aa8f7e24f07669d27945149a72903bc032fa6e9
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2023-08-17 11:50 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-24 6:35 [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Alexander Stein
2023-07-24 6:35 ` [PATCH v2 2/2] dt-bindings: leds: Add gpio-line-names to PCA9532 GPIO Alexander Stein
2023-07-24 7:24 ` Krzysztof Kozlowski
2023-07-24 13:36 ` Krzysztof Kozlowski
2023-08-07 8:56 ` Linus Walleij
2023-08-07 8:56 ` Linus Walleij
2023-08-17 11:49 ` (subset) " Lee Jones
2023-08-17 11:49 ` Lee Jones
2023-07-24 7:23 ` [PATCH v2 1/2] dt-bindings: gpio: Add gpio-line-names to STMPE GPIO Krzysztof Kozlowski
2023-07-24 7:58 ` Alexander Stein
2023-07-24 9:54 ` Krzysztof Kozlowski
2023-07-24 11:44 ` Alexander Stein
2023-07-24 13:35 ` Krzysztof Kozlowski
2023-07-24 13:35 ` Krzysztof Kozlowski
2023-07-29 14:00 ` Bartosz Golaszewski
2023-07-29 14:00 ` Bartosz Golaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.