All of lore.kernel.org
 help / color / mirror / Atom feed
* Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168
@ 2019-11-02 14:36 Thomas Deutschmann
  2019-11-02 17:52 ` Luciano Coelho
  2019-11-04 11:00 ` Greg KH
  0 siblings, 2 replies; 5+ messages in thread
From: Thomas Deutschmann @ 2019-11-02 14:36 UTC (permalink / raw)
  To: stable; +Cc: luciano.coelho

Hi,

please backport

<<<<snip
From 12e36d98d3e5acf5fc57774e0a15906d55f30cb9 Mon Sep 17 00:00:00 2001
From: Luca Coelho <luciano.coelho@intel.com>
Date: Tue, 8 Oct 2019 13:10:53 +0300
Subject: iwlwifi: exclude GEO SAR support for 3168

We currently support two NICs in FW version 29, namely 7265D and 3168.
Out of these, only 7265D supports GEO SAR, so adjust the function that
checks for it accordingly.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Fixes: f5a47fae6aa3 ("iwlwifi: mvm: fix version check for
GEO_TX_POWER_LIMIT support")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
snap>>>

This was the first patch of a 2 patch patch series. The second patch,
aa0cc7dde17 ("iwlwifi: pcie: change qu with jf devices to use qu
configuration") had "Cc: stable@vger.kernel.org # 5.1+" and was added.
The first one was missed.


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168
  2019-11-02 14:36 Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168 Thomas Deutschmann
@ 2019-11-02 17:52 ` Luciano Coelho
  2019-11-02 19:05   ` Thomas Backlund
  2019-11-04 11:00 ` Greg KH
  1 sibling, 1 reply; 5+ messages in thread
From: Luciano Coelho @ 2019-11-02 17:52 UTC (permalink / raw)
  To: Thomas Deutschmann, stable

Hi Thomas,

On Sat, 2019-11-02 at 15:36 +0100, Thomas Deutschmann wrote:
> Hi,
> 
> please backport
> 
> <<<<snip
> From 12e36d98d3e5acf5fc57774e0a15906d55f30cb9 Mon Sep 17 00:00:00 2001
> From: Luca Coelho <luciano.coelho@intel.com>
> Date: Tue, 8 Oct 2019 13:10:53 +0300
> Subject: iwlwifi: exclude GEO SAR support for 3168
> 
> We currently support two NICs in FW version 29, namely 7265D and 3168.
> Out of these, only 7265D supports GEO SAR, so adjust the function that
> checks for it accordingly.
> 
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Fixes: f5a47fae6aa3 ("iwlwifi: mvm: fix version check for
> GEO_TX_POWER_LIMIT support")
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> snap>>>
> 
> This was the first patch of a 2 patch patch series. The second patch,
> aa0cc7dde17 ("iwlwifi: pcie: change qu with jf devices to use qu
> configuration") had "Cc: stable@vger.kernel.org # 5.1+" and was added.
> The first one was missed.

I sent this earlier for stable v5.1, but it's EOL already, so it won't
be merged there anymore.

--
Cheers,
Luca.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168
  2019-11-02 17:52 ` Luciano Coelho
@ 2019-11-02 19:05   ` Thomas Backlund
  2019-11-03 11:56     ` Sasha Levin
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Backlund @ 2019-11-02 19:05 UTC (permalink / raw)
  To: Luciano Coelho, Thomas Deutschmann, stable

Den 02-11-2019 kl. 19:52, skrev Luciano Coelho:
> Hi Thomas,
> 
> On Sat, 2019-11-02 at 15:36 +0100, Thomas Deutschmann wrote:
>> Hi,
>>
>> please backport
>>
>> <<<<snip
>>  From 12e36d98d3e5acf5fc57774e0a15906d55f30cb9 Mon Sep 17 00:00:00 2001
>> From: Luca Coelho <luciano.coelho@intel.com>
>> Date: Tue, 8 Oct 2019 13:10:53 +0300
>> Subject: iwlwifi: exclude GEO SAR support for 3168
>>
>> We currently support two NICs in FW version 29, namely 7265D and 3168.
>> Out of these, only 7265D supports GEO SAR, so adjust the function that
>> checks for it accordingly.
>>
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> Fixes: f5a47fae6aa3 ("iwlwifi: mvm: fix version check for
>> GEO_TX_POWER_LIMIT support")
>> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>> snap>>>
>>
>> This was the first patch of a 2 patch patch series. The second patch,
>> aa0cc7dde17 ("iwlwifi: pcie: change qu with jf devices to use qu
>> configuration") had "Cc: stable@vger.kernel.org # 5.1+" and was added.
>> The first one was missed.
> 
> I sent this earlier for stable v5.1, but it's EOL already, so it won't
> be merged there anymore.
> 


But it's still needed in the active 5.3 tree, and is already queued for 
4.19, and since 4.14 also loads api 29, it also needs it...

--
Thomas

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168
  2019-11-02 19:05   ` Thomas Backlund
@ 2019-11-03 11:56     ` Sasha Levin
  0 siblings, 0 replies; 5+ messages in thread
From: Sasha Levin @ 2019-11-03 11:56 UTC (permalink / raw)
  To: Thomas Backlund; +Cc: Luciano Coelho, Thomas Deutschmann, stable

On Sat, Nov 02, 2019 at 09:05:18PM +0200, Thomas Backlund wrote:
>Den 02-11-2019 kl. 19:52, skrev Luciano Coelho:
>>Hi Thomas,
>>
>>On Sat, 2019-11-02 at 15:36 +0100, Thomas Deutschmann wrote:
>>>Hi,
>>>
>>>please backport
>>>
>>><<<<snip
>>> From 12e36d98d3e5acf5fc57774e0a15906d55f30cb9 Mon Sep 17 00:00:00 2001
>>>From: Luca Coelho <luciano.coelho@intel.com>
>>>Date: Tue, 8 Oct 2019 13:10:53 +0300
>>>Subject: iwlwifi: exclude GEO SAR support for 3168
>>>
>>>We currently support two NICs in FW version 29, namely 7265D and 3168.
>>>Out of these, only 7265D supports GEO SAR, so adjust the function that
>>>checks for it accordingly.
>>>
>>>Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>>>Fixes: f5a47fae6aa3 ("iwlwifi: mvm: fix version check for
>>>GEO_TX_POWER_LIMIT support")
>>>Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
>>>snap>>>
>>>
>>>This was the first patch of a 2 patch patch series. The second patch,
>>>aa0cc7dde17 ("iwlwifi: pcie: change qu with jf devices to use qu
>>>configuration") had "Cc: stable@vger.kernel.org # 5.1+" and was added.
>>>The first one was missed.
>>
>>I sent this earlier for stable v5.1, but it's EOL already, so it won't
>>be merged there anymore.
>>
>
>
>But it's still needed in the active 5.3 tree, and is already queued 
>for 4.19, and since 4.14 also loads api 29, it also needs it...

Luca, does it mean we'd also need fddbfeece9c7 ("iwlwifi: fw: don't send
GEO_TX_POWER_LIMIT command to FW version 36") on 4.14? It says 4.19+ but
if I'm reading the code (and comments) right we need it on 4.14 too?

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168
  2019-11-02 14:36 Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168 Thomas Deutschmann
  2019-11-02 17:52 ` Luciano Coelho
@ 2019-11-04 11:00 ` Greg KH
  1 sibling, 0 replies; 5+ messages in thread
From: Greg KH @ 2019-11-04 11:00 UTC (permalink / raw)
  To: Thomas Deutschmann; +Cc: stable, luciano.coelho

On Sat, Nov 02, 2019 at 03:36:03PM +0100, Thomas Deutschmann wrote:
> Hi,
> 
> please backport
> 
> <<<<snip
> >From 12e36d98d3e5acf5fc57774e0a15906d55f30cb9 Mon Sep 17 00:00:00 2001
> From: Luca Coelho <luciano.coelho@intel.com>
> Date: Tue, 8 Oct 2019 13:10:53 +0300
> Subject: iwlwifi: exclude GEO SAR support for 3168
> 
> We currently support two NICs in FW version 29, namely 7265D and 3168.
> Out of these, only 7265D supports GEO SAR, so adjust the function that
> checks for it accordingly.
> 
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> Fixes: f5a47fae6aa3 ("iwlwifi: mvm: fix version check for
> GEO_TX_POWER_LIMIT support")
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> snap>>>
> 
> This was the first patch of a 2 patch patch series. The second patch,
> aa0cc7dde17 ("iwlwifi: pcie: change qu with jf devices to use qu
> configuration") had "Cc: stable@vger.kernel.org # 5.1+" and was added.
> The first one was missed.

Now queued up,t hanks.

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-11-04 11:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-02 14:36 Please backport 12e36d98d3e for 5.1+: iwlwifi: exclude GEO SAR support for 3168 Thomas Deutschmann
2019-11-02 17:52 ` Luciano Coelho
2019-11-02 19:05   ` Thomas Backlund
2019-11-03 11:56     ` Sasha Levin
2019-11-04 11:00 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.