* [PATCH] RDMA/rxe: Remove unused mask parameter
@ 2022-07-08 5:23 lizhijian
2022-07-14 16:32 ` Bob Pearson
0 siblings, 1 reply; 3+ messages in thread
From: lizhijian @ 2022-07-08 5:23 UTC (permalink / raw)
To: Yanjun Zhu, Jason Gunthorpe, linux-rdma; +Cc: lizhijian
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 69fc35485e60..35a249727435 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
u32 opcode);
static inline void retry_first_write_send(struct rxe_qp *qp,
- struct rxe_send_wqe *wqe,
- unsigned int mask, int npsn)
+ struct rxe_send_wqe *wqe, int npsn)
{
int i;
@@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
if (mask & WR_WRITE_OR_SEND_MASK) {
npsn = (qp->comp.psn - wqe->first_psn) &
BTH_PSN_MASK;
- retry_first_write_send(qp, wqe, mask, npsn);
+ retry_first_write_send(qp, wqe, npsn);
}
if (mask & WR_READ_MASK) {
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/rxe: Remove unused mask parameter
2022-07-08 5:23 [PATCH] RDMA/rxe: Remove unused mask parameter lizhijian
@ 2022-07-14 16:32 ` Bob Pearson
2022-07-15 3:42 ` lizhijian
0 siblings, 1 reply; 3+ messages in thread
From: Bob Pearson @ 2022-07-14 16:32 UTC (permalink / raw)
To: lizhijian, Yanjun Zhu, Jason Gunthorpe, linux-rdma
On 7/8/22 00:23, lizhijian@fujitsu.com wrote:
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 69fc35485e60..35a249727435 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
> u32 opcode);
>
> static inline void retry_first_write_send(struct rxe_qp *qp,
> - struct rxe_send_wqe *wqe,
> - unsigned int mask, int npsn)
> + struct rxe_send_wqe *wqe, int npsn)
> {
> int i;
>
> @@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
> if (mask & WR_WRITE_OR_SEND_MASK) {
> npsn = (qp->comp.psn - wqe->first_psn) &
> BTH_PSN_MASK;
> - retry_first_write_send(qp, wqe, mask, npsn);
> + retry_first_write_send(qp, wqe, npsn);
> }
>
> if (mask & WR_READ_MASK) {
This is correct but should have a body describing what you are doing and why.
A target branch would also help. E.g. [PATCH for-next].
Bob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/rxe: Remove unused mask parameter
2022-07-14 16:32 ` Bob Pearson
@ 2022-07-15 3:42 ` lizhijian
0 siblings, 0 replies; 3+ messages in thread
From: lizhijian @ 2022-07-15 3:42 UTC (permalink / raw)
To: Bob Pearson, Yanjun Zhu, Jason Gunthorpe, linux-rdma
On 15/07/2022 00:32, Bob Pearson wrote:
> On 7/8/22 00:23, lizhijian@fujitsu.com wrote:
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>> drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
>> index 69fc35485e60..35a249727435 100644
>> --- a/drivers/infiniband/sw/rxe/rxe_req.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
>> @@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
>> u32 opcode);
>>
>> static inline void retry_first_write_send(struct rxe_qp *qp,
>> - struct rxe_send_wqe *wqe,
>> - unsigned int mask, int npsn)
>> + struct rxe_send_wqe *wqe, int npsn)
>> {
>> int i;
>>
>> @@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
>> if (mask & WR_WRITE_OR_SEND_MASK) {
>> npsn = (qp->comp.psn - wqe->first_psn) &
>> BTH_PSN_MASK;
>> - retry_first_write_send(qp, wqe, mask, npsn);
>> + retry_first_write_send(qp, wqe, npsn);
>> }
>>
>> if (mask & WR_READ_MASK) {
> This is correct but should have a body describing what you are doing and why.
> A target branch would also help. E.g. [PATCH for-next].
Make sense
Thanks
Zhijian
>
> Bob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-15 3:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-08 5:23 [PATCH] RDMA/rxe: Remove unused mask parameter lizhijian
2022-07-14 16:32 ` Bob Pearson
2022-07-15 3:42 ` lizhijian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.