* Re: [PATCH] ARM: sun9i: smp: fix out-of-bounds access error
[not found] <20220929012944.454613-1-william.zhang@broadcom.com>
@ 2022-10-03 22:10 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2022-10-03 22:10 UTC (permalink / raw)
To: William Zhang, Linux ARM List
Cc: f.fainelli, anand.gore, Broadcom Kernel List, Chen-Yu Tsai,
Jernej Skrabec, Maxime Ripard, Mylène Josserand,
Russell King, Samuel Holland, linux-kernel, linux-sunxi
On 9/28/22 18:29, William Zhang wrote:
> When running multi_v7_defconfig with CONFIG_UBSAN enabled, kernel
> reports UBSAN array-index-out-of-bounds error in sunxi_mc_smp_init
> function on non-sunxi platform.
>
> Checking index to the sunxi_mc_smp_data array for out-of-bounds
> condition is needed to cover non-sunxi platform. Also fix the handling
> of return value from of_property_match_string function. Only negitive
> value is an error condition and should bail out from the function.
>
> Fixes: 1631090e34f5 ("ARM: sun9i: smp: Add is_a83t field")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
FWIW:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: sun9i: smp: fix out-of-bounds access error
@ 2022-10-03 22:10 ` Florian Fainelli
0 siblings, 0 replies; 2+ messages in thread
From: Florian Fainelli @ 2022-10-03 22:10 UTC (permalink / raw)
To: William Zhang, Linux ARM List
Cc: f.fainelli, anand.gore, Broadcom Kernel List, Chen-Yu Tsai,
Jernej Skrabec, Maxime Ripard, Mylène Josserand,
Russell King, Samuel Holland, linux-kernel, linux-sunxi
On 9/28/22 18:29, William Zhang wrote:
> When running multi_v7_defconfig with CONFIG_UBSAN enabled, kernel
> reports UBSAN array-index-out-of-bounds error in sunxi_mc_smp_init
> function on non-sunxi platform.
>
> Checking index to the sunxi_mc_smp_data array for out-of-bounds
> condition is needed to cover non-sunxi platform. Also fix the handling
> of return value from of_property_match_string function. Only negitive
> value is an error condition and should bail out from the function.
>
> Fixes: 1631090e34f5 ("ARM: sun9i: smp: Add is_a83t field")
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
FWIW:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-03 22:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220929012944.454613-1-william.zhang@broadcom.com>
2022-10-03 22:10 ` [PATCH] ARM: sun9i: smp: fix out-of-bounds access error Florian Fainelli
2022-10-03 22:10 ` Florian Fainelli
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.