* [PATCH v2] usb: dwc2: Check for null res pointer
@ 2021-12-20 8:09 Jiasheng Jiang
2021-12-20 9:44 ` Minas Harutyunyan
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2021-12-20 8:09 UTC (permalink / raw)
To: hminas, gregkh, linux-usb, linux-kernel; +Cc: Jiasheng Jiang
The return value of platform_get_resource() needs to be checked.
To avoid use of error pointer in case of the failure of alloc.
Fixes: 348becdcc319 ("usb: dwc2: fix "iomem 0x00000000" message")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
Changelog:
v1 -> v2
*Change 1. Correct the commit message.
---
drivers/usb/dwc2/hcd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 2a7828971d05..517743555b9c 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -5191,6 +5191,11 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
hcd->has_tt = 1;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res) {
+ retval = -EINVAL;
+ goto error1;
+ }
+
hcd->rsrc_start = res->start;
hcd->rsrc_len = resource_size(res);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] usb: dwc2: Check for null res pointer
2021-12-20 8:09 [PATCH v2] usb: dwc2: Check for null res pointer Jiasheng Jiang
@ 2021-12-20 9:44 ` Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2021-12-20 9:44 UTC (permalink / raw)
To: Jiasheng Jiang, gregkh, linux-usb, linux-kernel
Hi Jiasheng,
On 12/20/2021 12:09 PM, Jiasheng Jiang wrote:
> The return value of platform_get_resource() needs to be checked.
> To avoid use of error pointer in case of the failure of alloc.
>
> Fixes: 348becdcc319 ("usb: dwc2: fix "iomem 0x00000000" message")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2
>
> *Change 1. Correct the commit message.
> ---
> drivers/usb/dwc2/hcd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2a7828971d05..517743555b9c 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -5191,6 +5191,11 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
> hcd->has_tt = 1;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + retval = -EINVAL;
> + goto error1;
> + }
> +
> hcd->rsrc_start = res->start;
> hcd->rsrc_len = resource_size(res);
>
This patch already in code. Please check follow patch:
commit 856e6e8e0f9300befa87dde09edb578555c99a82
Author: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue Aug 31 16:42:36 2021 +0800
usb: dwc2: check return value after calling platform_get_resource()
Thanks,
Minas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-20 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-20 8:09 [PATCH v2] usb: dwc2: Check for null res pointer Jiasheng Jiang
2021-12-20 9:44 ` Minas Harutyunyan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.