All of lore.kernel.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Dan Malek <dan@embeddedalley.com>
Cc: Kumar Gala <galak@kernel.crashing.org>,
	linux-ppc-embedded <linuxppc-embedded@ozlabs.org>,
	Timur Tabi <timur@freescale.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Torben.Mathiasen@hp.com
Subject: Re: lanana: Add major/minor entries for PPC QE UART devices
Date: Thu, 1 Mar 2007 17:43:57 +0100	[thread overview]
Message-ID: <7a96cdcde345a4e75fb451cecd32501f@kernel.crashing.org> (raw)
In-Reply-To: <BE8D549F-71E4-43DE-B624-A8E4A50D094D@embeddedalley.com>

>> - Cap the driver at 4 UARTs;
>
> Let's do this, but design the code to
> allow more by just changing a #define.
>
>> Just randomly using some extra minors that aren't
>> assigned to you isn't such a great idea.
>
> Maybe for a desktop or generic server where
> you don't know what's going to be configured,
> but it's not unusual to do so with custom
> embedded systems.

You can do whatever you want in your own stuff
but that's not how things work in the mainstream
Linux kernel.

> The small experimental
> or user allocations often don't cover what
> is needed, so we just grab some allocation
> from a device that isn't ever going to be
> used on the system.

Sure I've done that myself a few times, but this
just doesn't fly for in-kernel drivers; those have
their own ranges defined in devices.txt and don't
use random other minors.


Segher


WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Dan Malek <dan@embeddedalley.com>
Cc: linux-ppc-embedded <linuxppc-embedded@ozlabs.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Torben.Mathiasen@hp.com, Timur Tabi <timur@freescale.com>
Subject: Re: lanana: Add major/minor entries for PPC QE UART devices
Date: Thu, 1 Mar 2007 17:43:57 +0100	[thread overview]
Message-ID: <7a96cdcde345a4e75fb451cecd32501f@kernel.crashing.org> (raw)
In-Reply-To: <BE8D549F-71E4-43DE-B624-A8E4A50D094D@embeddedalley.com>

>> - Cap the driver at 4 UARTs;
>
> Let's do this, but design the code to
> allow more by just changing a #define.
>
>> Just randomly using some extra minors that aren't
>> assigned to you isn't such a great idea.
>
> Maybe for a desktop or generic server where
> you don't know what's going to be configured,
> but it's not unusual to do so with custom
> embedded systems.

You can do whatever you want in your own stuff
but that's not how things work in the mainstream
Linux kernel.

> The small experimental
> or user allocations often don't cover what
> is needed, so we just grab some allocation
> from a device that isn't ever going to be
> used on the system.

Sure I've done that myself a few times, but this
just doesn't fly for in-kernel drivers; those have
their own ranges defined in devices.txt and don't
use random other minors.


Segher

  parent reply	other threads:[~2007-03-01 16:44 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-27 17:25 lanana: Add major/minor entries for PPC QE UART devices Timur Tabi
2007-02-27 17:36 ` Randy Dunlap
2007-02-28  1:45 ` Segher Boessenkool
2007-02-28 14:34   ` Timur Tabi
2007-02-28 14:54     ` Segher Boessenkool
2007-02-28 14:54       ` Segher Boessenkool
2007-02-28 15:46       ` Dan Malek
2007-02-28 15:46         ` Dan Malek
2007-02-28 17:04         ` Timur Tabi
2007-02-28 17:04           ` Timur Tabi
2007-02-28 17:27           ` Dan Malek
2007-02-28 17:27             ` Dan Malek
2007-02-28 17:35             ` Timur Tabi
2007-02-28 17:46               ` Dan Malek
2007-02-28 17:51                 ` Timur Tabi
2007-02-28 18:00                   ` H. Peter Anvin
2007-02-28 18:00                     ` H. Peter Anvin
2007-02-28 18:20                     ` Dan Malek
2007-02-28 19:18                       ` Kumar Gala
2007-02-28 19:18                         ` Kumar Gala
2007-02-28 19:21                         ` H. Peter Anvin
2007-02-28 19:21                           ` H. Peter Anvin
2007-02-28 19:30                           ` Timur Tabi
2007-02-28 19:30                             ` Timur Tabi
2007-02-28 19:33                             ` Kumar Gala
2007-02-28 19:33                               ` Kumar Gala
2007-02-28 19:43                               ` Timur Tabi
2007-02-28 19:43                                 ` Timur Tabi
2007-02-28 20:57                                 ` Dan Malek
2007-02-28 20:57                                   ` Dan Malek
2007-02-28 22:08                                   ` Segher Boessenkool
2007-02-28 22:08                                     ` Segher Boessenkool
2007-03-01 15:48                                     ` Dan Malek
2007-03-01 15:48                                       ` Dan Malek
2007-03-01 15:55                                       ` Timur Tabi
2007-03-01 15:55                                         ` Timur Tabi
2007-03-01 16:06                                         ` Dan Malek
2007-03-01 16:06                                           ` Dan Malek
2007-03-01 16:13                                           ` Timur Tabi
2007-03-01 16:13                                             ` Timur Tabi
2007-03-01 16:43                                       ` Segher Boessenkool [this message]
2007-03-01 16:43                                         ` Segher Boessenkool
2007-03-01 13:38                                   ` Mathiasen, Torben
2007-03-01 13:38                                     ` Mathiasen, Torben
2007-02-28 19:21                       ` Timur Tabi
2007-02-28 19:21                         ` Timur Tabi
2007-02-28 19:25                       ` Segher Boessenkool
2007-02-28 19:25                         ` Segher Boessenkool
2007-02-28 19:27                         ` H. Peter Anvin
2007-02-28 19:27                           ` H. Peter Anvin
2007-02-28 19:45                           ` Segher Boessenkool
2007-02-28 19:45                             ` Segher Boessenkool
2007-02-28 22:40                         ` Jan Engelhardt
2007-02-28 22:40                           ` Jan Engelhardt
2007-02-28 12:07 ` Mathiasen, Torben
2007-02-28 13:00   ` H. Peter Anvin
2007-02-28 13:14     ` Mathiasen, Torben
2007-02-28 14:32       ` Kumar Gala
2007-02-28 14:37       ` Timur Tabi
2007-02-28 14:51         ` Mathiasen, Torben
2007-02-28 14:54           ` Kumar Gala
2007-02-28 15:13             ` H. Peter Anvin
2007-02-28 16:29               ` Timur Tabi
2007-02-28 16:33                 ` H. Peter Anvin
2007-02-28 16:20             ` Timur Tabi
2007-02-28 14:35     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a96cdcde345a4e75fb451cecd32501f@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=Torben.Mathiasen@hp.com \
    --cc=dan@embeddedalley.com \
    --cc=galak@kernel.crashing.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.