* [PATCH v2] drm/amd/display: Fix warning about overflow
@ 2017-10-13 19:02 Harry Wentland
[not found] ` <20171013190248.685-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Harry Wentland @ 2017-10-13 19:02 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
michel-otUistvHUpPR7s880joybQ, michel.daenzer-5C7GfCeVMHo,
christian.koenig-5C7GfCeVMHo
Cc: Harry Wentland
v2: convert value to bool using !!
Signed-off-by: Harry Wentland <harry.wentland@amd.com>
---
drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
index cb94e18cc455..43e9a9959288 100644
--- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
+++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
@@ -1042,13 +1042,13 @@ static enum bp_result get_embedded_panel_info_v2_1(
info->lcd_timing.misc_info.VERTICAL_CUT_OFF = 0;
info->lcd_timing.misc_info.H_REPLICATION_BY2 =
- lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2;
+ !!(lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2);
info->lcd_timing.misc_info.V_REPLICATION_BY2 =
- lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2;
+ !!(lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2);
info->lcd_timing.misc_info.COMPOSITE_SYNC =
- lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC;
+ !!(lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC);
info->lcd_timing.misc_info.INTERLACE =
- lvds->lcd_timing.miscinfo & ATOM_INTERLACE;
+ !!(lvds->lcd_timing.miscinfo & ATOM_INTERLACE);
/* not provided by VBIOS*/
info->lcd_timing.misc_info.DOUBLE_CLOCK = 0;
@@ -1056,7 +1056,7 @@ static enum bp_result get_embedded_panel_info_v2_1(
info->ss_id = 0;
info->realtek_eDPToLVDS =
- (lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID ? 1:0);
+ !!(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID);
return BP_RESULT_OK;
}
--
2.14.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH v2] drm/amd/display: Fix warning about overflow
[not found] ` <20171013190248.685-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
@ 2017-10-13 19:04 ` Deucher, Alexander
[not found] ` <BN6PR12MB16526E196D98A738406709B7F7480-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-10-16 8:56 ` Michel Dänzer
1 sibling, 1 reply; 5+ messages in thread
From: Deucher, Alexander @ 2017-10-13 19:04 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
michel-otUistvHUpPR7s880joybQ, Daenzer, Michel, Koenig,
Christian
Cc: Wentland, Harry
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Harry Wentland
> Sent: Friday, October 13, 2017 3:03 PM
> To: amd-gfx@lists.freedesktop.org; michel@daenzer.net; Daenzer, Michel;
> Koenig, Christian
> Cc: Wentland, Harry
> Subject: [PATCH v2] drm/amd/display: Fix warning about overflow
>
> v2: convert value to bool using !!
>
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index cb94e18cc455..43e9a9959288 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -1042,13 +1042,13 @@ static enum bp_result
> get_embedded_panel_info_v2_1(
> info->lcd_timing.misc_info.VERTICAL_CUT_OFF = 0;
>
> info->lcd_timing.misc_info.H_REPLICATION_BY2 =
> - lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2;
> + !!(lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2);
> info->lcd_timing.misc_info.V_REPLICATION_BY2 =
> - lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2;
> + !!(lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2);
> info->lcd_timing.misc_info.COMPOSITE_SYNC =
> - lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC;
> + !!(lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC);
> info->lcd_timing.misc_info.INTERLACE =
> - lvds->lcd_timing.miscinfo & ATOM_INTERLACE;
> + !!(lvds->lcd_timing.miscinfo & ATOM_INTERLACE);
>
> /* not provided by VBIOS*/
> info->lcd_timing.misc_info.DOUBLE_CLOCK = 0;
> @@ -1056,7 +1056,7 @@ static enum bp_result
> get_embedded_panel_info_v2_1(
> info->ss_id = 0;
>
> info->realtek_eDPToLVDS =
> - (lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID ?
> 1:0);
> + !!(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID);
>
> return BP_RESULT_OK;
> }
> --
> 2.14.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm/amd/display: Fix warning about overflow
[not found] ` <BN6PR12MB16526E196D98A738406709B7F7480-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2017-10-14 8:05 ` Christian König
0 siblings, 0 replies; 5+ messages in thread
From: Christian König @ 2017-10-14 8:05 UTC (permalink / raw)
To: Deucher, Alexander, Wentland, Harry,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
michel-otUistvHUpPR7s880joybQ, Daenzer, Michel, Koenig,
Christian
Am 13.10.2017 um 21:04 schrieb Deucher, Alexander:
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
>> Of Harry Wentland
>> Sent: Friday, October 13, 2017 3:03 PM
>> To: amd-gfx@lists.freedesktop.org; michel@daenzer.net; Daenzer, Michel;
>> Koenig, Christian
>> Cc: Wentland, Harry
>> Subject: [PATCH v2] drm/amd/display: Fix warning about overflow
>>
>> v2: convert value to bool using !!
>>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
>
>> ---
>> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> index cb94e18cc455..43e9a9959288 100644
>> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> @@ -1042,13 +1042,13 @@ static enum bp_result
>> get_embedded_panel_info_v2_1(
>> info->lcd_timing.misc_info.VERTICAL_CUT_OFF = 0;
>>
>> info->lcd_timing.misc_info.H_REPLICATION_BY2 =
>> - lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2);
>> info->lcd_timing.misc_info.V_REPLICATION_BY2 =
>> - lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2);
>> info->lcd_timing.misc_info.COMPOSITE_SYNC =
>> - lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC);
>> info->lcd_timing.misc_info.INTERLACE =
>> - lvds->lcd_timing.miscinfo & ATOM_INTERLACE;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_INTERLACE);
>>
>> /* not provided by VBIOS*/
>> info->lcd_timing.misc_info.DOUBLE_CLOCK = 0;
>> @@ -1056,7 +1056,7 @@ static enum bp_result
>> get_embedded_panel_info_v2_1(
>> info->ss_id = 0;
>>
>> info->realtek_eDPToLVDS =
>> - (lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID ?
>> 1:0);
>> + !!(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID);
>>
>> return BP_RESULT_OK;
>> }
>> --
>> 2.14.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm/amd/display: Fix warning about overflow
[not found] ` <20171013190248.685-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2017-10-13 19:04 ` Deucher, Alexander
@ 2017-10-16 8:56 ` Michel Dänzer
[not found] ` <7aa74a33-e9a5-5ddd-8999-9bb97f303165-otUistvHUpPR7s880joybQ@public.gmane.org>
1 sibling, 1 reply; 5+ messages in thread
From: Michel Dänzer @ 2017-10-16 8:56 UTC (permalink / raw)
To: Harry Wentland
Cc: christian.koenig-5C7GfCeVMHo, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 13/10/17 09:02 PM, Harry Wentland wrote:
> v2: convert value to bool using !!
>
> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> index cb94e18cc455..43e9a9959288 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
> @@ -1042,13 +1042,13 @@ static enum bp_result get_embedded_panel_info_v2_1(
> info->lcd_timing.misc_info.VERTICAL_CUT_OFF = 0;
>
> info->lcd_timing.misc_info.H_REPLICATION_BY2 =
> - lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2;
> + !!(lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2);
> info->lcd_timing.misc_info.V_REPLICATION_BY2 =
> - lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2;
> + !!(lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2);
> info->lcd_timing.misc_info.COMPOSITE_SYNC =
> - lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC;
> + !!(lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC);
> info->lcd_timing.misc_info.INTERLACE =
> - lvds->lcd_timing.miscinfo & ATOM_INTERLACE;
> + !!(lvds->lcd_timing.miscinfo & ATOM_INTERLACE);
>
> /* not provided by VBIOS*/
> info->lcd_timing.misc_info.DOUBLE_CLOCK = 0;
> @@ -1056,7 +1056,7 @@ static enum bp_result get_embedded_panel_info_v2_1(
> info->ss_id = 0;
>
> info->realtek_eDPToLVDS =
> - (lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID ? 1:0);
> + !!(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID);
>
> return BP_RESULT_OK;
> }
>
The commit log doesn't fit the change very well anymore.
Pet peeve alert:
In general, IMHO one doesn't "fix a warning". One either fixes a problem
which was highlighted by a warning, such as in this case, or one
silences the warning instead. One should always make sure carefully
there's no actual problem behind a warning before simply silencing it.
That said, the actual fix is
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drm/amd/display: Fix warning about overflow
[not found] ` <7aa74a33-e9a5-5ddd-8999-9bb97f303165-otUistvHUpPR7s880joybQ@public.gmane.org>
@ 2017-10-16 14:25 ` Harry Wentland
0 siblings, 0 replies; 5+ messages in thread
From: Harry Wentland @ 2017-10-16 14:25 UTC (permalink / raw)
To: Michel Dänzer
Cc: christian.koenig-5C7GfCeVMHo, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On 2017-10-16 04:56 AM, Michel Dänzer wrote:
> On 13/10/17 09:02 PM, Harry Wentland wrote:
>> v2: convert value to bool using !!
>>
>> Signed-off-by: Harry Wentland <harry.wentland@amd.com>
>> ---
>> drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> index cb94e18cc455..43e9a9959288 100644
>> --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c
>> @@ -1042,13 +1042,13 @@ static enum bp_result get_embedded_panel_info_v2_1(
>> info->lcd_timing.misc_info.VERTICAL_CUT_OFF = 0;
>>
>> info->lcd_timing.misc_info.H_REPLICATION_BY2 =
>> - lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_H_REPLICATIONBY2);
>> info->lcd_timing.misc_info.V_REPLICATION_BY2 =
>> - lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_V_REPLICATIONBY2);
>> info->lcd_timing.misc_info.COMPOSITE_SYNC =
>> - lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_COMPOSITESYNC);
>> info->lcd_timing.misc_info.INTERLACE =
>> - lvds->lcd_timing.miscinfo & ATOM_INTERLACE;
>> + !!(lvds->lcd_timing.miscinfo & ATOM_INTERLACE);
>>
>> /* not provided by VBIOS*/
>> info->lcd_timing.misc_info.DOUBLE_CLOCK = 0;
>> @@ -1056,7 +1056,7 @@ static enum bp_result get_embedded_panel_info_v2_1(
>> info->ss_id = 0;
>>
>> info->realtek_eDPToLVDS =
>> - (lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID ? 1:0);
>> + !!(lvds->dplvdsrxid == eDP_TO_LVDS_REALTEK_ID);
>>
>> return BP_RESULT_OK;
>> }
>>
>
> The commit log doesn't fit the change very well anymore.
>
>
> Pet peeve alert:
>
> In general, IMHO one doesn't "fix a warning". One either fixes a problem
> which was highlighted by a warning, such as in this case, or one
> silences the warning instead. One should always make sure carefully
> there's no actual problem behind a warning before simply silencing it.
>
>
Very good points and thanks for preaching it. We've been doing quite badly on
this front in the DC team and I often get lazy myself. Will keep an eye on this
going forward.
> That said, the actual fix is
>
Thanks.
Harry
> Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-10-16 14:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-13 19:02 [PATCH v2] drm/amd/display: Fix warning about overflow Harry Wentland
[not found] ` <20171013190248.685-1-harry.wentland-5C7GfCeVMHo@public.gmane.org>
2017-10-13 19:04 ` Deucher, Alexander
[not found] ` <BN6PR12MB16526E196D98A738406709B7F7480-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2017-10-14 8:05 ` Christian König
2017-10-16 8:56 ` Michel Dänzer
[not found] ` <7aa74a33-e9a5-5ddd-8999-9bb97f303165-otUistvHUpPR7s880joybQ@public.gmane.org>
2017-10-16 14:25 ` Harry Wentland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.