All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <hwentlan@amd.com>
To: Mario Kleiner <mario.kleiner.de@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, nicholas.kazlauskas@amd.com
Subject: Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.
Date: Wed, 20 May 2020 12:40:18 -0400	[thread overview]
Message-ID: <7ab95258-02a9-fd39-6806-e6e81ddc295c@amd.com> (raw)
In-Reply-To: <20200515051924.12331-3-mario.kleiner.de@gmail.com>

On 2020-05-15 1:19 a.m., Mario Kleiner wrote:
> Testing on a Polaris11 gpu with DCE-11.2 suggests that it
> seems to work fine there, so optimistically enable it for
> DCE-11 and later.
> 
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
>  drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
>  drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 9597fc79d7fa..a043ddae5149 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
>  		.pixel_format_support = {
>  				.argb8888 = true,
>  				.nv12 = false,
> -				.fp16 = false
> +				.fp16 = true

Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I
recommend we leave it off here.

Harry

>  		},
>  
>  		.max_upscale_factor = {
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index 4a7796de2ff5..51b3fe502670 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
>  	.pixel_format_support = {
>  			.argb8888 = true,
>  			.nv12 = false,
> -			.fp16 = false
> +			.fp16 = true
>  	},
>  
>  	.max_upscale_factor = {
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 9a9764cbd78d..8f362e8c1787 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
>  	.pixel_format_support = {
>  			.argb8888 = true,
>  			.nv12 = false,
> -			.fp16 = false
> +			.fp16 = true
>  	},
>  
>  	.max_upscale_factor = {
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Harry Wentland <hwentlan@amd.com>
To: Mario Kleiner <mario.kleiner.de@gmail.com>,
	dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc: alexander.deucher@amd.com, nicholas.kazlauskas@amd.com
Subject: Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12.
Date: Wed, 20 May 2020 12:40:18 -0400	[thread overview]
Message-ID: <7ab95258-02a9-fd39-6806-e6e81ddc295c@amd.com> (raw)
In-Reply-To: <20200515051924.12331-3-mario.kleiner.de@gmail.com>

On 2020-05-15 1:19 a.m., Mario Kleiner wrote:
> Testing on a Polaris11 gpu with DCE-11.2 suggests that it
> seems to work fine there, so optimistically enable it for
> DCE-11 and later.
> 
> Signed-off-by: Mario Kleiner <mario.kleiner.de@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 +-
>  drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 +-
>  drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> index 9597fc79d7fa..a043ddae5149 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c
> @@ -410,7 +410,7 @@ static const struct dc_plane_cap plane_cap = {
>  		.pixel_format_support = {
>  				.argb8888 = true,
>  				.nv12 = false,
> -				.fp16 = false
> +				.fp16 = true

Carrizo (DCE 11.0) has a HW bug where FP16 scaling doesn't work. I
recommend we leave it off here.

Harry

>  		},
>  
>  		.max_upscale_factor = {
> diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> index 4a7796de2ff5..51b3fe502670 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c
> @@ -411,7 +411,7 @@ static const struct dc_plane_cap plane_cap = {
>  	.pixel_format_support = {
>  			.argb8888 = true,
>  			.nv12 = false,
> -			.fp16 = false
> +			.fp16 = true
>  	},
>  
>  	.max_upscale_factor = {
> diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> index 9a9764cbd78d..8f362e8c1787 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c
> @@ -516,7 +516,7 @@ static const struct dc_plane_cap plane_cap = {
>  	.pixel_format_support = {
>  			.argb8888 = true,
>  			.nv12 = false,
> -			.fp16 = false
> +			.fp16 = true
>  	},
>  
>  	.max_upscale_factor = {
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2020-05-20 16:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15  5:19 fp16 support in xBGR order, and for DCE-11+ Mario Kleiner
2020-05-15  5:19 ` Mario Kleiner
2020-05-15  5:19 ` [PATCH 1/2] drm/amd/display: Expose support for xBGR ordered fp16 formats Mario Kleiner
2020-05-15  5:19   ` Mario Kleiner
2020-05-15  5:19 ` [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-11.0 - DCE-12 Mario Kleiner
2020-05-15  5:19   ` Mario Kleiner
2020-05-20 15:11   ` Kazlauskas, Nicholas
2020-05-20 15:11     ` Kazlauskas, Nicholas
2020-05-20 16:40   ` Harry Wentland [this message]
2020-05-20 16:40     ` Harry Wentland
2020-05-20 18:25     ` Alex Deucher
2020-05-20 18:25       ` Alex Deucher
2020-05-20 18:44       ` Mario Kleiner
2020-05-20 18:44         ` Mario Kleiner
2020-05-20 19:07         ` Kazlauskas, Nicholas
2020-05-20 19:07           ` Kazlauskas, Nicholas
2020-05-20 19:57           ` Mario Kleiner
2020-05-20 19:57             ` Mario Kleiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ab95258-02a9-fd39-6806-e6e81ddc295c@amd.com \
    --to=hwentlan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mario.kleiner.de@gmail.com \
    --cc=nicholas.kazlauskas@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.