Re: [RFC PATCH v1 19/19] rtw88: Add support for the SDIO based RTL8821CS chipset

From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: Sascha Hauer <sha@pengutronix.de>
Cc: Chris Morgan <macroalpha82@gmail.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-wireless@vger.kernel.org,
	Yan-Hsuan Chuang <tony0620emma@gmail.com>,
	Kalle Valo <kvalo@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, Nitin Gupta <nitin.gupta981@gmail.com>,
	Neo Jou <neojou@gmail.com>, Pkshih <pkshih@realtek.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: Re: [RFC PATCH v1 19/19] rtw88: Add support for the SDIO based RTL8821CS chipset
Date: Thu, 5 Jan 2023 17:38:08 +0200	[thread overview]
Message-ID: <7b3e4eaf-258f-bf5c-80f8-68d04d285235@gmail.com> (raw)
In-Reply-To: <20230105080142.GA15042@pengutronix.de>

On 05/01/2023 10:01, Sascha Hauer wrote:
> On Wed, Jan 04, 2023 at 09:59:35PM +0200, Bitterblue Smith wrote:
>> On 04/01/2023 01:01, Chris Morgan wrote:
>>> On Wed, Dec 28, 2022 at 12:30:20AM +0100, Martin Blumenstingl wrote:
>>>> Wire up RTL8821CS chipset support using the new rtw88 SDIO HCI code as
>>>> well as the existing RTL8821C chipset code.
>>>>
>>>
>>> Unfortunately, this doesn't work for me. I applied it on top of 6.2-rc2
>>> master and I get errors during probe (it appears the firmware never
>>> loads).
>>>
>>> Relevant dmesg logs are as follows:
>>>
>>> [    0.989545] mmc2: new high speed SDIO card at address 0001
>>> [    0.989993] rtw_8821cs mmc2:0001:1: Firmware version 24.8.0, H2C version 12
>>> [    1.005684] rtw_8821cs mmc2:0001:1: sdio write32 failed (0x14): -110
>>> [    1.005737] rtw_8821cs mmc2:0001:1: sdio read32 failed (0x1080): -110
>>> [    1.005789] rtw_8821cs mmc2:0001:1: sdio write32 failed (0x11080): -110
>>> [    1.005840] rtw_8821cs mmc2:0001:1: sdio read8 failed (0x3): -110
>>> [    1.005920] rtw_8821cs mmc2:0001:1: sdio read8 failed (0x1103): -110
>>> [    1.005998] rtw_8821cs mmc2:0001:1: sdio read32 failed (0x80): -110
>>> [    1.006078] rtw_8821cs mmc2:0001:1: sdio read32 failed (0x1700): -110
>>>
>>> The error of "sdio read32 failed (0x1700): -110" then repeats several
>>> hundred times, then I get this:
>>>
>>> [    1.066294] rtw_8821cs mmc2:0001:1: failed to download firmware
>>> [    1.066367] rtw_8821cs mmc2:0001:1: sdio read16 failed (0x80): -110
>>> [    1.066417] rtw_8821cs mmc2:0001:1: sdio read8 failed (0x100): -110
>>> [    1.066697] rtw_8821cs mmc2:0001:1: failed to setup chip efuse info
>>> [    1.066703] rtw_8821cs mmc2:0001:1: failed to setup chip information
>>> [    1.066839] rtw_8821cs: probe of mmc2:0001:1 failed with error -16
>>>
>>> The hardware I am using is an rtl8821cs that I can confirm was working
>>> with a previous driver.
>>>
>>> Thank you.
>>>
>> The USB-based RTL8811CU also doesn't work, with suspiciously similar
>> errors:
>>
>> Dec 25 21:43:37 home kernel: rtw_8821cu 1-2:1.0: Firmware version 24.11.0, H2C version 12
>> Dec 25 21:43:37 home kernel: rtw_8821cu 1-2:1.0 wlp0s20f0u2: renamed from wlan0
>> Dec 25 21:43:40 home kernel: rtw_8821cu 1-2:1.0: read register 0x5 failed with -110
> 
> Is this the very first register access or are there other register
> accesses before that actually do work?
> 
> Sascha
> 
It's not the first register access. rtw_mac_power_switch() runs a few
times before things fail.