All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-wireless@vger.kernel.org,
	Yan-Hsuan Chuang <tony0620emma@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-mmc@vger.kernel.org, Chris Morgan <macroalpha82@gmail.com>,
	Nitin Gupta <nitin.gupta981@gmail.com>,
	Neo Jou <neojou@gmail.com>, Pkshih <pkshih@realtek.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: Re: [RFC PATCH v1 00/19] rtw88: Add SDIO support
Date: Tue, 17 Jan 2023 20:01:32 +0200	[thread overview]
Message-ID: <87k01lxcoz.fsf@kernel.org> (raw)
In-Reply-To: <20230117092114.62ba2f66@kernel.org> (Jakub Kicinski's message of "Tue, 17 Jan 2023 09:21:14 -0800")

Jakub Kicinski <kuba@kernel.org> writes:

> On Mon, 16 Jan 2023 18:01:05 +0200 Kalle Valo wrote:
>> > - My understanding is that there's a discussion about the rtw88 Kconfig
>> >   symbols. We're adding four new ones within this series. It's not
>> >   clear to me what the conclusion is on this topic though.  
>> 
>> Yeah, there were no conclusions about that. Jakub, do you have any
>> opinions? For example, do we keep per device Kconfig options (eg.
>> CONFIG_RTW88_8822BS, RTW88_8822CS and so on) or should we have only one
>> more bus level option (eg. CONFIG_RTW88_SDIO)? rtw88 now uses the former
>> and IIRC so does mt76. ath10k/ath11k/ath12k again use the latter :)
>
> No strong feelings. Larry (IIRC) provided a fair justification for 
> the RTW symbols. If the module binary grows noticeably then having 
> the kconfig does indeed make sense.

Thanks, makes sense. So the plan is that rtw88 continues to use per
device Kconfig symbols with SDIO.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

      reply	other threads:[~2023-01-17 18:34 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-27 23:30 [RFC PATCH v1 00/19] rtw88: Add SDIO support Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 01/19] rtw88: mac: Use existing interface mask macros in rtw_pwr_seq_parser() Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 02/19] rtw88: pci: Change type of rtw_hw_queue_mapping() and ac_to_hwq to enum Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 03/19] rtw88: pci: Change queue datatype from u8 to enum rtw_tx_queue_type Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 04/19] rtw88: Move enum rtw_tx_queue_type mapping code to tx.{c,h} Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 05/19] mmc: sdio: add Realtek SDIO vendor ID and various wifi device IDs Martin Blumenstingl
2023-01-03 11:41   ` Ulf Hansson
2022-12-27 23:30 ` [RFC PATCH v1 06/19] rtw88: rtw8821c: Add support for parsing the RTL8821CS (SDIO) efuse Martin Blumenstingl
2022-12-28  6:21   ` Ping-Ke Shih
2022-12-27 23:30 ` [RFC PATCH v1 07/19] rtw88: rtw8822b: Add support for parsing the RTL8822BS " Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 08/19] rtw88: rtw8822c: Add support for parsing the RTL8822CS " Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 09/19] rtw88: hci: Add an optional power_switch() callback to rtw_hci_ops Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 10/19] rtw88: mac: Add support for the SDIO HCI in rtw_pwr_seq_parser() Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 11/19] rtw88: mac: Add support for the SDIO HCI in the TX/page table setup Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 12/19] rtw88: sdio: Add HCI implementation for SDIO based chipsets Martin Blumenstingl
2022-12-28  9:39   ` Ping-Ke Shih
2022-12-28 11:59     ` Martin Blumenstingl
2022-12-29  0:50       ` Ping-Ke Shih
2023-01-03 11:42   ` Ulf Hansson
2022-12-27 23:30 ` [RFC PATCH v1 13/19] rtw88: mac: Add support for SDIO specifics in the power on sequence Martin Blumenstingl
2022-12-29  1:14   ` Ping-Ke Shih
2022-12-29 10:49     ` Martin Blumenstingl
2022-12-29 11:24       ` Ping-Ke Shih
2022-12-27 23:30 ` [RFC PATCH v1 14/19] rtw88: main: Add the rpwm_addr and cpwm_addr for SDIO based chipsets Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 15/19] rtw88: main: Reserve 8 bytes of extra TX headroom for SDIO based cards Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 16/19] rtw88: ps: Increase LEAVE_LPS_TRY_CNT for SDIO based chipsets Martin Blumenstingl
2022-12-27 23:30 ` [RFC PATCH v1 17/19] rtw88: Add support for the SDIO based RTL8822BS chipset Martin Blumenstingl
2022-12-28  6:06   ` kernel test robot
2022-12-28 23:57   ` kernel test robot
2022-12-30  7:55   ` kernel test robot
2022-12-27 23:30 ` [RFC PATCH v1 18/19] rtw88: Add support for the SDIO based RTL8822CS chipset Martin Blumenstingl
2022-12-29  1:40   ` Ping-Ke Shih
2022-12-27 23:30 ` [RFC PATCH v1 19/19] rtw88: Add support for the SDIO based RTL8821CS chipset Martin Blumenstingl
2023-01-03 23:01   ` Chris Morgan
2023-01-04 15:40     ` Martin Blumenstingl
2023-01-04 17:05       ` Chris Morgan
2023-01-04 17:23         ` Martin Blumenstingl
2023-01-04 22:45           ` Chris Morgan
2023-01-04 19:59     ` Bitterblue Smith
2023-01-04 20:06       ` Felix Schwarz
2023-01-04 20:14       ` Larry Finger
2023-01-07 14:53         ` Bitterblue Smith
2023-01-05  8:01       ` Sascha Hauer
2023-01-05 15:38         ` Bitterblue Smith
2022-12-29  4:19 ` [RFC PATCH v1 00/19] rtw88: Add SDIO support Ping-Ke Shih
2022-12-29 23:18   ` Martin Blumenstingl
2022-12-30  0:06     ` Ping-Ke Shih
2023-01-16 16:01 ` Kalle Valo
2023-01-17 17:21   ` Jakub Kicinski
2023-01-17 18:01     ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k01lxcoz.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=macroalpha82@gmail.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neojou@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nitin.gupta981@gmail.com \
    --cc=pkshih@realtek.com \
    --cc=tony0620emma@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.