From: Thomas-Mich Richter <tmricht@linux.ibm.com>
To: Kim Phillips <kim.phillips@arm.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Richter <tmricht@linux.vnet.ibm.com>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
perf group <linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH] perf annotate: Handle arm64 move instructions
Date: Tue, 28 Aug 2018 08:22:40 +0200 [thread overview]
Message-ID: <7b5ea377-91a6-d3f3-56a1-a836d5aaa7c5@linux.ibm.com> (raw)
In-Reply-To: <20180827150807.304110d2e9919a17c832ca48@arm.com>
On 08/27/2018 10:08 PM, Kim Phillips wrote:
> Add default handler for non-jump instructions. This really only has an
> effect on instructions that compute a PC-relative address, such as 'adrp,'
> as seen in these couple of examples:
>
> BEFORE: adrp x0, ffff20000aa11000 <kallsyms_token_index+0xce000>
> AFTER: adrp x0, kallsyms_token_index+0xce000
>
> BEFORE: adrp x23, ffff20000ae94000 <__per_cpu_load>
> AFTER: adrp x23, __per_cpu_load
>
> The implementation is identical to that of s390, but with a slight
> adjustment for objdump whitespace propagation (arm64 objdump puts
> spaces after commas, whereas s390's presumably doesn't).
>
> The mov__scnprintf() declaration is moved from s390's to arm64's
> instructions.c because arm64's gets included before s390's.
>
Tested-by: Thomas Richter <tmricht@linux.ibm.com>
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
WARNING: multiple messages have this Message-ID (diff)
From: tmricht@linux.ibm.com (Thomas-Mich Richter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] perf annotate: Handle arm64 move instructions
Date: Tue, 28 Aug 2018 08:22:40 +0200 [thread overview]
Message-ID: <7b5ea377-91a6-d3f3-56a1-a836d5aaa7c5@linux.ibm.com> (raw)
In-Reply-To: <20180827150807.304110d2e9919a17c832ca48@arm.com>
On 08/27/2018 10:08 PM, Kim Phillips wrote:
> Add default handler for non-jump instructions. This really only has an
> effect on instructions that compute a PC-relative address, such as 'adrp,'
> as seen in these couple of examples:
>
> BEFORE: adrp x0, ffff20000aa11000 <kallsyms_token_index+0xce000>
> AFTER: adrp x0, kallsyms_token_index+0xce000
>
> BEFORE: adrp x23, ffff20000ae94000 <__per_cpu_load>
> AFTER: adrp x23, __per_cpu_load
>
> The implementation is identical to that of s390, but with a slight
> adjustment for objdump whitespace propagation (arm64 objdump puts
> spaces after commas, whereas s390's presumably doesn't).
>
> The mov__scnprintf() declaration is moved from s390's to arm64's
> instructions.c because arm64's gets included before s390's.
>
Tested-by: Thomas Richter <tmricht@linux.ibm.com>
--
Thomas Richter, Dept 3303, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzende des Aufsichtsrats: Martina Koederitz
Gesch?ftsf?hrung: Dirk Wittkopp
Sitz der Gesellschaft: B?blingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2018-08-28 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 20:08 [PATCH] perf annotate: Handle arm64 move instructions Kim Phillips
2018-08-27 20:08 ` Kim Phillips
2018-08-28 6:22 ` Thomas-Mich Richter [this message]
2018-08-28 6:22 ` Thomas-Mich Richter
2018-08-30 18:38 ` Arnaldo Carvalho de Melo
2018-08-30 18:38 ` Arnaldo Carvalho de Melo
2018-09-06 13:45 ` [tip:perf/core] " tip-bot for Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b5ea377-91a6-d3f3-56a1-a836d5aaa7c5@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tmricht@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.