From: Florian Fainelli <f.fainelli@gmail.com>
To: Claire Chang <tientzu@chromium.org>,
robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, joro@8bytes.org, will@kernel.org,
frowand.list@gmail.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com
Cc: grant.likely@arm.com, xypron.glpk@gmx.de, treding@nvidia.com,
mingo@kernel.org, bauerman@linux.ibm.com, peterz@infradead.org,
gregkh@linuxfoundation.org, saravanak@google.com,
rafael.j.wysocki@intel.com, heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, rdunlap@infradead.org,
dan.j.williams@intel.com, bgolaszewski@baylibre.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, iommu@lists.linux-foundation.org,
xen-devel@lists.xenproject.org, tfiga@chromium.org,
drinkcat@chromium.org
Subject: Re: [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available
Date: Tue, 12 Jan 2021 15:39:23 -0800 [thread overview]
Message-ID: <7b9b598c-5ccd-f897-a962-14c0ed7af6de@gmail.com> (raw)
In-Reply-To: <20210106034124.30560-4-tientzu@chromium.org>
On 1/5/21 7:41 PM, Claire Chang wrote:
> Regardless of swiotlb setting, the restricted DMA pool is preferred if
> available.
>
> The restricted DMA pools provide a basic level of protection against
> the DMA overwriting buffer contents at unexpected times. However, to
> protect against general data leakage and system memory corruption, the
> system needs to provide a way to restrict the DMA to a predefined memory
> region.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
You could probably split this patch into two:
- one that introduces the get_io_tlb_mem() getter, updates all callers
of is_swiotlb_buffer() to gain a 'struct device' argument
- another one that does add support for a non-default swiotlb pool and
adds dev->dma_io_tlb_mem
Other than that, LGTM!
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Claire Chang <tientzu@chromium.org>,
robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, joro@8bytes.org, will@kernel.org,
frowand.list@gmail.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com
Cc: drinkcat@chromium.org, devicetree@vger.kernel.org,
heikki.krogerus@linux.intel.com, saravanak@google.com,
peterz@infradead.org, xypron.glpk@gmx.de,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
andriy.shevchenko@linux.intel.com, tfiga@chromium.org,
bgolaszewski@baylibre.com, iommu@lists.linux-foundation.org,
grant.likely@arm.com, rdunlap@infradead.org,
gregkh@linuxfoundation.org, xen-devel@lists.xenproject.org,
dan.j.williams@intel.com, treding@nvidia.com,
linuxppc-dev@lists.ozlabs.org, mingo@kernel.org,
bauerman@linux.ibm.com
Subject: Re: [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available
Date: Tue, 12 Jan 2021 15:39:23 -0800 [thread overview]
Message-ID: <7b9b598c-5ccd-f897-a962-14c0ed7af6de@gmail.com> (raw)
In-Reply-To: <20210106034124.30560-4-tientzu@chromium.org>
On 1/5/21 7:41 PM, Claire Chang wrote:
> Regardless of swiotlb setting, the restricted DMA pool is preferred if
> available.
>
> The restricted DMA pools provide a basic level of protection against
> the DMA overwriting buffer contents at unexpected times. However, to
> protect against general data leakage and system memory corruption, the
> system needs to provide a way to restrict the DMA to a predefined memory
> region.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
You could probably split this patch into two:
- one that introduces the get_io_tlb_mem() getter, updates all callers
of is_swiotlb_buffer() to gain a 'struct device' argument
- another one that does add support for a non-default swiotlb pool and
adds dev->dma_io_tlb_mem
Other than that, LGTM!
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Claire Chang <tientzu@chromium.org>,
robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, joro@8bytes.org, will@kernel.org,
frowand.list@gmail.com, konrad.wilk@oracle.com,
boris.ostrovsky@oracle.com, jgross@suse.com,
sstabellini@kernel.org, hch@lst.de, m.szyprowski@samsung.com,
robin.murphy@arm.com
Cc: drinkcat@chromium.org, devicetree@vger.kernel.org,
heikki.krogerus@linux.intel.com, saravanak@google.com,
peterz@infradead.org, xypron.glpk@gmx.de,
rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
andriy.shevchenko@linux.intel.com, bgolaszewski@baylibre.com,
iommu@lists.linux-foundation.org, grant.likely@arm.com,
rdunlap@infradead.org, gregkh@linuxfoundation.org,
xen-devel@lists.xenproject.org, dan.j.williams@intel.com,
treding@nvidia.com, linuxppc-dev@lists.ozlabs.org,
mingo@kernel.org
Subject: Re: [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available
Date: Tue, 12 Jan 2021 15:39:23 -0800 [thread overview]
Message-ID: <7b9b598c-5ccd-f897-a962-14c0ed7af6de@gmail.com> (raw)
In-Reply-To: <20210106034124.30560-4-tientzu@chromium.org>
On 1/5/21 7:41 PM, Claire Chang wrote:
> Regardless of swiotlb setting, the restricted DMA pool is preferred if
> available.
>
> The restricted DMA pools provide a basic level of protection against
> the DMA overwriting buffer contents at unexpected times. However, to
> protect against general data leakage and system memory corruption, the
> system needs to provide a way to restrict the DMA to a predefined memory
> region.
>
> Signed-off-by: Claire Chang <tientzu@chromium.org>
You could probably split this patch into two:
- one that introduces the get_io_tlb_mem() getter, updates all callers
of is_swiotlb_buffer() to gain a 'struct device' argument
- another one that does add support for a non-default swiotlb pool and
adds dev->dma_io_tlb_mem
Other than that, LGTM!
--
Florian
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-01-12 23:40 UTC|newest]
Thread overview: 194+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 3:41 [RFC PATCH v3 0/6] Restricted DMA Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` [RFC PATCH v3 1/6] swiotlb: Add io_tlb_mem struct Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-13 11:50 ` Christoph Hellwig
2021-01-13 11:50 ` Christoph Hellwig
2021-01-13 11:50 ` Christoph Hellwig
2021-01-06 3:41 ` [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 7:50 ` Greg KH
2021-01-06 7:50 ` Greg KH
2021-01-06 7:50 ` Greg KH
2021-01-13 11:51 ` Christoph Hellwig
2021-01-13 11:51 ` Christoph Hellwig
2021-01-13 11:51 ` Christoph Hellwig
2021-01-13 12:29 ` Greg KH
2021-01-13 12:29 ` Greg KH
2021-01-13 12:29 ` Greg KH
2021-01-13 12:37 ` Christoph Hellwig
2021-01-13 12:37 ` Christoph Hellwig
2021-01-13 12:37 ` Christoph Hellwig
2021-01-06 18:52 ` Konrad Rzeszutek Wilk
2021-01-06 18:52 ` Konrad Rzeszutek Wilk
2021-01-06 18:52 ` Konrad Rzeszutek Wilk
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:57 ` Konrad Rzeszutek Wilk
2021-01-07 17:57 ` Konrad Rzeszutek Wilk
2021-01-07 17:57 ` Konrad Rzeszutek Wilk
2021-01-07 18:09 ` Florian Fainelli
2021-01-07 18:09 ` Florian Fainelli
2021-01-07 18:09 ` Florian Fainelli
2021-01-07 21:19 ` Konrad Rzeszutek Wilk
2021-01-07 21:19 ` Konrad Rzeszutek Wilk
2021-01-07 21:19 ` Konrad Rzeszutek Wilk
2021-01-12 23:52 ` Florian Fainelli
2021-01-12 23:52 ` Florian Fainelli
2021-01-12 23:52 ` Florian Fainelli
2021-01-25 5:26 ` Jon Masters
2021-01-25 5:26 ` Jon Masters
2021-01-25 5:26 ` Jon Masters
2021-01-13 1:53 ` Robin Murphy
2021-01-13 1:53 ` Robin Murphy
2021-01-13 1:53 ` Robin Murphy
2021-01-13 0:03 ` Florian Fainelli
2021-01-13 0:03 ` Florian Fainelli
2021-01-13 0:03 ` Florian Fainelli
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 13:59 ` Nicolas Saenz Julienne
2021-01-13 15:27 ` Robin Murphy
2021-01-13 15:27 ` Robin Murphy
2021-01-13 15:27 ` Robin Murphy
2021-01-13 17:43 ` Florian Fainelli
2021-01-13 17:43 ` Florian Fainelli
2021-01-13 17:43 ` Florian Fainelli
2021-01-13 18:03 ` Robin Murphy
2021-01-13 18:03 ` Robin Murphy
2021-01-13 18:03 ` Robin Murphy
2021-01-13 12:42 ` Christoph Hellwig
2021-01-13 12:42 ` Christoph Hellwig
2021-01-13 12:42 ` Christoph Hellwig
2021-01-14 9:06 ` Claire Chang
2021-01-14 9:06 ` Claire Chang
2021-01-14 9:06 ` Claire Chang
2021-01-14 9:06 ` Claire Chang
2021-01-16 13:09 ` kernel test robot
2021-01-06 3:41 ` [RFC PATCH v3 3/6] swiotlb: Use restricted DMA pool if available Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-12 23:39 ` Florian Fainelli [this message]
2021-01-12 23:39 ` Florian Fainelli
2021-01-12 23:39 ` Florian Fainelli
2021-01-13 12:44 ` Christoph Hellwig
2021-01-13 12:44 ` Christoph Hellwig
2021-01-13 12:44 ` Christoph Hellwig
2021-01-06 3:41 ` [RFC PATCH v3 4/6] swiotlb: Add restricted DMA alloc/free support Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 5:38 ` kernel test robot
2021-01-12 23:41 ` Florian Fainelli
2021-01-12 23:41 ` Florian Fainelli
2021-01-12 23:41 ` Florian Fainelli
2021-01-13 12:48 ` Christoph Hellwig
2021-01-13 12:48 ` Christoph Hellwig
2021-01-13 12:48 ` Christoph Hellwig
2021-01-13 18:27 ` Robin Murphy
2021-01-13 18:27 ` Robin Murphy
2021-01-13 18:27 ` Robin Murphy
2021-01-13 18:32 ` Christoph Hellwig
2021-01-13 18:32 ` Christoph Hellwig
2021-01-13 18:32 ` Christoph Hellwig
2021-01-06 3:41 ` [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 18:57 ` Konrad Rzeszutek Wilk
2021-01-06 18:57 ` Konrad Rzeszutek Wilk
2021-01-06 18:57 ` Konrad Rzeszutek Wilk
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 17:39 ` Claire Chang
2021-01-07 18:00 ` Konrad Rzeszutek Wilk
2021-01-07 18:00 ` Konrad Rzeszutek Wilk
2021-01-07 18:00 ` Konrad Rzeszutek Wilk
2021-01-07 18:14 ` Florian Fainelli
2021-01-07 18:14 ` Florian Fainelli
2021-01-07 18:14 ` Florian Fainelli
2021-01-12 7:47 ` Claire Chang
2021-01-12 7:47 ` Claire Chang
2021-01-12 7:47 ` Claire Chang
2021-01-12 7:47 ` Claire Chang
2021-01-20 16:53 ` Rob Herring
2021-01-20 16:53 ` Rob Herring
2021-01-20 16:53 ` Rob Herring
2021-01-20 17:30 ` Robin Murphy
2021-01-20 17:30 ` Robin Murphy
2021-01-20 17:30 ` Robin Murphy
2021-01-20 21:31 ` Rob Herring
2021-01-20 21:31 ` Rob Herring
2021-01-20 21:31 ` Rob Herring
2021-01-20 21:31 ` Rob Herring
2021-01-21 1:09 ` Robin Murphy
2021-01-21 1:09 ` Robin Murphy
2021-01-21 1:09 ` Robin Murphy
2021-01-21 15:48 ` Rob Herring
2021-01-21 15:48 ` Rob Herring
2021-01-21 15:48 ` Rob Herring
2021-01-21 15:48 ` Rob Herring
2021-01-21 17:29 ` Robin Murphy
2021-01-21 17:29 ` Robin Murphy
2021-01-21 17:29 ` Robin Murphy
2021-01-06 3:41 ` [RFC PATCH v3 6/6] of: Add plumbing for " Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 3:41 ` Claire Chang
2021-01-06 10:57 ` kernel test robot
2021-01-12 23:48 ` Florian Fainelli
2021-01-12 23:48 ` Florian Fainelli
2021-01-12 23:48 ` Florian Fainelli
2021-01-14 9:08 ` Claire Chang
2021-01-14 9:08 ` Claire Chang
2021-01-14 9:08 ` Claire Chang
2021-01-14 9:08 ` Claire Chang
2021-01-14 18:52 ` Florian Fainelli
2021-01-14 18:52 ` Florian Fainelli
2021-01-14 18:52 ` Florian Fainelli
2021-01-15 3:46 ` Claire Chang
2021-01-15 3:46 ` Claire Chang
2021-01-15 3:46 ` Claire Chang
2021-01-15 3:46 ` Claire Chang
2021-01-06 18:48 ` [RFC PATCH v3 0/6] Restricted DMA Florian Fainelli
2021-01-06 18:48 ` Florian Fainelli
2021-01-06 18:48 ` Florian Fainelli
2021-01-07 17:38 ` Claire Chang
2021-01-07 17:38 ` Claire Chang
2021-01-07 17:38 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:42 ` Claire Chang
2021-01-07 17:59 ` Florian Fainelli
2021-01-07 17:59 ` Florian Fainelli
2021-01-07 17:59 ` Florian Fainelli
2021-01-12 7:48 ` Claire Chang
2021-01-12 7:48 ` Claire Chang
2021-01-12 7:48 ` Claire Chang
2021-01-12 7:48 ` Claire Chang
2021-01-12 18:01 ` Florian Fainelli
2021-01-12 18:01 ` Florian Fainelli
2021-01-12 18:01 ` Florian Fainelli
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 2:29 ` Tomasz Figa
2021-01-13 3:56 ` Florian Fainelli
2021-01-13 3:56 ` Florian Fainelli
2021-01-13 3:56 ` Florian Fainelli
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:25 ` Tomasz Figa
2021-01-13 4:41 ` Florian Fainelli
2021-01-13 4:41 ` Florian Fainelli
2021-01-13 4:41 ` Florian Fainelli
2021-02-09 6:27 ` Claire Chang
2021-02-09 6:27 ` Claire Chang
2021-02-09 6:27 ` Claire Chang
2021-02-09 6:27 ` Claire Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b9b598c-5ccd-f897-a962-14c0ed7af6de@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bauerman@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bgolaszewski@baylibre.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=heikki.krogerus@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jgross@suse.com \
--cc=joro@8bytes.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=sstabellini@kernel.org \
--cc=tfiga@chromium.org \
--cc=tientzu@chromium.org \
--cc=treding@nvidia.com \
--cc=will@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.