Re: [PATCH] shim: don't let build modify shim.config

From: Juergen Gross <jgross@suse.com>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>,
	"Wei Liu" <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Julien Grall <julien.grall@arm.com>,
	Jan Beulich <JBeulich@suse.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] shim: don't let build modify shim.config
Date: Fri, 20 Apr 2018 11:47:33 +0200	[thread overview]
Message-ID: <7baa5487-cee0-10f4-1227-e9a7cd7225c3@suse.com> (raw)
In-Reply-To: <aed28c38-1ca3-6253-3f3a-86ab93e1477d@citrix.com>

[-- Attachment #1: Type: text/plain, Size: 2019 bytes --]

On 20/04/18 11:33, Andrew Cooper wrote:
> On 20/04/18 10:28, Roger Pau Monné wrote:
>> On Thu, Apr 19, 2018 at 05:22:28PM +0100, Wei Liu wrote:
>>> On Thu, Apr 19, 2018 at 05:14:38PM +0100, Andrew Cooper wrote:
>>>> On 19/04/18 15:54, Wei Liu wrote:
>>>>> On Thu, Apr 19, 2018 at 01:01:53PM +0200, Juergen Gross wrote:
>>>>>> On 19/04/18 12:47, Jan Beulich wrote:
>>>>>>>>>> On 19.04.18 at 12:30, <jgross@suse.com> wrote:
>>>>>>>> --- a/tools/firmware/xen-dir/Makefile
>>>>>>>> +++ b/tools/firmware/xen-dir/Makefile
>>>>>>>> @@ -41,21 +41,22 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
>>>>>>>>  $(D): linkfarm.stamp
>>>>>>>>  	$(MAKE) -C $(D)/xen distclean
>>>>>>>>  
>>>>>>>> -.PHONY: shim-%config
>>>>>>>> -shim-%config: $(D) FORCE
>>>>>>>> -	$(MAKE) -C $(D)/xen $*config \
>>>>>>> I think there was a reason for the % and $*.
>>>>>> The only one I could think of is the possibility to do
>>>>>>
>>>>>> make shim-defaultconfig
>>>>>>
>>>>>> or similar calls. Question is who will ever need that. In case it is
>>>>>> believed to be valuable I can keep it.
>>>>> Not likely I think.
>>>> Using `make shim-menuconfig` was a specific usecase for my original
>>>> version, but with this difference in representation, the usecase has
>>>> mostly gone away.
>>>>
>>>> With this change in place, what is the expected workflow for making an
>>>> update to the configuration?
>>>>
>>> Just commit the must-have's to the tracked file and let Xen's build
>>> system handle the rest?
>> +1. As a bare minimum:
>>
>> CONFIG_XEN_GUEST=y
>> CONFIG_PVH_GUEST=y
>> CONFIG_PV_SHIM=y
>> CONFIG_PV_SHIM_EXCLUSIVE=y
>>
>> But I expect some more might be needed.
> 
> CONFIG_SHADOW_PAGING=n
> CONFIG_NR_CPUS=32
> CONFIG_VIDEO=n
> CONFIG_HVM_FEP=n
> CONFIG_TBOOT=n
> CONFIG_KEXEC=n
> CONFIG_TMEM=n
> CONFIG_XENOPROF=n
> 
> Remember that shim also wants to be as much of a slimline build as possible

Attached is the minimal shim.config to be fed into "make olddefconfig"
resulting in the current config used for the shim.

Juergen

[-- Attachment #2: shim.config --]
[-- Type: application/x-config, Size: 482 bytes --]

[-- Attachment #3: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel