From: Juergen Gross <jgross@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] shim: don't let build modify shim.config
Date: Fri, 20 Apr 2018 08:40:13 +0200 [thread overview]
Message-ID: <8a73d86e-27ee-2d11-50ef-01070a9746ad@suse.com> (raw)
In-Reply-To: <d0111f15-f50a-3d58-b210-520c4fe85a90@citrix.com>
On 19/04/18 18:14, Andrew Cooper wrote:
> On 19/04/18 15:54, Wei Liu wrote:
>> On Thu, Apr 19, 2018 at 01:01:53PM +0200, Juergen Gross wrote:
>>> On 19/04/18 12:47, Jan Beulich wrote:
>>>>>>> On 19.04.18 at 12:30, <jgross@suse.com> wrote:
>>>>> --- a/tools/firmware/xen-dir/Makefile
>>>>> +++ b/tools/firmware/xen-dir/Makefile
>>>>> @@ -41,21 +41,22 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
>>>>> $(D): linkfarm.stamp
>>>>> $(MAKE) -C $(D)/xen distclean
>>>>>
>>>>> -.PHONY: shim-%config
>>>>> -shim-%config: $(D) FORCE
>>>>> - $(MAKE) -C $(D)/xen $*config \
>>>> I think there was a reason for the % and $*.
>>> The only one I could think of is the possibility to do
>>>
>>> make shim-defaultconfig
>>>
>>> or similar calls. Question is who will ever need that. In case it is
>>> believed to be valuable I can keep it.
>> Not likely I think.
>
> Using `make shim-menuconfig` was a specific usecase for my original
> version, but with this difference in representation, the usecase has
> mostly gone away.
>
> With this change in place, what is the expected workflow for making an
> update to the configuration?
You can still cd to tools/firmware/xen-dir/xen-root/xen and do the
"make menuconfig" there. Afterwards copy the resulting .config to
../../shim.config and you have the same result. Question is whether
you want to do that in case we are stripping down shim.config later.
Above assumes V2 of my patch will be taken, of course.
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2018-04-20 6:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 10:30 [PATCH] shim: don't let build modify shim.config Juergen Gross
2018-04-19 10:47 ` Jan Beulich
[not found] ` <5AD873C502000078001BCA14@suse.com>
2018-04-19 11:01 ` Juergen Gross
2018-04-19 14:54 ` Wei Liu
2018-04-19 16:14 ` Andrew Cooper
2018-04-19 16:22 ` Wei Liu
2018-04-20 9:28 ` Roger Pau Monné
2018-04-20 9:33 ` Andrew Cooper
2018-04-20 9:47 ` Juergen Gross
2018-04-20 6:40 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a73d86e-27ee-2d11-50ef-01070a9746ad@suse.com \
--to=jgross@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.