From: wangweiwei <wangww.fnst@cn.fujitsu.com>
To: Eric Blake <eblake@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Fam Zheng <famz@redhat.com>,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
qemu block <qemu-block@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Jeff Cody <jcody@redhat.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
qemu devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>,
Gonglei <arei.gonglei@huawei.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] block: modify top-id's comments
Date: Fri, 30 Sep 2016 16:30:24 +0800 [thread overview]
Message-ID: <7bb73307-effb-c9d6-b988-807b2b3a5633@cn.fujitsu.com> (raw)
In-Reply-To: <cd9164ce-0e8b-4b2a-f32e-36bee65934e4@redhat.com>
Ok, I'wll wrap it.
On 09/29/2016 09:35 PM, Eric Blake wrote:
> On 09/28/2016 05:31 AM, Stefan Hajnoczi wrote:
>> On Wed, Sep 28, 2016 at 01:30:39PM +0800, Wang WeiWei wrote:
>>
>> Please send a proper commit message and commit description. "modify
>> top-id's comments" says almost nothing and there is no commit
>> description. I don't know why you are making this change so I can't
>> review and apply it.
>>
>
>>> +++ b/qapi/block-core.json
>>> @@ -2184,7 +2184,7 @@
>>> # @mode: the replication mode
>>> #
>>> # @top-id: #optional In secondary mode, node name or device ID of the root
>>> -# node who owns the replication node chain. Ignored in primary mode.
>>> +# node who owns the replication node chain. Must not be given in primary mode.
>
> That, and your line exceeds 80 columns; please wrap it.
>
next prev parent reply other threads:[~2016-09-30 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 5:30 [Qemu-devel] [PATCH] block: modify top-id's comments Wang WeiWei
2016-09-28 9:03 ` Kevin Wolf
2016-09-28 10:31 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-09-29 13:35 ` Eric Blake
2016-09-30 8:30 ` wangweiwei [this message]
2016-09-30 8:53 [Qemu-devel] " Wang WeiWei
2016-09-30 9:48 ` [Qemu-devel] [Qemu-block] " Kashyap Chamarthy
2016-09-30 10:53 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bb73307-effb-c9d6-b988-807b2b3a5633@cn.fujitsu.com \
--to=wangww.fnst@cn.fujitsu.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=eddie.dong@intel.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.