[PATCH 1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add

[PATCH 1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add

[Dongliang Mu]

Smatch reports the following issue:
drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add()
warn: '&entry->list' not removed from list

Fix this by adding list_del in the error handling code.

Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
 drivers/staging/vme_user/vme_tsi148.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
index 020e0b3bce64..0171f46d1848 100644
--- a/drivers/staging/vme_user/vme_tsi148.c
+++ b/drivers/staging/vme_user/vme_tsi148.c
@@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
 	return 0;
 
 err_dma:
+	list_del(&entry->list);
 err_dest:
 err_source:
 err_align:
-- 
2.37.1 (Apple Git-137.1)

[PATCH 2/2] staging: vme_user: fix coding style

[Dongliang Mu]

Fix coding style enforced by Linux kernel

Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
---
 drivers/staging/vme_user/vme_tsi148.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
index 0171f46d1848..5ba097e4d17e 100644
--- a/drivers/staging/vme_user/vme_tsi148.c
+++ b/drivers/staging/vme_user/vme_tsi148.c
@@ -1755,7 +1755,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
 err_dest:
 err_source:
 err_align:
-		kfree(entry);
+	kfree(entry);
 err_mem:
 	return retval;
 }
-- 
2.37.1 (Apple Git-137.1)

Re: [PATCH 1/2] staging: vme_user: add list_del in the error handling of tsi148_dma_list_add

[Christophe JAILLET]

Le 26/11/2022 à 13:56, Dongliang Mu a écrit :
> Smatch reports the following issue:
> drivers/staging/vme_user/vme_tsi148.c:1757 tsi148_dma_list_add()
> warn: '&entry->list' not removed from list
> 

Hi,

Not tested with smatch, but I think that moving the list_add_tail() call 
just a few lines below, when all lights are green, would also fix the issue.

Just my 2c,

CJ


> Fix this by adding list_del in the error handling code.
> 
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
>   drivers/staging/vme_user/vme_tsi148.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
> index 020e0b3bce64..0171f46d1848 100644
> --- a/drivers/staging/vme_user/vme_tsi148.c
> +++ b/drivers/staging/vme_user/vme_tsi148.c
> @@ -1751,6 +1751,7 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
>   	return 0;
>   
>   err_dma:
> +	list_del(&entry->list);
>   err_dest:
>   err_source:
>   err_align:

Re: [PATCH 2/2] staging: vme_user: fix coding style

[Greg Kroah-Hartman]

On Sat, Nov 26, 2022 at 08:56:34PM +0800, Dongliang Mu wrote:
> Fix coding style enforced by Linux kernel

What coding style was changed?  Please always be specific.

thanks,

greg k-h

Re: [PATCH 2/2] staging: vme_user: fix coding style

[Dongliang Mu]

> On Dec 5, 2022, at 20:22, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> On Sat, Nov 26, 2022 at 08:56:34PM +0800, Dongliang Mu wrote:
>> Fix coding style enforced by Linux kernel
> 
> What coding style was changed?  Please always be specific.

The commit message is imprecise. Actually, this patch only fixes the code indentation issue of kfree function call.

Will fix it in v2.

> 
> thanks,
> 
> greg k-h