[PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 793 bytes --]

Add myself as maintainer for DW 8250 UART and up it to Supported.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a6d3bd9d2a8d..6c90484f395b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19230,8 +19230,9 @@ F:	Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
 F:	drivers/gpio/gpio-creg-snps.c
 
 SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:	Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
 R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-S:	Maintained
+S:	Supported
 F:	drivers/tty/serial/8250/8250_dw.c
 F:	drivers/tty/serial/8250/8250_dwlib.*
 F:	drivers/tty/serial/8250/8250_lpss.c

-- 
tg: (f2906aa86338..) dw/maintainer (depends on: tty-next)

Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Greg Kroah-Hartman]

On Fri, Jun 17, 2022 at 12:39:29PM +0300, Ilpo Järvinen wrote:
> Add myself as maintainer for DW 8250 UART and up it to Supported.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Obviously I need an ack from Andy too.  And thanks for doing this and
all the work you have already done so far, it's appreciated.

greg k-h

Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Andy Shevchenko]

On Fri, Jun 17, 2022 at 11:41 AM Ilpo Järvinen
<ilpo.jarvinen@linux.intel.com> wrote:
>
> Add myself as maintainer for DW 8250 UART and up it to Supported.

Thanks!

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> ---
>  MAINTAINERS | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a6d3bd9d2a8d..6c90484f395b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19230,8 +19230,9 @@ F:      Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
>  F:     drivers/gpio/gpio-creg-snps.c
>
>  SYNOPSYS DESIGNWARE 8250 UART DRIVER
> +M:     Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>  R:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> -S:     Maintained
> +S:     Supported
>  F:     drivers/tty/serial/8250/8250_dw.c
>  F:     drivers/tty/serial/8250/8250_dwlib.*
>  F:     drivers/tty/serial/8250/8250_lpss.c
>
> --
> tg: (f2906aa86338..) dw/maintainer (depends on: tty-next)



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Andy Shevchenko]

On Fri, Jun 17, 2022 at 11:45:00AM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 17, 2022 at 12:39:29PM +0300, Ilpo Järvinen wrote:
> > Add myself as maintainer for DW 8250 UART and up it to Supported.
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> 
> Obviously I need an ack from Andy too.

I just gave my Rb, but just in case
Acked-by: From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> And thanks for doing this and
> all the work you have already done so far, it's appreciated.

+1 and many, thanks, Ilpo!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[kernel test robot]

Hi "Ilpo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.19-rc2 next-20220617]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
reproduce: make htmldocs

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Joe Perches]

On Sat, 2022-06-18 at 04:09 +0800, kernel test robot wrote:
> Hi "Ilpo,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.19-rc2 next-20220617]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
> reproduce: make htmldocs
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> > > 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte

?

false positive?

Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Joe Perches]

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Sat, 2022-06-18 at 04:09 +0800, kernel test robot wrote:
> Hi "Ilpo,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on linus/master]
> [also build test ERROR on v5.19-rc2 next-20220617]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
> reproduce: make htmldocs
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> > > 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte

?

false positive?

Re: [kbuild-all] Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Chen, Rong A]

On 6/18/2022 4:17 AM, Joe Perches wrote:
> On Sat, 2022-06-18 at 04:09 +0800, kernel test robot wrote:
>> Hi "Ilpo,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v5.19-rc2 next-20220617]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:    https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
>> base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 47700948a4abb4a5ae13ef943ff682a7f327547a
>> reproduce: make htmldocs
>>
>> If you fix the issue, kindly add following tag where applicable
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>>> 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid continuation byte
> 
> ?
> 
> false positive?

Hi,

I tried to apply the patch, and I can reproduce the error by 'make 
htmldocs':

$ wget -q -O - 
https://lore.kernel.org/lkml/be58b398-71ff-7c12-1bf1-a09181d9c80@linux.intel.com/raw 
| git apply -v
$ git --no-pager diff
diff --git a/MAINTAINERS b/MAINTAINERS
index f52543aedd61e..3d64756814f09 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19247,8 +19247,9 @@ F: 
Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
  F:     drivers/gpio/gpio-creg-snps.c

  SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:     Ilpo Jrvinen <ilpo.jarvinen@linux.intel.com>
  R:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-S:     Maintained
+S:     Supported
  F:     drivers/tty/serial/8250/8250_dw.c
  F:     drivers/tty/serial/8250/8250_dwlib.*
  F:     drivers/tty/serial/8250/8250_lpss.c

It seems the special character 'ä' in name 'Ilpo Järvinen' was parsed 
wrongly.

Best Regards,
Rong Chen

Re: [kbuild-all] Re: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

[Ilpo Järvinen]

[-- Attachment #1: Type: text/plain, Size: 2853 bytes --]

On Mon, 20 Jun 2022, Chen, Rong A wrote:
> On 6/18/2022 4:17 AM, Joe Perches wrote:
> > On Sat, 2022-06-18 at 04:09 +0800, kernel test robot wrote:
> > > Hi "Ilpo,
> > > 
> > > Thank you for the patch! Yet something to improve:
> > > 
> > > [auto build test ERROR on linus/master]
> > > [also build test ERROR on v5.19-rc2 next-20220617]
> > > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > > And when submitting patch, we suggest to use '--base' as documented in
> > > https://git-scm.com/docs/git-format-patch]
> > > 
> > > url:
> > > https://github.com/intel-lab-lkp/linux/commits/Ilpo-J-rvinen/MAINTAINERS-Update-DW-8250-UART-maintainership/20220617-174145
> > > base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > > 47700948a4abb4a5ae13ef943ff682a7f327547a
> > > reproduce: make htmldocs
> > > 
> > > If you fix the issue, kindly add following tag where applicable
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > 
> > > All errors (new ones prefixed by >>):
> > > 
> > > > > 'utf-8' codec can't decode byte 0xe4 in position 1396: invalid
> > > > > continuation byte
> > 
> > ?
> > 
> > false positive?

This is correctly identified problem, however, the problem is lkp's end.
It seemingly fails to handle non-UTF8 encoded emails correctly and just 
goes to assume the input is UTF8 encoded (w/o checking the Content-Type 
header).

> I tried to apply the patch, and I can reproduce the error by 'make htmldocs':
> 
> $ wget -q -O -
> https://lore.kernel.org/lkml/be58b398-71ff-7c12-1bf1-a09181d9c80@linux.intel.com/raw
> | git apply -v
> $ git --no-pager diff
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f52543aedd61e..3d64756814f09 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -19247,8 +19247,9 @@ F:
> Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
>  F:     drivers/gpio/gpio-creg-snps.c
> 
>  SYNOPSYS DESIGNWARE 8250 UART DRIVER
> +M:     Ilpo Jrvinen <ilpo.jarvinen@linux.intel.com>
>  R:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> -S:     Maintained
> +S:     Supported
>  F:     drivers/tty/serial/8250/8250_dw.c
>  F:     drivers/tty/serial/8250/8250_dwlib.*
>  F:     drivers/tty/serial/8250/8250_lpss.c
> 
> It seems the special character 'ä' in name 'Ilpo Järvinen' was parsed wrongly.

The original file was UTF-8 (0xc3 0xa4). The email is correctly encoded 
ISO 8859-15 as can be see e.g. by downloading this (with a single 0xe4 
char):
  https://marc.info/?l=linux-kernel&m=165545870203513&q=raw

When saving patch/exporting email, MUA/exporter should do ISO 8859-15 -> 
UTF-8 conversion. If I export email I sent, I get it back to UTF-8 just 
fine (as per the locale I've in use).

Just in case, I've attached the original patch file.

I thought git's toolchain these days handles these things fine but 
it seems not.


-- 
 i.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-diff; NAME=maint.patch, Size: 944 bytes --]

From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH] MAINTAINERS: Update DW 8250 UART maintainership

Add myself as maintainer for DW 8250 UART and up it to Supported.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index a6d3bd9d2a8d..6c90484f395b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19230,8 +19230,9 @@ F:	Documentation/devicetree/bindings/gpio/snps,creg-gpio.txt
 F:	drivers/gpio/gpio-creg-snps.c
 
 SYNOPSYS DESIGNWARE 8250 UART DRIVER
+M:	Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
 R:	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
-S:	Maintained
+S:	Supported
 F:	drivers/tty/serial/8250/8250_dw.c
 F:	drivers/tty/serial/8250/8250_dwlib.*
 F:	drivers/tty/serial/8250/8250_lpss.c

-- 
tg: (65534736d9a5..) dw/maintainer (depends on: tty-next)