[PATCH 1/9][KERNEL] meta/emenlow: use usb features

[PATCH 1/9][KERNEL] meta/emenlow: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available usb features and remove the associated config
settings from the top-level feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg |    7 +------
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc |    4 ++++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg
index b1e72bd..5090862 100644
--- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg
+++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg
@@ -1,7 +1,7 @@
 CONFIG_X86_32=y
 CONFIG_PRINTK=y
 
-# Basic hardware support for the box - network, USB, PCI, sound
+# Basic hardware support for the box - network, PCI, sound
 CONFIG_NETDEVICES=y
 CONFIG_ATA=y
 CONFIG_ATA_GENERIC=y
@@ -9,16 +9,11 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
-CONFIG_USB_UHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
index 0b4daca..be70731 100644
--- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
+++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
@@ -13,3 +13,7 @@ include features/logbuf/size-normal.scc
 
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
+
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 2/9][KERNEL] meta/fishriver: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available usb features and remove the associated config
settings from the top-level feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg |    8 +-------
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc |    4 ++++
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg
index b101419..d0f6fdd 100644
--- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg
+++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg
@@ -2,7 +2,7 @@ CONFIG_X86_32=y
 CONFIG_MATOM=y
 CONFIG_PRINTK=y
 
-# Basic hardware support for the box - network, USB, PCI, sound
+# Basic hardware support for the box - network, PCI, sound
 CONFIG_NETDEVICES=y
 CONFIG_ATA=y
 CONFIG_ATA_GENERIC=y
@@ -10,17 +10,11 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
-CONFIG_USB_UHCI_HCD=y
-CONFIG_USB_OHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
index 8e788f6..6b4945a 100644
--- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
+++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
@@ -16,3 +16,7 @@ include features/logbuf/size-normal.scc
 
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
+
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 3/9][KERNEL] meta/jasperforest: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available usb features and remove the associated config
settings from the top-level feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    7 +------
 .../kernel-cache/bsp/jasperforest/jasperforest.scc |    4 ++++
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
index 743fc7d..0a81a19 100644
--- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
+++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
@@ -1,6 +1,6 @@
 CONFIG_PRINTK=y
 
-# Basic hardware support for the box - network, USB, PCI, sound
+# Basic hardware support for the box - network, PCI, sound
 CONFIG_NETDEVICES=y
 CONFIG_ATA=y
 CONFIG_ATA_GENERIC=y
@@ -8,16 +8,11 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
-CONFIG_USB_UHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
index 89df366..82f0f52 100644
--- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
+++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.scc
@@ -9,3 +9,7 @@ include features/logbuf/size-normal.scc
 
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
+
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 4/9][KERNEL] meta/sugarbay: use usb features

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

Use the available usb features and remove the associated config
settings from the top-level feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg |    7 +------
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc |    3 +++
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg
index 58c6493..be5d3dd 100644
--- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg
+++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg
@@ -1,6 +1,6 @@
 CONFIG_PRINTK=y
 
-# Basic hardware support for the box - network, USB, PCI, sound
+# Basic hardware support for the box - network, PCI, sound
 CONFIG_NETDEVICES=y
 CONFIG_ATA=y
 CONFIG_ATA_GENERIC=y
@@ -8,16 +8,11 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
-CONFIG_USB_UHCI_HCD=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y
 CONFIG_SOUND=y
diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
index dc107c3..128efd3 100644
--- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
+++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc
@@ -10,3 +10,6 @@ include features/logbuf/size-normal.scc
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
 
+include features/usb/ehci-hcd.scc
+include features/usb/ohci-hcd.scc
+include features/usb/uhci-hcd.scc
-- 
1.7.0.4

[PATCH 5/9][KERNEL] meta/jasperforest: remove boot-live options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

The boot-live options are already included via common-pc-64 so remove
the associated config settings from the top-level feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
index 0a81a19..e2310a5 100644
--- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
+++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
@@ -34,13 +34,6 @@ CONFIG_PM=y
 CONFIG_ACPI=y
 CONFIG_INPUT=y
 
-# Needed for booting (and using) USB memory sticks
-CONFIG_BLK_DEV_LOOP=y
-CONFIG_NLS_CODEPAGE_437=y
-CONFIG_NLS_ISO8859_1=y
-
-CONFIG_RD_GZIP=y
-
 # NUMA support
 CONFIG_NUMA=y
 CONFIG_X86_64_ACPI_NUMA=y
-- 
1.7.0.4

[PATCH 0/9][KERNEL] meta-intel updates

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

More updates for meta-intel 1.2.

Please pull into linux-yocto 3.2.

The following changes since commit 6b3d4e09aa2531e9649f3f03827b7efbccfcec03:
  Tom Zanussi (1):
        meta: add mei feature

are available in the git repository at:

  git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/1.2-updates-2
  http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/1.2-updates-2

Tom Zanussi (9):
  meta/emenlow: use usb features
  meta/fishriver: use usb features
  meta/jasperforest: use usb features
  meta/sugarbay: use usb features
  meta/jasperforest: remove boot-live options
  meta/sugarbay: remove boot-live options
  meta/crownbay: move smp options from recipe-space
  meta/emenlow: move smp options from recipe-space
  meta/fishriver: move smp options from recipe-space

 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    1 +
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg      |    7 +------
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    5 +++++
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg  |    8 +-------
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    5 +++++
 .../kernel-cache/bsp/jasperforest/jasperforest.cfg |   14 +-------------
 .../kernel-cache/bsp/jasperforest/jasperforest.scc |    4 ++++
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg    |   14 +-------------
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    3 +++
 9 files changed, 22 insertions(+), 39 deletions(-)

[PATCH 6/9][KERNEL] meta/sugarbay: remove boot-live options

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

The boot-live options are already included via common-pc-64 so remove
the associated config settings from the top-level feature.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg
index be5d3dd..1b370ba 100644
--- a/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg
+++ b/meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg
@@ -33,10 +33,3 @@ CONFIG_AGP=y
 CONFIG_PM=y
 CONFIG_ACPI=y
 CONFIG_INPUT=y
-
-# Needed for booting (and using) USB memory sticks
-CONFIG_BLK_DEV_LOOP=y
-CONFIG_NLS_CODEPAGE_437=y
-CONFIG_NLS_ISO8859_1=y
-
-CONFIG_RD_GZIP=y
-- 
1.7.0.4

[PATCH 7/9][KERNEL] meta/crownbay: move smp options from recipe-space

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

SMP support was configured in recipe-space, remove it from
recipe-space and move it here.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
index d4299a9..c4bc1a5 100644
--- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
+++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc
@@ -10,6 +10,7 @@ include features/hpet/hpet.scc
 include cfg/vesafb.scc
 include cfg/usb-mass-storage.scc
 include cfg/boot-live.scc
+include cfg/smp.scc
 include features/power/intel.scc
 
 include features/logbuf/size-normal.scc
-- 
1.7.0.4

[PATCH 8/9][KERNEL] meta/emenlow: move smp options from recipe-space

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

SMP support was configured in recipe-space, remove it from
recipe-space and move it here.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
index be70731..2967d93 100644
--- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
+++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc
@@ -8,6 +8,7 @@ include features/serial/8250.scc
 include cfg/vesafb.scc
 include cfg/usb-mass-storage.scc
 include cfg/boot-live.scc
+include cfg/smp.scc
 
 include features/logbuf/size-normal.scc
 
-- 
1.7.0.4

[PATCH 9/9][KERNEL] meta/fishriver: move smp options from recipe-space

[tom.zanussi]

From: Tom Zanussi <tom.zanussi@intel.com>

SMP support was configured in recipe-space, remove it from
recipe-space and move it here.

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
---
 meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
index 6b4945a..e401274 100644
--- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
+++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc
@@ -10,6 +10,7 @@ include features/ericsson-3g/f5521gw.scc
 include cfg/vesafb.scc
 include cfg/usb-mass-storage.scc
 include cfg/boot-live.scc
+include cfg/smp.scc
 include features/power/intel.scc
 
 include features/logbuf/size-normal.scc
-- 
1.7.0.4

Re: [PATCH 0/9][KERNEL] meta-intel updates

[Bruce Ashfield]

On 12-05-08 5:37 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi<tom.zanussi@intel.com>
>
> More updates for meta-intel 1.2.
>
> Please pull into linux-yocto 3.2.

merged and pushed out. I'll send the main recipe updates as part of
my next pull request, but they are available for you to use now.

Bruce

>
> The following changes since commit 6b3d4e09aa2531e9649f3f03827b7efbccfcec03:
>    Tom Zanussi (1):
>          meta: add mei feature
>
> are available in the git repository at:
>
>    git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/1.2-updates-2
>    http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-2.6.37-contrib/log/?h=tzanussi/1.2-updates-2
>
> Tom Zanussi (9):
>    meta/emenlow: use usb features
>    meta/fishriver: use usb features
>    meta/jasperforest: use usb features
>    meta/sugarbay: use usb features
>    meta/jasperforest: remove boot-live options
>    meta/sugarbay: remove boot-live options
>    meta/crownbay: move smp options from recipe-space
>    meta/emenlow: move smp options from recipe-space
>    meta/fishriver: move smp options from recipe-space
>
>   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    1 +
>   meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg      |    7 +------
>   meta/cfg/kernel-cache/bsp/emenlow/emenlow.scc      |    5 +++++
>   meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg  |    8 +-------
>   meta/cfg/kernel-cache/bsp/fishriver/fishriver.scc  |    5 +++++
>   .../kernel-cache/bsp/jasperforest/jasperforest.cfg |   14 +-------------
>   .../kernel-cache/bsp/jasperforest/jasperforest.scc |    4 ++++
>   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.cfg    |   14 +-------------
>   meta/cfg/kernel-cache/bsp/sugarbay/sugarbay.scc    |    3 +++
>   9 files changed, 22 insertions(+), 39 deletions(-)
>

Re: [PATCH 5/9][KERNEL] meta/jasperforest: remove boot-live options

[Darren Hart]

On 05/08/2012 02:37 PM, tom.zanussi@intel.com wrote:
> From: Tom Zanussi <tom.zanussi@intel.com>
> 
> The boot-live options are already included via common-pc-64 so remove
> the associated config settings from the top-level feature.

The appropriate place for these in my opinion is in BSP-standard.scc and
BSP-preempt_rt.scc. That would be the common-pc-64-standard.scc for
example in this case.

This should not be part of a machine config fragment as it is more of a
ktype policy item than it is a bsp item. I expect "standard" kernels to
be able to do live boot, but "tiny" images should not.

Note that usb-mass-storage.scc should also be added to the standard and
preempt-rt scc files per BSP. I've done the former and am currently
working through the latter with my BSPs.

--
Darren

> 
> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> ---
>  .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> index 0a81a19..e2310a5 100644
> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> @@ -34,13 +34,6 @@ CONFIG_PM=y
>  CONFIG_ACPI=y
>  CONFIG_INPUT=y
>  
> -# Needed for booting (and using) USB memory sticks
> -CONFIG_BLK_DEV_LOOP=y
> -CONFIG_NLS_CODEPAGE_437=y
> -CONFIG_NLS_ISO8859_1=y
> -
> -CONFIG_RD_GZIP=y
> -
>  # NUMA support
>  CONFIG_NUMA=y
>  CONFIG_X86_64_ACPI_NUMA=y

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 5/9][KERNEL] meta/jasperforest: remove boot-live options

[Tom Zanussi]

On Wed, 2012-05-09 at 11:14 -0700, Darren Hart wrote:
> 
> On 05/08/2012 02:37 PM, tom.zanussi@intel.com wrote:
> > From: Tom Zanussi <tom.zanussi@intel.com>
> > 
> > The boot-live options are already included via common-pc-64 so remove
> > the associated config settings from the top-level feature.
> 
> The appropriate place for these in my opinion is in BSP-standard.scc and
> BSP-preempt_rt.scc. That would be the common-pc-64-standard.scc for
> example in this case.
> 
> This should not be part of a machine config fragment as it is more of a
> ktype policy item than it is a bsp item. I expect "standard" kernels to
> be able to do live boot, but "tiny" images should not.
> 

Right, this patch does actually remove it from the machine fragment for
the BSP, but I take your point - I was noticing when adding the usb
features that there are plenty of opportunities for cleanup of the
common-pc-* fragments, and it probably does make sense to add
'policy'-related features to the -standard/preempt-rt containers in
general, though not just for 'tiny' since I doubt anyone would ever want
a 'tiny' jasperforest BSP.

So, agreed in principal, but that's a separate task from this patchset.

Tom 

> Note that usb-mass-storage.scc should also be added to the standard and
> preempt-rt scc files per BSP. I've done the former and am currently
> working through the latter with my BSPs.
> 
> --
> Darren
> 
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> > ---
> >  .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    7 -------
> >  1 files changed, 0 insertions(+), 7 deletions(-)
> > 
> > diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> > index 0a81a19..e2310a5 100644
> > --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> > +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> > @@ -34,13 +34,6 @@ CONFIG_PM=y
> >  CONFIG_ACPI=y
> >  CONFIG_INPUT=y
> >  
> > -# Needed for booting (and using) USB memory sticks
> > -CONFIG_BLK_DEV_LOOP=y
> > -CONFIG_NLS_CODEPAGE_437=y
> > -CONFIG_NLS_ISO8859_1=y
> > -
> > -CONFIG_RD_GZIP=y
> > -
> >  # NUMA support
> >  CONFIG_NUMA=y
> >  CONFIG_X86_64_ACPI_NUMA=y
> 

Re: [PATCH 5/9][KERNEL] meta/jasperforest: remove boot-live options

[Darren Hart]

On 05/09/2012 11:50 AM, Tom Zanussi wrote:
> On Wed, 2012-05-09 at 11:14 -0700, Darren Hart wrote:
>>
>> On 05/08/2012 02:37 PM, tom.zanussi@intel.com wrote:
>>> From: Tom Zanussi <tom.zanussi@intel.com>
>>>
>>> The boot-live options are already included via common-pc-64 so remove
>>> the associated config settings from the top-level feature.
>>
>> The appropriate place for these in my opinion is in BSP-standard.scc and
>> BSP-preempt_rt.scc. That would be the common-pc-64-standard.scc for
>> example in this case.
>>
>> This should not be part of a machine config fragment as it is more of a
>> ktype policy item than it is a bsp item. I expect "standard" kernels to
>> be able to do live boot, but "tiny" images should not.
>>
> 
> Right, this patch does actually remove it from the machine fragment for
> the BSP, but I take your point - I was noticing when adding the usb
> features that there are plenty of opportunities for cleanup of the
> common-pc-* fragments, and it probably does make sense to add
> 'policy'-related features to the -standard/preempt-rt containers in
> general, though not just for 'tiny' since I doubt anyone would ever want
> a 'tiny' jasperforest BSP.
> 

Right, tiny was just an example.

> So, agreed in principal, but that's a separate task from this patchset.

That's fine. I can do it as well when I update the others. Nice to do
general changes like that at once so the BSPs remain consistent.

--
Darren

> 
> Tom 
> 
>> Note that usb-mass-storage.scc should also be added to the standard and
>> preempt-rt scc files per BSP. I've done the former and am currently
>> working through the latter with my BSPs.
>>
>> --
>> Darren
>>
>>>
>>> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
>>> ---
>>>  .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    7 -------
>>>  1 files changed, 0 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
>>> index 0a81a19..e2310a5 100644
>>> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
>>> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
>>> @@ -34,13 +34,6 @@ CONFIG_PM=y
>>>  CONFIG_ACPI=y
>>>  CONFIG_INPUT=y
>>>  
>>> -# Needed for booting (and using) USB memory sticks
>>> -CONFIG_BLK_DEV_LOOP=y
>>> -CONFIG_NLS_CODEPAGE_437=y
>>> -CONFIG_NLS_ISO8859_1=y
>>> -
>>> -CONFIG_RD_GZIP=y
>>> -
>>>  # NUMA support
>>>  CONFIG_NUMA=y
>>>  CONFIG_X86_64_ACPI_NUMA=y
>>
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 5/9][KERNEL] meta/jasperforest: remove boot-live options

[Tom Zanussi]

On Wed, 2012-05-09 at 12:11 -0700, Darren Hart wrote:
> 
> On 05/09/2012 11:50 AM, Tom Zanussi wrote:
> > On Wed, 2012-05-09 at 11:14 -0700, Darren Hart wrote:
> >>
> >> On 05/08/2012 02:37 PM, tom.zanussi@intel.com wrote:
> >>> From: Tom Zanussi <tom.zanussi@intel.com>
> >>>
> >>> The boot-live options are already included via common-pc-64 so remove
> >>> the associated config settings from the top-level feature.
> >>
> >> The appropriate place for these in my opinion is in BSP-standard.scc and
> >> BSP-preempt_rt.scc. That would be the common-pc-64-standard.scc for
> >> example in this case.
> >>
> >> This should not be part of a machine config fragment as it is more of a
> >> ktype policy item than it is a bsp item. I expect "standard" kernels to
> >> be able to do live boot, but "tiny" images should not.
> >>
> > 
> > Right, this patch does actually remove it from the machine fragment for
> > the BSP, but I take your point - I was noticing when adding the usb
> > features that there are plenty of opportunities for cleanup of the
> > common-pc-* fragments, and it probably does make sense to add
> > 'policy'-related features to the -standard/preempt-rt containers in
> > general, though not just for 'tiny' since I doubt anyone would ever want
> > a 'tiny' jasperforest BSP.
> > 
> 
> Right, tiny was just an example.
> 
> > So, agreed in principal, but that's a separate task from this patchset.
> 
> That's fine. I can do it as well when I update the others. Nice to do
> general changes like that at once so the BSPs remain consistent.
> 

I don't mind doing this, but once I'm done with current tasks - it's
simple to do, but it does require some amount of care and testing since
any breakage there will cause a lot more screaming...

Tom

> --
> Darren
> 
> > 
> > Tom 
> > 
> >> Note that usb-mass-storage.scc should also be added to the standard and
> >> preempt-rt scc files per BSP. I've done the former and am currently
> >> working through the latter with my BSPs.
> >>
> >> --
> >> Darren
> >>
> >>>
> >>> Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
> >>> ---
> >>>  .../kernel-cache/bsp/jasperforest/jasperforest.cfg |    7 -------
> >>>  1 files changed, 0 insertions(+), 7 deletions(-)
> >>>
> >>> diff --git a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> >>> index 0a81a19..e2310a5 100644
> >>> --- a/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> >>> +++ b/meta/cfg/kernel-cache/bsp/jasperforest/jasperforest.cfg
> >>> @@ -34,13 +34,6 @@ CONFIG_PM=y
> >>>  CONFIG_ACPI=y
> >>>  CONFIG_INPUT=y
> >>>  
> >>> -# Needed for booting (and using) USB memory sticks
> >>> -CONFIG_BLK_DEV_LOOP=y
> >>> -CONFIG_NLS_CODEPAGE_437=y
> >>> -CONFIG_NLS_ISO8859_1=y
> >>> -
> >>> -CONFIG_RD_GZIP=y
> >>> -
> >>>  # NUMA support
> >>>  CONFIG_NUMA=y
> >>>  CONFIG_X86_64_ACPI_NUMA=y
> >>
> > 
> > 
>