* [PATCH] target/unicore32/translate: Add missing fallthrough annotations
@ 2020-10-30 9:31 Thomas Huth
2020-10-30 18:43 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2020-10-30 9:31 UTC (permalink / raw)
To: qemu-devel, Guan Xuetao; +Cc: qemu-trivial, Richard Henderson
Looking at the way the code is formatted here (there is an empty
line after break statements, but none where the break is missing),
the fallthrough is very likely intended here. So add a fallthrough
comment to make the it compilable with -Werror=implicit-fallthrough.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/unicore32/translate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/target/unicore32/translate.c b/target/unicore32/translate.c
index d4b06df672..962f9877a0 100644
--- a/target/unicore32/translate.c
+++ b/target/unicore32/translate.c
@@ -1801,6 +1801,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
do_misc(env, s, insn);
break;
}
+ /* fallthrough */
case 0x1:
if (((UCOP_OPCODES >> 2) == 2) && !UCOP_SET_S) {
do_misc(env, s, insn);
@@ -1817,6 +1818,7 @@ static void disas_uc32_insn(CPUUniCore32State *env, DisasContext *s)
if (UCOP_SET(8) || UCOP_SET(5)) {
ILLEGAL;
}
+ /* fallthrough */
case 0x3:
do_ldst_ir(env, s, insn);
break;
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] target/unicore32/translate: Add missing fallthrough annotations
2020-10-30 9:31 [PATCH] target/unicore32/translate: Add missing fallthrough annotations Thomas Huth
@ 2020-10-30 18:43 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2020-10-30 18:43 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Guan Xuetao; +Cc: qemu-trivial
On 10/30/20 2:31 AM, Thomas Huth wrote:
> Looking at the way the code is formatted here (there is an empty
> line after break statements, but none where the break is missing),
> the fallthrough is very likely intended here. So add a fallthrough
> comment to make the it compilable with -Werror=implicit-fallthrough.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> target/unicore32/translate.c | 2 ++
> 1 file changed, 2 insertions(+)
We don't need to guess based on blank lines.
This matches with the instruction set overview at
https://en.wikipedia.org/wiki/Unicore
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-30 18:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 9:31 [PATCH] target/unicore32/translate: Add missing fallthrough annotations Thomas Huth
2020-10-30 18:43 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.