All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jun Nie <niej0001@gmail.com>
To: Eric Miao <eric.y.miao@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] pxa: fix pxa168 lcd controller vsync/hsync timing  error
Date: Thu, 5 Nov 2009 10:15:32 +0800	[thread overview]
Message-ID: <7c34ac520911041815k6555e209r4039ae9f97c9ebca@mail.gmail.com> (raw)
In-Reply-To: <f17812d70911032320k379dc7laab1979a3b452969@mail.gmail.com>

2009/11/4 Eric Miao <eric.y.miao@gmail.com>:
> On Tue, Nov 3, 2009 at 2:45 PM, Jun Nie <niej0001@gmail.com> wrote:
>> pxa: fix pxa168 lcd controller vsync/hsync timing error
>>
>> Signed-off-by: Jun Nie <njun@marvell.com>
>> ---
>>  drivers/video/pxa168fb.c |    4 ++--
>>  include/video/pxa168fb.h |    2 --
>>  2 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
>> index 2ba1444..bdd524c 100644
>> --- a/drivers/video/pxa168fb.c
>> +++ b/drivers/video/pxa168fb.c
>> @@ -459,8 +459,8 @@ static void set_dumb_panel_control(struct fb_info *info)
>>        x |= mi->invert_composite_blank ? 0x00000040 : 0;
>>        x |= (info->var.sync & FB_SYNC_COMP_HIGH_ACT) ? 0x00000020 : 0;
>>        x |= mi->invert_pix_val_ena ? 0x00000010 : 0;
>> -       x |= (info->var.sync & FB_SYNC_VERT_HIGH_ACT) ? 0 : 0x00000008;
>> -       x |= (info->var.sync & FB_SYNC_HOR_HIGH_ACT) ? 0 : 0x00000004;
>> +       x |= (info->var.sync & FB_SYNC_VERT_HIGH_ACT) ? 0x00000008 : 0;
>> +       x |= (info->var.sync & FB_SYNC_HOR_HIGH_ACT) ? 0x00000004 : 0;
>
> Hi Jun,
>
> Could you please help double check this? My understanding is
> FB_SYNC_VERT_HIGH_ACT means it's a positive pulse covering all the
> valid HSYNCs, and a rising edge of VSYNC means a start of the frame.
>
> However, CFG_INV_VSYNC is '1' means the opposite.
>

My understanding is that high active means high level trigger new
frame/line. Below page support my point if it is not wrong.

http://www.arcadecollecting.com/info/Sync_fixing.txt

Jun

WARNING: multiple messages have this Message-ID (diff)
From: niej0001@gmail.com (Jun Nie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] pxa: fix pxa168 lcd controller vsync/hsync timing error
Date: Thu, 5 Nov 2009 10:15:32 +0800	[thread overview]
Message-ID: <7c34ac520911041815k6555e209r4039ae9f97c9ebca@mail.gmail.com> (raw)
In-Reply-To: <f17812d70911032320k379dc7laab1979a3b452969@mail.gmail.com>

2009/11/4 Eric Miao <eric.y.miao@gmail.com>:
> On Tue, Nov 3, 2009 at 2:45 PM, Jun Nie <niej0001@gmail.com> wrote:
>> pxa: fix pxa168 lcd controller vsync/hsync timing error
>>
>> Signed-off-by: Jun Nie <njun@marvell.com>
>> ---
>> ?drivers/video/pxa168fb.c | ? ?4 ++--
>> ?include/video/pxa168fb.h | ? ?2 --
>> ?2 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/pxa168fb.c b/drivers/video/pxa168fb.c
>> index 2ba1444..bdd524c 100644
>> --- a/drivers/video/pxa168fb.c
>> +++ b/drivers/video/pxa168fb.c
>> @@ -459,8 +459,8 @@ static void set_dumb_panel_control(struct fb_info *info)
>> ? ? ? ?x |= mi->invert_composite_blank ? 0x00000040 : 0;
>> ? ? ? ?x |= (info->var.sync & FB_SYNC_COMP_HIGH_ACT) ? 0x00000020 : 0;
>> ? ? ? ?x |= mi->invert_pix_val_ena ? 0x00000010 : 0;
>> - ? ? ? x |= (info->var.sync & FB_SYNC_VERT_HIGH_ACT) ? 0 : 0x00000008;
>> - ? ? ? x |= (info->var.sync & FB_SYNC_HOR_HIGH_ACT) ? 0 : 0x00000004;
>> + ? ? ? x |= (info->var.sync & FB_SYNC_VERT_HIGH_ACT) ? 0x00000008 : 0;
>> + ? ? ? x |= (info->var.sync & FB_SYNC_HOR_HIGH_ACT) ? 0x00000004 : 0;
>
> Hi Jun,
>
> Could you please help double check this? My understanding is
> FB_SYNC_VERT_HIGH_ACT means it's a positive pulse covering all the
> valid HSYNCs, and a rising edge of VSYNC means a start of the frame.
>
> However, CFG_INV_VSYNC is '1' means the opposite.
>

My understanding is that high active means high level trigger new
frame/line. Below page support my point if it is not wrong.

http://www.arcadecollecting.com/info/Sync_fixing.txt

Jun

  reply	other threads:[~2009-11-05  2:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-03  6:45 [PATCH 3/6] pxa: fix pxa168 lcd controller vsync/hsync timing error Jun Nie
2009-11-03  6:45 ` Jun Nie
2009-11-03  7:29 ` Jun Nie
2009-11-03  7:29   ` Jun Nie
2009-11-04  7:20 ` Eric Miao
2009-11-04  7:20   ` Eric Miao
2009-11-05  2:15   ` Jun Nie [this message]
2009-11-05  2:15     ` Jun Nie
2009-11-09  3:39     ` Eric Miao
2009-11-09  3:39       ` Eric Miao
2009-11-10  5:18       ` Jun Nie
2009-11-10  5:18         ` Jun Nie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c34ac520911041815k6555e209r4039ae9f97c9ebca@mail.gmail.com \
    --to=niej0001@gmail.com \
    --cc=eric.y.miao@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.