Re: [PATCH v15 02/13] PCI: kirin: Add support for a PHY layer

From: Kishon Vijay Abraham I <kishon@ti.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: "Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	linuxarm@huawei.com, mauro.chehab@huawei.com,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Binghui Wang" <wangbinghui@hisilicon.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Rob Herring" <robh@kernel.org>,
	"Xiaowei Song" <songxiaowei@hisilicon.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v15 02/13] PCI: kirin: Add support for a PHY layer
Date: Mon, 25 Oct 2021 14:26:41 +0530	[thread overview]
Message-ID: <7c3848c4-afd7-8a97-d782-68dc38b81f28@ti.com> (raw)
In-Reply-To: <20211025095254.522c1da6@sal.lan>

Hi Mauro,

On 25/10/21 2:22 pm, Mauro Carvalho Chehab wrote:
> Hi Kishon,
> 
> Em Mon, 25 Oct 2021 13:44:57 +0530
> Kishon Vijay Abraham I <kishon@ti.com> escreveu:
> 
>> Hi Mauro,
> 
>>> +
>>> +static const struct of_device_id kirin_pcie_match[] = {
>>> +	{
>>> +		.compatible = "hisilicon,kirin960-pcie",
>>> +		.data = (void *)PCIE_KIRIN_INTERNAL_PHY
>>> +	},  
>>
>> Where is PCIE_KIRIN_EXTERNAL_PHY used?
> 
> See:
> 	[PATCH v15 06/13] PCI: kirin: Add Kirin 970 compatible
> 
> 	https://lore.kernel.org/all/ac8c730c0300b90d96bdaaf387d458d8949241a9.1634812676.git.mchehab+huawei@kernel.org/
> 
> Basically, Kirin 970 (and any other devices that would use the same
> driver) should also use PCIE_KIRIN_EXTERNAL_PHY and place the PHY 
> driver inside drivers/phy, instead of hardcoding it at the driver.
> 
> The Kirin 970 PHY driver was already merged at linux-next:
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/phy/hisilicon/phy-hi3670-pcie.c

Thanks for clarifying.

Reviewed-by: Kishon Vijay Abraham I <kishon@ti.com>

Regards,
Kishon