From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>, <airlied@linux.ie>, <bjorn.andersson@linaro.org>, <daniel@ffwll.ch>, <dmitry.baryshkov@linaro.org>, <robdclark@gmail.com>, <sean@poorly.run>, <vkoul@kernel.org> Cc: <quic_abhinavk@quicinc.com>, <aravindh@codeaurora.org>, <freedreno@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>, <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Kuogee Hsieh <khsieh@codeaurora.org> Subject: Re: [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received Date: Fri, 3 Dec 2021 14:53:59 -0800 [thread overview] Message-ID: <7c686adc-4288-f29a-c82a-5decab8db703@quicinc.com> (raw) In-Reply-To: <CAE-0n51-=qTWfBVPFEmpEb7md6cg5O__bhydXTUb+=8dRqCuqg@mail.gmail.com> On 12/2/2021 6:41 PM, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-11-09 13:38:13) >> From: Kuogee Hsieh <khsieh@codeaurora.org> >> >> Current DP drivers have regulators, clocks, irq and phy are grouped >> together within a function and executed not in a symmetric manner. >> This increase difficulty of code maintenance and limited code scalability. >> This patch divided the driver life cycle of operation into four states, >> resume (including booting up), dongle plugin, dongle unplugged and suspend. >> Regulators, core clocks and irq are grouped together and enabled at resume >> (or booting up) so that the DP controller is armed and ready to receive HPD >> plugin interrupts. HPD plugin interrupt is generated when a dongle plugs >> into DUT (device under test). Once HPD plugin interrupt is received, DP >> controller will initialize phy so that dpcd read/write will function and >> following link training can be proceeded successfully. DP phy will be >> disabled after main link is teared down at end of unplugged HPD interrupt >> handle triggered by dongle unplugged out of DUT. Finally regulators, code >> clocks and irq are disabled at corresponding suspension. >> >> Changes in V2: >> -- removed unnecessary dp_ctrl NULL check >> -- removed unnecessary phy init_count and power_count DRM_DEBUG_DP logs >> -- remove flip parameter out of dp_ctrl_irq_enable() >> -- add fixes tag >> >> Changes in V3: >> -- call dp_display_host_phy_init() instead of dp_ctrl_phy_init() at >> dp_display_host_init() for eDP >> >> Changes in V4: >> -- rewording commit text to match this commit changes >> >> Fixes: e91e3065a806 ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") >> >> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> >> --- > Can you please resend this based on the msm-next branch[1]? It doesn't > apply now that other patches have been applied. > > [1] https://gitlab.freedesktop.org/drm/msm.git msm-next Stephen, below patches missed at msm-next branch. Are there merged soon? 1) WIP: drm/msm/dp: Detect the connector type based on reg property 2) WIP: handle no-hpd property in DP driver >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 87 ++++++++++++++++--------------------- >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 9 ++-- >> drivers/gpu/drm/msm/dp/dp_display.c | 83 ++++++++++++++++++++++++++--------- >> 3 files changed, 105 insertions(+), 74 deletions(-) >>
WARNING: multiple messages have this Message-ID (diff)
From: Kuogee Hsieh <quic_khsieh@quicinc.com> To: Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>, <airlied@linux.ie>, <bjorn.andersson@linaro.org>, <daniel@ffwll.ch>, <dmitry.baryshkov@linaro.org>, <robdclark@gmail.com>, <sean@poorly.run>, <vkoul@kernel.org> Cc: linux-arm-msm@vger.kernel.org, quic_abhinavk@quicinc.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kuogee Hsieh <khsieh@codeaurora.org>, aravindh@codeaurora.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received Date: Fri, 3 Dec 2021 14:53:59 -0800 [thread overview] Message-ID: <7c686adc-4288-f29a-c82a-5decab8db703@quicinc.com> (raw) In-Reply-To: <CAE-0n51-=qTWfBVPFEmpEb7md6cg5O__bhydXTUb+=8dRqCuqg@mail.gmail.com> On 12/2/2021 6:41 PM, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-11-09 13:38:13) >> From: Kuogee Hsieh <khsieh@codeaurora.org> >> >> Current DP drivers have regulators, clocks, irq and phy are grouped >> together within a function and executed not in a symmetric manner. >> This increase difficulty of code maintenance and limited code scalability. >> This patch divided the driver life cycle of operation into four states, >> resume (including booting up), dongle plugin, dongle unplugged and suspend. >> Regulators, core clocks and irq are grouped together and enabled at resume >> (or booting up) so that the DP controller is armed and ready to receive HPD >> plugin interrupts. HPD plugin interrupt is generated when a dongle plugs >> into DUT (device under test). Once HPD plugin interrupt is received, DP >> controller will initialize phy so that dpcd read/write will function and >> following link training can be proceeded successfully. DP phy will be >> disabled after main link is teared down at end of unplugged HPD interrupt >> handle triggered by dongle unplugged out of DUT. Finally regulators, code >> clocks and irq are disabled at corresponding suspension. >> >> Changes in V2: >> -- removed unnecessary dp_ctrl NULL check >> -- removed unnecessary phy init_count and power_count DRM_DEBUG_DP logs >> -- remove flip parameter out of dp_ctrl_irq_enable() >> -- add fixes tag >> >> Changes in V3: >> -- call dp_display_host_phy_init() instead of dp_ctrl_phy_init() at >> dp_display_host_init() for eDP >> >> Changes in V4: >> -- rewording commit text to match this commit changes >> >> Fixes: e91e3065a806 ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets") >> >> Signed-off-by: Kuogee Hsieh <quic_khsieh@quicinc.com> >> --- > Can you please resend this based on the msm-next branch[1]? It doesn't > apply now that other patches have been applied. > > [1] https://gitlab.freedesktop.org/drm/msm.git msm-next Stephen, below patches missed at msm-next branch. Are there merged soon? 1) WIP: drm/msm/dp: Detect the connector type based on reg property 2) WIP: handle no-hpd property in DP driver >> drivers/gpu/drm/msm/dp/dp_ctrl.c | 87 ++++++++++++++++--------------------- >> drivers/gpu/drm/msm/dp/dp_ctrl.h | 9 ++-- >> drivers/gpu/drm/msm/dp/dp_display.c | 83 ++++++++++++++++++++++++++--------- >> 3 files changed, 105 insertions(+), 74 deletions(-) >>
next prev parent reply other threads:[~2021-12-03 22:54 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-09 21:38 [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received Kuogee Hsieh 2021-11-09 21:38 ` Kuogee Hsieh 2021-11-15 20:23 ` khsieh 2021-11-15 20:23 ` khsieh 2021-11-16 21:58 ` Kuogee Hsieh 2021-11-16 21:58 ` Kuogee Hsieh 2021-11-19 1:20 ` Stephen Boyd 2021-11-19 1:20 ` Stephen Boyd 2021-11-19 16:54 ` Kuogee Hsieh 2021-11-19 16:54 ` Kuogee Hsieh 2021-12-03 2:41 ` Stephen Boyd 2021-12-03 2:41 ` Stephen Boyd 2021-12-03 22:53 ` Kuogee Hsieh [this message] 2021-12-03 22:53 ` Kuogee Hsieh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7c686adc-4288-f29a-c82a-5decab8db703@quicinc.com \ --to=quic_khsieh@quicinc.com \ --cc=agross@kernel.org \ --cc=airlied@linux.ie \ --cc=aravindh@codeaurora.org \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=khsieh@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.