* [PATCH] PCI: rcar: pcie-rcar-ep: Remove unneeded includes
@ 2021-10-01 12:16 Geert Uytterhoeven
2021-10-02 0:53 ` Niklas Söderlund
2021-10-05 9:02 ` Lorenzo Pieralisi
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-10-01 12:16 UTC (permalink / raw)
To: Marek Vasut, Yoshihiro Shimoda, Lad Prabhakar, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas
Cc: linux-pci, linux-renesas-soc, Geert Uytterhoeven
Remove includes that are not needed, to speed up (re)compilation.
Include <linux/pm_runtime.h>, which is needed, and was included
implicitly through <linux/phy/phy.h> before.
Most of these are relics from splitting the driver in a host and a
common part, and adding endpoint support.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pci/controller/pcie-rcar-ep.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
index aa1cf24a5a723d5f..f9682df1da61929b 100644
--- a/drivers/pci/controller/pcie-rcar-ep.c
+++ b/drivers/pci/controller/pcie-rcar-ep.c
@@ -6,16 +6,13 @@
* Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
*/
-#include <linux/clk.h>
#include <linux/delay.h>
#include <linux/of_address.h>
-#include <linux/of_irq.h>
-#include <linux/of_pci.h>
#include <linux/of_platform.h>
#include <linux/pci.h>
#include <linux/pci-epc.h>
-#include <linux/phy/phy.h>
#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
#include "pcie-rcar.h"
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: rcar: pcie-rcar-ep: Remove unneeded includes
2021-10-01 12:16 [PATCH] PCI: rcar: pcie-rcar-ep: Remove unneeded includes Geert Uytterhoeven
@ 2021-10-02 0:53 ` Niklas Söderlund
2021-10-05 9:02 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2021-10-02 0:53 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Marek Vasut, Yoshihiro Shimoda, Lad Prabhakar, Lorenzo Pieralisi,
Rob Herring, Krzysztof Wilczyński, Bjorn Helgaas, linux-pci,
linux-renesas-soc
Hello Geert,
Thanks for your work.
On 2021-10-01 14:16:09 +0200, Geert Uytterhoeven wrote:
> Remove includes that are not needed, to speed up (re)compilation.
> Include <linux/pm_runtime.h>, which is needed, and was included
> implicitly through <linux/phy/phy.h> before.
>
> Most of these are relics from splitting the driver in a host and a
> common part, and adding endpoint support.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/pci/controller/pcie-rcar-ep.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar-ep.c b/drivers/pci/controller/pcie-rcar-ep.c
> index aa1cf24a5a723d5f..f9682df1da61929b 100644
> --- a/drivers/pci/controller/pcie-rcar-ep.c
> +++ b/drivers/pci/controller/pcie-rcar-ep.c
> @@ -6,16 +6,13 @@
> * Author: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> */
>
> -#include <linux/clk.h>
> #include <linux/delay.h>
> #include <linux/of_address.h>
> -#include <linux/of_irq.h>
> -#include <linux/of_pci.h>
> #include <linux/of_platform.h>
> #include <linux/pci.h>
> #include <linux/pci-epc.h>
> -#include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
>
> #include "pcie-rcar.h"
>
> --
> 2.25.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PCI: rcar: pcie-rcar-ep: Remove unneeded includes
2021-10-01 12:16 [PATCH] PCI: rcar: pcie-rcar-ep: Remove unneeded includes Geert Uytterhoeven
2021-10-02 0:53 ` Niklas Söderlund
@ 2021-10-05 9:02 ` Lorenzo Pieralisi
1 sibling, 0 replies; 3+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-05 9:02 UTC (permalink / raw)
To: Krzysztof Wilczyński, Rob Herring, Marek Vasut,
Geert Uytterhoeven, Lad Prabhakar, Yoshihiro Shimoda,
Bjorn Helgaas
Cc: Lorenzo Pieralisi, linux-renesas-soc, linux-pci
On Fri, 1 Oct 2021 14:16:09 +0200, Geert Uytterhoeven wrote:
> Remove includes that are not needed, to speed up (re)compilation.
> Include <linux/pm_runtime.h>, which is needed, and was included
> implicitly through <linux/phy/phy.h> before.
>
> Most of these are relics from splitting the driver in a host and a
> common part, and adding endpoint support.
>
> [...]
Applied to pci/rcar, thanks!
[1/1] PCI: rcar: pcie-rcar-ep: Remove unneeded includes
https://git.kernel.org/lpieralisi/pci/c/ea52bd3459
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-05 9:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-01 12:16 [PATCH] PCI: rcar: pcie-rcar-ep: Remove unneeded includes Geert Uytterhoeven
2021-10-02 0:53 ` Niklas Söderlund
2021-10-05 9:02 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.