* [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()
@ 2021-09-01 11:44 Cai Huoqing
2021-09-01 12:22 ` Fabrizio Castro
2021-09-01 14:49 ` Kieran Bingham
0 siblings, 2 replies; 3+ messages in thread
From: Cai Huoqing @ 2021-09-01 11:44 UTC (permalink / raw)
To: caihuoqing
Cc: Fabrizio Castro, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
Use the devm_platform_get_and_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
---
v1->v2:
Use devm_platform_get_and_ioremap_resource() instead of
devm_platform_ioremap_resource().
v2->v3:
Update commit message.
v3->v4:
Remove the change - "struct resource *res"
drivers/media/platform/rcar_drif.c | 3 +--
1 file changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
index a505d991548b..e50673276d93 100644
--- a/drivers/media/platform/rcar_drif.c
+++ b/drivers/media/platform/rcar_drif.c
@@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device *pdev)
}
/* Register map */
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ch->base = devm_ioremap_resource(&pdev->dev, res);
+ ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
if (IS_ERR(ch->base))
return PTR_ERR(ch->base);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()
2021-09-01 11:44 [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource() Cai Huoqing
@ 2021-09-01 12:22 ` Fabrizio Castro
2021-09-01 14:49 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Fabrizio Castro @ 2021-09-01 12:22 UTC (permalink / raw)
To: Cai Huoqing
Cc: Mauro Carvalho Chehab, linux-media, linux-renesas-soc, linux-kernel
> From: Cai Huoqing <caihuoqing@baidu.com>
> Sent: 01 September 2021 12:45
> To: caihuoqing@baidu.com
> Cc: Fabrizio Castro <fabrizio.castro.jz@renesas.com>; Mauro Carvalho
> Chehab <mchehab@kernel.org>; linux-media@vger.kernel.org; linux-renesas-
> soc@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH v4] media: rcar_drif: Make use of the helper function
> devm_platform_get_and_ioremap_resource()
>
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Acked-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>
> drivers/media/platform/rcar_drif.c | 3 +--
> 1 file changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c
> b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device
> *pdev)
> }
>
> /* Register map */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ch->base = devm_ioremap_resource(&pdev->dev, res);
> + ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(ch->base))
> return PTR_ERR(ch->base);
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource()
2021-09-01 11:44 [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource() Cai Huoqing
2021-09-01 12:22 ` Fabrizio Castro
@ 2021-09-01 14:49 ` Kieran Bingham
1 sibling, 0 replies; 3+ messages in thread
From: Kieran Bingham @ 2021-09-01 14:49 UTC (permalink / raw)
To: Cai Huoqing
Cc: Fabrizio Castro, Mauro Carvalho Chehab, linux-media,
linux-renesas-soc, linux-kernel
On 01/09/2021 12:44, Cai Huoqing wrote:
> Use the devm_platform_get_and_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> v1->v2:
> Use devm_platform_get_and_ioremap_resource() instead of
> devm_platform_ioremap_resource().
> v2->v3:
> Update commit message.
> v3->v4:
> Remove the change - "struct resource *res"
>
> drivers/media/platform/rcar_drif.c | 3 +--
> 1 file changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
> index a505d991548b..e50673276d93 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1395,8 +1395,7 @@ static int rcar_drif_probe(struct platform_device *pdev)
> }
>
> /* Register map */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ch->base = devm_ioremap_resource(&pdev->dev, res);
> + ch->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> if (IS_ERR(ch->base))
> return PTR_ERR(ch->base);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-01 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 11:44 [PATCH v4] media: rcar_drif: Make use of the helper function devm_platform_get_and_ioremap_resource() Cai Huoqing
2021-09-01 12:22 ` Fabrizio Castro
2021-09-01 14:49 ` Kieran Bingham
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.