* [PATCH net-next] bpf: add test_progs to .gitignore
@ 2017-04-11 11:35 Alexander Alemayhu
2017-04-11 11:49 ` Daniel Borkmann
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Alemayhu @ 2017-04-11 11:35 UTC (permalink / raw)
To: netdev; +Cc: daniel, ast, Alexander Alemayhu
Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
---
tools/testing/selftests/bpf/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
index 541d9d7fad5a..2fe8766e204f 100644
--- a/tools/testing/selftests/bpf/.gitignore
+++ b/tools/testing/selftests/bpf/.gitignore
@@ -3,3 +3,4 @@ test_maps
test_lru_map
test_lpm_map
test_tag
+test_progs
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] bpf: add test_progs to .gitignore
2017-04-11 11:35 [PATCH net-next] bpf: add test_progs to .gitignore Alexander Alemayhu
@ 2017-04-11 11:49 ` Daniel Borkmann
2017-04-11 12:14 ` Alexander Alemayhu
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Borkmann @ 2017-04-11 11:49 UTC (permalink / raw)
To: Alexander Alemayhu, netdev; +Cc: ast
On 04/11/2017 01:35 PM, Alexander Alemayhu wrote:
> Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
> ---
> tools/testing/selftests/bpf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> index 541d9d7fad5a..2fe8766e204f 100644
> --- a/tools/testing/selftests/bpf/.gitignore
> +++ b/tools/testing/selftests/bpf/.gitignore
> @@ -3,3 +3,4 @@ test_maps
> test_lru_map
> test_lpm_map
> test_tag
> +test_progs
Good point, we should also add '*.o' in that case for the
TEST_GEN_FILES specified objs that clang generates.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] bpf: add test_progs to .gitignore
2017-04-11 11:49 ` Daniel Borkmann
@ 2017-04-11 12:14 ` Alexander Alemayhu
2017-04-11 14:08 ` David Ahern
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Alemayhu @ 2017-04-11 12:14 UTC (permalink / raw)
To: Daniel Borkmann; +Cc: netdev, ast
On Tue, Apr 11, 2017 at 01:49:10PM +0200, Daniel Borkmann wrote:
>
> Good point, we should also add '*.o' in that case for the
> TEST_GEN_FILES specified objs that clang generates.
Think that is covered by other files but added. Would it be
okay to ignore all the generated files, like the below?
commit 1036c0af4dc381c2571947f197c9d30c2c9f4510
Author: Alexander Alemayhu <alexander@alemayhu.com>
Date: Tue Apr 11 13:31:32 2017 +0200
bpf: ignore generated files
o add test_progs to tools/testing/selftests/bpf/.gitignore and the other
generated files.
o new ignore file in samples/bpf
Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com>
diff --git a/samples/bpf/.gitignore b/samples/bpf/.gitignore
new file mode 100644
index 000000000000..6537659507f1
--- /dev/null
+++ b/samples/bpf/.gitignore
@@ -0,0 +1,35 @@
+fds_example
+lathist
+lwt_len_hist
+map_perf_test
+offwaketime
+per_socket_stats_example
+sampleip
+sock_example
+sockex1
+sockex2
+sockex3
+spintest
+tc_l2_redirect
+test_cgrp2_array_pin
+test_cgrp2_attach
+test_cgrp2_attach2
+test_cgrp2_sock
+test_cgrp2_sock2
+test_current_task_under_cgroup
+test_lru_dist
+test_map_in_map
+test_overhead
+test_probe_write_user
+trace_event
+trace_output
+tracex1
+tracex2
+tracex3
+tracex4
+tracex5
+tracex6
+xdp1
+xdp2
+xdp_tx_iptunnel
+*.o
diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
index 541d9d7fad5a..78c8fb7077e0 100644
--- a/tools/testing/selftests/bpf/.gitignore
+++ b/tools/testing/selftests/bpf/.gitignore
@@ -3,3 +3,8 @@ test_maps
test_lru_map
test_lpm_map
test_tag
+test_progs
+FEATURE-DUMP.libbpf
+feature/
+fixdep
+*.o
Thanks.
--
Mit freundlichen Grüßen
Alexander Alemayhu
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] bpf: add test_progs to .gitignore
2017-04-11 12:14 ` Alexander Alemayhu
@ 2017-04-11 14:08 ` David Ahern
2017-04-11 14:43 ` Alexander Alemayhu
0 siblings, 1 reply; 6+ messages in thread
From: David Ahern @ 2017-04-11 14:08 UTC (permalink / raw)
To: Alexander Alemayhu, Daniel Borkmann; +Cc: netdev, ast
On 4/11/17 6:14 AM, Alexander Alemayhu wrote:
> On Tue, Apr 11, 2017 at 01:49:10PM +0200, Daniel Borkmann wrote:
>>
>> Good point, we should also add '*.o' in that case for the
>> TEST_GEN_FILES specified objs that clang generates.
>
> Think that is covered by other files but added. Would it be
> okay to ignore all the generated files, like the below?
listing each program is not a sustainable way to do this. It would be
simpler to put build targets into a build directory and then ignore the
build directory.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] bpf: add test_progs to .gitignore
2017-04-11 14:08 ` David Ahern
@ 2017-04-11 14:43 ` Alexander Alemayhu
2017-04-11 15:16 ` David Ahern
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Alemayhu @ 2017-04-11 14:43 UTC (permalink / raw)
To: David Ahern; +Cc: Daniel Borkmann, netdev, ast
On Tue, Apr 11, 2017 at 08:08:24AM -0600, David Ahern wrote:
>
> listing each program is not a sustainable way to do this. It would be
> simpler to put build targets into a build directory and then ignore the
> build directory.
Agreed. It has probably been raised before, but if no one else does I can send
something later (still learning the make syntax).
Thanks.
--
Mit freundlichen Grüßen
Alexander Alemayhu
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] bpf: add test_progs to .gitignore
2017-04-11 14:43 ` Alexander Alemayhu
@ 2017-04-11 15:16 ` David Ahern
0 siblings, 0 replies; 6+ messages in thread
From: David Ahern @ 2017-04-11 15:16 UTC (permalink / raw)
To: Alexander Alemayhu; +Cc: Daniel Borkmann, netdev, ast
On 4/11/17 8:43 AM, Alexander Alemayhu wrote:
> On Tue, Apr 11, 2017 at 08:08:24AM -0600, David Ahern wrote:
>> listing each program is not a sustainable way to do this. It would be
>> simpler to put build targets into a build directory and then ignore the
>> build directory.
> Agreed. It has probably been raised before, but if no one else does I can send
> something later (still learning the make syntax).
Getting samples/bpf to honor the O= setting is needed as well.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-11 15:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-11 11:35 [PATCH net-next] bpf: add test_progs to .gitignore Alexander Alemayhu
2017-04-11 11:49 ` Daniel Borkmann
2017-04-11 12:14 ` Alexander Alemayhu
2017-04-11 14:08 ` David Ahern
2017-04-11 14:43 ` Alexander Alemayhu
2017-04-11 15:16 ` David Ahern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.