From: Eddie James <eajames@linux.vnet.ibm.com> To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-media <linux-media@vger.kernel.org>, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, andrew@aj.id.au, Mauro Carvalho Chehab <mchehab@kernel.org>, joel@jms.id.au, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 4/4] media: platform: Add Aspeed Video Engine driver Date: Thu, 30 Aug 2018 10:40:21 -0500 [thread overview] Message-ID: <7cb0c2f0-cc12-81a6-a858-40776ec5904c@linux.vnet.ibm.com> (raw) In-Reply-To: <CAAEAJfBpmFPLTMAr+Azc-53JXHPkCU4bjtwqE6nDWUvm=J_x-A@mail.gmail.com> On 08/29/2018 07:52 PM, Ezequiel Garcia wrote: > Hi Eddie, > > On 29 August 2018 at 18:09, Eddie James <eajames@linux.vnet.ibm.com> wrote: >> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs >> can capture and compress video data from digital or analog sources. With >> the Aspeed chip acting a service processor, the Video Engine can capture >> the host processor graphics output. >> >> Add a V4L2 driver to capture video data and compress it to JPEG images, >> making the data available through a standard read interface. >> >> Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com> >> --- >> drivers/media/platform/Kconfig | 8 + >> drivers/media/platform/Makefile | 1 + >> drivers/media/platform/aspeed-video.c | 1307 +++++++++++++++++++++++++++++++++ >> 3 files changed, 1316 insertions(+) >> create mode 100644 drivers/media/platform/aspeed-video.c >> >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> index 94c1fe0..e599245 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platform/Kconfig >> @@ -32,6 +32,14 @@ source "drivers/media/platform/davinci/Kconfig" >> >> source "drivers/media/platform/omap/Kconfig" >> >> +config VIDEO_ASPEED >> + tristate "Aspeed AST2400 and AST2500 Video Engine driver" >> + depends on VIDEO_V4L2 > It seems you are not using videobuf2. I think it should simplify the read > I/O part and at the same time expose the other capture methods. Hi, Well I'm not sure it would simplify the read interface; it's quite simple as it is, both in the driver and to set up in user-space. I did get streaming I/O working but found the performance significantly worse than simple read calls, and therefore not worth the additional complexity. Is it required that I support streaming? Thanks, Eddie > > There are plenty of examples to follow. > > Regards, > Eze >
WARNING: multiple messages have this Message-ID (diff)
From: eajames@linux.vnet.ibm.com (Eddie James) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] media: platform: Add Aspeed Video Engine driver Date: Thu, 30 Aug 2018 10:40:21 -0500 [thread overview] Message-ID: <7cb0c2f0-cc12-81a6-a858-40776ec5904c@linux.vnet.ibm.com> (raw) In-Reply-To: <CAAEAJfBpmFPLTMAr+Azc-53JXHPkCU4bjtwqE6nDWUvm=J_x-A@mail.gmail.com> On 08/29/2018 07:52 PM, Ezequiel Garcia wrote: > Hi Eddie, > > On 29 August 2018 at 18:09, Eddie James <eajames@linux.vnet.ibm.com> wrote: >> The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs >> can capture and compress video data from digital or analog sources. With >> the Aspeed chip acting a service processor, the Video Engine can capture >> the host processor graphics output. >> >> Add a V4L2 driver to capture video data and compress it to JPEG images, >> making the data available through a standard read interface. >> >> Signed-off-by: Eddie James <eajames@linux.vnet.ibm.com> >> --- >> drivers/media/platform/Kconfig | 8 + >> drivers/media/platform/Makefile | 1 + >> drivers/media/platform/aspeed-video.c | 1307 +++++++++++++++++++++++++++++++++ >> 3 files changed, 1316 insertions(+) >> create mode 100644 drivers/media/platform/aspeed-video.c >> >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> index 94c1fe0..e599245 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platform/Kconfig >> @@ -32,6 +32,14 @@ source "drivers/media/platform/davinci/Kconfig" >> >> source "drivers/media/platform/omap/Kconfig" >> >> +config VIDEO_ASPEED >> + tristate "Aspeed AST2400 and AST2500 Video Engine driver" >> + depends on VIDEO_V4L2 > It seems you are not using videobuf2. I think it should simplify the read > I/O part and at the same time expose the other capture methods. Hi, Well I'm not sure it would simplify the read interface; it's quite simple as it is, both in the driver and to set up in user-space. I did get streaming I/O working but found the performance significantly worse than simple read calls, and therefore not worth the additional complexity. Is it required that I support streaming? Thanks, Eddie > > There are plenty of examples to follow. > > Regards, > Eze >
next prev parent reply other threads:[~2018-08-30 15:40 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-29 21:09 [PATCH 0/4] media: platform: Add Aspeed Video Engine driver Eddie James 2018-08-29 21:09 ` Eddie James 2018-08-29 21:09 ` [PATCH 1/4] clock: aspeed: Add VIDEO reset index definition Eddie James 2018-08-29 21:09 ` Eddie James 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-09-04 13:36 ` Rob Herring 2018-09-04 13:36 ` Rob Herring 2018-09-04 13:36 ` Rob Herring 2018-08-29 21:09 ` [PATCH 2/4] clock: aspeed: Setup video engine clocking Eddie James 2018-08-29 21:09 ` Eddie James 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 21:33 ` Joel Stanley 2018-08-31 21:33 ` Joel Stanley 2018-08-31 21:33 ` Joel Stanley 2018-08-29 21:09 ` [PATCH 3/4] dt-bindings: media: Add Aspeed Video Engine binding documentation Eddie James 2018-08-29 21:09 ` Eddie James 2018-09-04 0:50 ` Rob Herring 2018-09-04 0:50 ` Rob Herring 2018-09-04 0:50 ` Rob Herring 2018-08-29 21:09 ` [PATCH 4/4] media: platform: Add Aspeed Video Engine driver Eddie James 2018-08-29 21:09 ` Eddie James 2018-08-30 0:52 ` Ezequiel Garcia 2018-08-30 0:52 ` Ezequiel Garcia 2018-08-30 0:52 ` Ezequiel Garcia 2018-08-30 15:40 ` Eddie James [this message] 2018-08-30 15:40 ` Eddie James 2018-09-03 11:40 ` Hans Verkuil 2018-09-03 11:40 ` Hans Verkuil 2018-09-13 19:00 ` Eddie James 2018-09-13 19:00 ` Eddie James 2018-08-31 17:56 ` [PATCH 0/4] " Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 17:56 ` Stephen Boyd 2018-08-31 19:30 ` Eddie James 2018-08-31 19:30 ` Eddie James 2018-09-01 2:46 ` Stephen Boyd 2018-09-01 2:46 ` Stephen Boyd 2018-09-01 2:46 ` Stephen Boyd 2018-09-03 11:57 ` Hans Verkuil 2018-09-03 11:57 ` Hans Verkuil 2018-09-13 19:11 ` Eddie James 2018-09-13 19:11 ` Eddie James 2018-09-14 6:56 ` Hans Verkuil 2018-09-14 6:56 ` Hans Verkuil 2018-09-14 15:07 ` Eddie James 2018-09-14 15:07 ` Eddie James
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7cb0c2f0-cc12-81a6-a858-40776ec5904c@linux.vnet.ibm.com \ --to=eajames@linux.vnet.ibm.com \ --cc=andrew@aj.id.au \ --cc=devicetree@vger.kernel.org \ --cc=ezequiel@vanguardiasur.com.ar \ --cc=joel@jms.id.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=mturquette@baylibre.com \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.