* warning from device_links_supplier_sync_state_resume()
@ 2019-12-06 17:42 John Garry
2019-12-06 19:27 ` Saravana Kannan
0 siblings, 1 reply; 2+ messages in thread
From: John Garry @ 2019-12-06 17:42 UTC (permalink / raw)
To: frowand.list, Rob Herring, Saravana Kannan, Greg Kroah-Hartman
Cc: linux-kernel, devicetree
Hi,
I'm testing my arm64 system on Linus' master branch at recent commit
b0d4beaa5a4b.
This system is ACPI based, but I notice that when CONFIG_OF_UNITTEST=y
(don't ask why...), I get this:
[ 18.344208] ------------[ cut here ]------------
[ 18.348813] Unmatched sync_state pause/resume!
[ 18.348833] WARNING: CPU: 1 PID: 1 at drivers/base/core.c:786
device_links_supplier_sync_state_resume+0xf8/0x108
[ 18.363419] Modules linked in:
[ 18.366461] CPU: 1 PID: 1 Comm: swapper/0 Not tainted
5.4.0-12941-gb0d4beaa5a4b-dirty #683
[ 18.374710] Hardware name: Huawei Taishan 2280 /D05, BIOS Hisilicon
D05 IT21 Nemo 2.0 RC0 04/18/2018
[ 18.383828] pstate: 60000005 (nZCv daif -PAN -UAO)
[ 18.388606] pc : device_links_supplier_sync_state_resume+0xf8/0x108
[ 18.394858] lr : device_links_supplier_sync_state_resume+0xf8/0x108
[ 18.401110] sp : ffff800011c7bd40
[ 18.404411] x29: ffff800011c7bd40 x28: 0000000000000008
[ 18.409709] x27: ffff80001140e070 x26: ffff80001133b7e8
[ 18.415007] x25: ffff800011a56000 x24: ffff800011a56000
[ 18.420305] x23: ffff041fa7798000 x22: ffff8000119f0000
[ 18.425603] x21: ffff800011879000 x20: ffff800011c7bd88
[ 18.430900] x19: ffff8000119f06b0 x18: ffffffffffffffff
[ 18.436198] x17: fffffdfffe608a5b x16: 0000000000001400
[ 18.441496] x15: ffff8000118798c8 x14: ffff800091c7b9e7
[ 18.446793] x13: ffff800011c7b9f5 x12: ffff800011891000
[ 18.452091] x11: 0000000005f5e0ff x10: ffff80001187a120
[ 18.457389] x9 : ffff800011c7bd40 x8 : 7561702065746174
[ 18.462687] x7 : 735f636e79732064 x6 : ffff800011a616b2
[ 18.467985] x5 : 0000000000000000 x4 : 0000000000000000
[ 18.473283] x3 : 00000000ffffffff x2 : ffff801feaa06000
[ 18.478581] x1 : 51ddef120d2f0500 x0 : 0000000000000000
[ 18.483880] Call trace:
[ 18.486313] device_links_supplier_sync_state_resume+0xf8/0x108
[ 18.492221] of_platform_sync_state_init+0x18/0x2c
[ 18.497000] do_one_initcall+0x5c/0x1b0
[ 18.500824] kernel_init_freeable+0x1a0/0x248
[ 18.505168] kernel_init+0x10/0x108
[ 18.508644] ret_from_fork+0x10/0x18
[ 18.512205] ---[ end trace b280eee6dfb144c3 ]---
It seems the check of_have_populated_dt() is not always the best test
for this device links state resume call.
Thanks,
John
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: warning from device_links_supplier_sync_state_resume()
2019-12-06 17:42 warning from device_links_supplier_sync_state_resume() John Garry
@ 2019-12-06 19:27 ` Saravana Kannan
0 siblings, 0 replies; 2+ messages in thread
From: Saravana Kannan @ 2019-12-06 19:27 UTC (permalink / raw)
To: John Garry
Cc: Frank Rowand, Rob Herring, Greg Kroah-Hartman, linux-kernel, devicetree
On Fri, Dec 6, 2019 at 9:42 AM John Garry <john.garry@huawei.com> wrote:
>
> Hi,
>
> I'm testing my arm64 system on Linus' master branch at recent commit
> b0d4beaa5a4b.
>
> This system is ACPI based, but I notice that when CONFIG_OF_UNITTEST=y
> (don't ask why...), I get this:
>
> [ 18.344208] ------------[ cut here ]------------
> [ 18.348813] Unmatched sync_state pause/resume!
> [ 18.348833] WARNING: CPU: 1 PID: 1 at drivers/base/core.c:786
> device_links_supplier_sync_state_resume+0xf8/0x108
> [ 18.363419] Modules linked in:
> [ 18.366461] CPU: 1 PID: 1 Comm: swapper/0 Not tainted
> 5.4.0-12941-gb0d4beaa5a4b-dirty #683
> [ 18.374710] Hardware name: Huawei Taishan 2280 /D05, BIOS Hisilicon
> D05 IT21 Nemo 2.0 RC0 04/18/2018
> [ 18.383828] pstate: 60000005 (nZCv daif -PAN -UAO)
> [ 18.388606] pc : device_links_supplier_sync_state_resume+0xf8/0x108
> [ 18.394858] lr : device_links_supplier_sync_state_resume+0xf8/0x108
> [ 18.401110] sp : ffff800011c7bd40
> [ 18.404411] x29: ffff800011c7bd40 x28: 0000000000000008
> [ 18.409709] x27: ffff80001140e070 x26: ffff80001133b7e8
> [ 18.415007] x25: ffff800011a56000 x24: ffff800011a56000
> [ 18.420305] x23: ffff041fa7798000 x22: ffff8000119f0000
> [ 18.425603] x21: ffff800011879000 x20: ffff800011c7bd88
> [ 18.430900] x19: ffff8000119f06b0 x18: ffffffffffffffff
> [ 18.436198] x17: fffffdfffe608a5b x16: 0000000000001400
> [ 18.441496] x15: ffff8000118798c8 x14: ffff800091c7b9e7
> [ 18.446793] x13: ffff800011c7b9f5 x12: ffff800011891000
> [ 18.452091] x11: 0000000005f5e0ff x10: ffff80001187a120
> [ 18.457389] x9 : ffff800011c7bd40 x8 : 7561702065746174
> [ 18.462687] x7 : 735f636e79732064 x6 : ffff800011a616b2
> [ 18.467985] x5 : 0000000000000000 x4 : 0000000000000000
> [ 18.473283] x3 : 00000000ffffffff x2 : ffff801feaa06000
> [ 18.478581] x1 : 51ddef120d2f0500 x0 : 0000000000000000
> [ 18.483880] Call trace:
> [ 18.486313] device_links_supplier_sync_state_resume+0xf8/0x108
> [ 18.492221] of_platform_sync_state_init+0x18/0x2c
> [ 18.497000] do_one_initcall+0x5c/0x1b0
> [ 18.500824] kernel_init_freeable+0x1a0/0x248
> [ 18.505168] kernel_init+0x10/0x108
> [ 18.508644] ret_from_fork+0x10/0x18
> [ 18.512205] ---[ end trace b280eee6dfb144c3 ]---
>
> It seems the check of_have_populated_dt() is not always the best test
> for this device links state resume call.
Yeah, one of the bots reported it a few days ago. I'll send out a fix
soon. It's a trivial fix.
-Saravana
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-06 19:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-06 17:42 warning from device_links_supplier_sync_state_resume() John Garry
2019-12-06 19:27 ` Saravana Kannan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.