From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: Boris Brezillon <boris.brezillon@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Bean Huo (beanhuo)" <beanhuo@micron.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH 0/2] mtd: rawnand: micron: Fix on-die ECC
Date: Mon, 16 Jul 2018 08:07:02 +0000 [thread overview]
Message-ID: <7cd10203b24b4d3aae6070e356604728@svr-chch-ex1.atlnz.lc> (raw)
In-Reply-To: 20180709210937.30150-1-boris.brezillon@bootlin.com
On 10/07/18 09:09, Boris Brezillon wrote:
> Chris, Bean,
>
> Here are 2 patches for you to review/test. The first one is fixing
> the layout definition, and unless I missed something it should be
> correct.
>
> The second one is just my understanding of how byte 5 of READ_ID works
> based on our experience with the 4bit/512 on-die ECC chip we have
> worked on and the other datasheet I had a look at.
> I'm not 100% sure this will work for all chips, but might work for the
> 2 chips we support right now.
> So please test and/or review it and let me know if this approach works.
>
Hi Boris,
I went to test this today and found that I could no-longer mount the
Micron MT29F1G08ABAFAWP-ITE chip. However it doesn't appear to these
changes but d73e5d29 ("mtd: rawnand: micron: Disable ECC earlier in the
read path").
[root@linuxbox ~]# ubiformat -q -y /dev/mtd0
[root@linuxbox ~]# ubiattach -p /dev/mtd0
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0 error: ubi_read_volume_table: the layout volume was not found
ubi0 error: ubi_attach_mtd_dev: failed to attach mtd0, error -22
ubiattach: error!: cannot attach "/dev/mtd0"
error 22 (Invalid argument)
[root@linuxbox ~]# ubimkvol /dev/ubi0 -N user -m
libubi: error!: cannot get information about "/dev/ubi0"
error 2 (No such file or directory)
ubimkvol: error!: error while probing "/dev/ubi0"
error 2 (No such file or directory)
I'll try juggling some of the nand/next patches around to see if I can
test these two without d73e5d29.
prev parent reply other threads:[~2018-07-16 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 21:09 [PATCH 0/2] mtd: rawnand: micron: Fix on-die ECC Boris Brezillon
2018-07-09 21:09 ` [PATCH 1/2] mtd: rawnand: micron: Define the proper layout for 8bit/512bytes " Boris Brezillon
2018-07-16 8:37 ` Chris Packham
2018-07-09 21:09 ` [PATCH 2/2] mtd: rawnand: micron: Fix on-die ECC detection logic Boris Brezillon
2018-07-16 8:36 ` Chris Packham
2018-07-10 8:10 ` [PATCH 0/2] mtd: rawnand: micron: Fix on-die ECC Boris Brezillon
2018-07-10 21:40 ` Chris Packham
2018-07-16 8:07 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd10203b24b4d3aae6070e356604728@svr-chch-ex1.atlnz.lc \
--to=chris.packham@alliedtelesis.co.nz \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.