* [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 12:01 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 12:01 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, Bibby Hsieh, matthias.bgg, drinkcat, hsinyi,
linux-arm-kernel, CK Hu, Philipp Zabel, dri-devel,
linux-mediatek, David Airlie, Daniel Vetter
Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
update") added support to async updates of cursors by using the new atomic
interface for that. Unfortunately, introduced two issues. The first one is
that since then, the drm_atomic_helper_async_commit triggers a WARNING due
current fb is not the new fb. The second one, is that we get a black screen
connecting the external display on Elm device and another WARNING due vblank
wait timed out.
Swap the fb in mtk_plane_atomic_async_update to fix both issues.
Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index 914cc7619cd7..7eb10115e72a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
plane->state->src_h = new_state->src_h;
plane->state->src_w = new_state->src_w;
state->pending.async_dirty = true;
+ swap(plane->state->fb, new_state->fb);
mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
}
--
2.25.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 12:01 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 12:01 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, Philipp Zabel, David Airlie, dri-devel, CK Hu,
linux-mediatek, Bibby Hsieh, hsinyi, matthias.bgg, Daniel Vetter,
Collabora Kernel ML, linux-arm-kernel
Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
update") added support to async updates of cursors by using the new atomic
interface for that. Unfortunately, introduced two issues. The first one is
that since then, the drm_atomic_helper_async_commit triggers a WARNING due
current fb is not the new fb. The second one, is that we get a black screen
connecting the external display on Elm device and another WARNING due vblank
wait timed out.
Swap the fb in mtk_plane_atomic_async_update to fix both issues.
Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index 914cc7619cd7..7eb10115e72a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
plane->state->src_h = new_state->src_h;
plane->state->src_w = new_state->src_w;
state->pending.async_dirty = true;
+ swap(plane->state->fb, new_state->fb);
mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
}
--
2.25.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 12:01 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 12:01 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, Philipp Zabel, David Airlie, dri-devel, CK Hu,
linux-mediatek, Bibby Hsieh, hsinyi, matthias.bgg, Daniel Vetter,
Collabora Kernel ML, linux-arm-kernel
Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
update") added support to async updates of cursors by using the new atomic
interface for that. Unfortunately, introduced two issues. The first one is
that since then, the drm_atomic_helper_async_commit triggers a WARNING due
current fb is not the new fb. The second one, is that we get a black screen
connecting the external display on Elm device and another WARNING due vblank
wait timed out.
Swap the fb in mtk_plane_atomic_async_update to fix both issues.
Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index 914cc7619cd7..7eb10115e72a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
plane->state->src_h = new_state->src_h;
plane->state->src_w = new_state->src_w;
state->pending.async_dirty = true;
+ swap(plane->state->fb, new_state->fb);
mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
}
--
2.25.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 12:01 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 12:01 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, David Airlie, dri-devel, linux-mediatek, hsinyi,
matthias.bgg, Collabora Kernel ML, linux-arm-kernel
Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
update") added support to async updates of cursors by using the new atomic
interface for that. Unfortunately, introduced two issues. The first one is
that since then, the drm_atomic_helper_async_commit triggers a WARNING due
current fb is not the new fb. The second one, is that we get a black screen
connecting the external display on Elm device and another WARNING due vblank
wait timed out.
Swap the fb in mtk_plane_atomic_async_update to fix both issues.
Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
index 914cc7619cd7..7eb10115e72a 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
@@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
plane->state->src_h = new_state->src_h;
plane->state->src_w = new_state->src_w;
state->pending.async_dirty = true;
+ swap(plane->state->fb, new_state->fb);
mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
}
--
2.25.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
2020-02-13 12:01 ` Enric Balletbo i Serra
(?)
(?)
@ 2020-02-13 13:38 ` Enric Balletbo i Serra
-1 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 13:38 UTC (permalink / raw)
To: linux-kernel
Cc: Collabora Kernel ML, Bibby Hsieh, matthias.bgg, drinkcat, hsinyi,
linux-arm-kernel, CK Hu, Philipp Zabel, dri-devel,
linux-mediatek, David Airlie, Daniel Vetter
Hi,
On 13/2/20 13:01, Enric Balletbo i Serra wrote:
> Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
> update") added support to async updates of cursors by using the new atomic
> interface for that. Unfortunately, introduced two issues. The first one is
> that since then, the drm_atomic_helper_async_commit triggers a WARNING due
> current fb is not the new fb. The second one, is that we get a black screen
> connecting the external display on Elm device and another WARNING due vblank
> wait timed out.
>
> Swap the fb in mtk_plane_atomic_async_update to fix both issues.
>
> Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
I just noticed this, which should fix the problem too, so you can ignore this patch.
https://patchwork.kernel.org/patch/11379571/
>
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 914cc7619cd7..7eb10115e72a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
> plane->state->src_h = new_state->src_h;
> plane->state->src_w = new_state->src_w;
> state->pending.async_dirty = true;
> + swap(plane->state->fb, new_state->fb);
>
> mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
> }
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 13:38 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 13:38 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, Philipp Zabel, David Airlie, dri-devel, CK Hu,
linux-mediatek, Bibby Hsieh, hsinyi, matthias.bgg, Daniel Vetter,
Collabora Kernel ML, linux-arm-kernel
Hi,
On 13/2/20 13:01, Enric Balletbo i Serra wrote:
> Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
> update") added support to async updates of cursors by using the new atomic
> interface for that. Unfortunately, introduced two issues. The first one is
> that since then, the drm_atomic_helper_async_commit triggers a WARNING due
> current fb is not the new fb. The second one, is that we get a black screen
> connecting the external display on Elm device and another WARNING due vblank
> wait timed out.
>
> Swap the fb in mtk_plane_atomic_async_update to fix both issues.
>
> Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
I just noticed this, which should fix the problem too, so you can ignore this patch.
https://patchwork.kernel.org/patch/11379571/
>
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 914cc7619cd7..7eb10115e72a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
> plane->state->src_h = new_state->src_h;
> plane->state->src_w = new_state->src_w;
> state->pending.async_dirty = true;
> + swap(plane->state->fb, new_state->fb);
>
> mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
> }
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 13:38 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 13:38 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, Philipp Zabel, David Airlie, dri-devel, CK Hu,
linux-mediatek, Bibby Hsieh, hsinyi, matthias.bgg, Daniel Vetter,
Collabora Kernel ML, linux-arm-kernel
Hi,
On 13/2/20 13:01, Enric Balletbo i Serra wrote:
> Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
> update") added support to async updates of cursors by using the new atomic
> interface for that. Unfortunately, introduced two issues. The first one is
> that since then, the drm_atomic_helper_async_commit triggers a WARNING due
> current fb is not the new fb. The second one, is that we get a black screen
> connecting the external display on Elm device and another WARNING due vblank
> wait timed out.
>
> Swap the fb in mtk_plane_atomic_async_update to fix both issues.
>
> Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
I just noticed this, which should fix the problem too, so you can ignore this patch.
https://patchwork.kernel.org/patch/11379571/
>
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 914cc7619cd7..7eb10115e72a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
> plane->state->src_h = new_state->src_h;
> plane->state->src_w = new_state->src_w;
> state->pending.async_dirty = true;
> + swap(plane->state->fb, new_state->fb);
>
> mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
> }
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update
@ 2020-02-13 13:38 ` Enric Balletbo i Serra
0 siblings, 0 replies; 8+ messages in thread
From: Enric Balletbo i Serra @ 2020-02-13 13:38 UTC (permalink / raw)
To: linux-kernel
Cc: drinkcat, David Airlie, dri-devel, linux-mediatek, hsinyi,
matthias.bgg, Collabora Kernel ML, linux-arm-kernel
Hi,
On 13/2/20 13:01, Enric Balletbo i Serra wrote:
> Commit 920fffcc8912 ("drm/mediatek: update cursors by using async atomic
> update") added support to async updates of cursors by using the new atomic
> interface for that. Unfortunately, introduced two issues. The first one is
> that since then, the drm_atomic_helper_async_commit triggers a WARNING due
> current fb is not the new fb. The second one, is that we get a black screen
> connecting the external display on Elm device and another WARNING due vblank
> wait timed out.
>
> Swap the fb in mtk_plane_atomic_async_update to fix both issues.
>
> Fixes: 920fffcc8912 ("drm/mediatek: update cursors by using async atomic update")
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
I just noticed this, which should fix the problem too, so you can ignore this patch.
https://patchwork.kernel.org/patch/11379571/
>
> drivers/gpu/drm/mediatek/mtk_drm_plane.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> index 914cc7619cd7..7eb10115e72a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c
> @@ -116,6 +116,7 @@ static void mtk_plane_atomic_async_update(struct drm_plane *plane,
> plane->state->src_h = new_state->src_h;
> plane->state->src_w = new_state->src_w;
> state->pending.async_dirty = true;
> + swap(plane->state->fb, new_state->fb);
>
> mtk_drm_crtc_async_update(new_state->crtc, plane, new_state);
> }
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-02-14 8:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 12:01 [PATCH] drm/mediatek: Update the fb property mtk_plane_atomic_async_update Enric Balletbo i Serra
2020-02-13 12:01 ` Enric Balletbo i Serra
2020-02-13 12:01 ` Enric Balletbo i Serra
2020-02-13 12:01 ` Enric Balletbo i Serra
2020-02-13 13:38 ` Enric Balletbo i Serra
2020-02-13 13:38 ` Enric Balletbo i Serra
2020-02-13 13:38 ` Enric Balletbo i Serra
2020-02-13 13:38 ` Enric Balletbo i Serra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.