* [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default
@ 2007-02-15 16:48 Kim Phillips
2007-02-16 0:54 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Kim Phillips @ 2007-02-15 16:48 UTC (permalink / raw)
To: u-boot
---
include/configs/MPC832XEMDS.h | 1 +
include/configs/MPC8349EMDS.h | 1 +
include/configs/MPC8360EMDS.h | 1 +
include/configs/sbc8349.h | 1 +
4 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/include/configs/MPC832XEMDS.h b/include/configs/MPC832XEMDS.h
index b8bf00f..bcd11dc 100644
--- a/include/configs/MPC832XEMDS.h
+++ b/include/configs/MPC832XEMDS.h
@@ -307,6 +307,7 @@ #define CFG_BAUDRATE_TABLE \
#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)
#define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */
/* Use the HUSH parser */
#define CFG_HUSH_PARSER
#ifdef CFG_HUSH_PARSER
diff --git a/include/configs/MPC8349EMDS.h b/include/configs/MPC8349EMDS.h
index 5bed2d0..e7a961e 100644
--- a/include/configs/MPC8349EMDS.h
+++ b/include/configs/MPC8349EMDS.h
@@ -314,6 +314,7 @@ #define CFG_BAUDRATE_TABLE \
#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)
#define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */
/* Use the HUSH parser */
#define CFG_HUSH_PARSER
#ifdef CFG_HUSH_PARSER
diff --git a/include/configs/MPC8360EMDS.h b/include/configs/MPC8360EMDS.h
index d613618..e404bce 100644
--- a/include/configs/MPC8360EMDS.h
+++ b/include/configs/MPC8360EMDS.h
@@ -309,6 +309,7 @@ #define CFG_BAUDRATE_TABLE \
#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)
#define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */
/* Use the HUSH parser */
#define CFG_HUSH_PARSER
#ifdef CFG_HUSH_PARSER
diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h
index 2e6685d..a0b1680 100644
--- a/include/configs/sbc8349.h
+++ b/include/configs/sbc8349.h
@@ -313,6 +313,7 @@ #define CFG_BAUDRATE_TABLE \
#define CFG_NS16550_COM1 (CFG_IMMR+0x4500)
#define CFG_NS16550_COM2 (CFG_IMMR+0x4600)
+#define CONFIG_CMDLINE_EDITING /* Command-line editing */
/* Use the HUSH parser */
#define CFG_HUSH_PARSER
#ifdef CFG_HUSH_PARSER
--
1.4.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default
2007-02-15 16:48 [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default Kim Phillips
@ 2007-02-16 0:54 ` Wolfgang Denk
2007-02-16 1:22 ` Grant Likely
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2007-02-16 0:54 UTC (permalink / raw)
To: u-boot
In message <20070215104840.23a57bd0.kim.phillips@freescale.com> you wrote:
>
> ---
> include/configs/MPC832XEMDS.h | 1 +
> include/configs/MPC8349EMDS.h | 1 +
> include/configs/MPC8360EMDS.h | 1 +
> include/configs/sbc8349.h | 1 +
Are you the maintainer of the sbc8349 baord?
Did you discuss such a change with the maintainer?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This is an unauthorized cybernetic announcement.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default
2007-02-16 0:54 ` Wolfgang Denk
@ 2007-02-16 1:22 ` Grant Likely
2007-02-16 11:23 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Grant Likely @ 2007-02-16 1:22 UTC (permalink / raw)
To: u-boot
On 2/15/07, Wolfgang Denk <wd@denx.de> wrote:
> In message <20070215104840.23a57bd0.kim.phillips@freescale.com> you wrote:
> >
> > ---
> > include/configs/MPC832XEMDS.h | 1 +
> > include/configs/MPC8349EMDS.h | 1 +
> > include/configs/MPC8360EMDS.h | 1 +
> > include/configs/sbc8349.h | 1 +
>
> Are you the maintainer of the sbc8349 baord?
>
> Did you discuss such a change with the maintainer?
Ummm... Isn't that what this mailing list is for? To discuss changes?
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
grant.likely at secretlab.ca
(403) 399-0195
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default
2007-02-16 1:22 ` Grant Likely
@ 2007-02-16 11:23 ` Wolfgang Denk
2007-02-21 1:03 ` Kim Phillips
0 siblings, 1 reply; 6+ messages in thread
From: Wolfgang Denk @ 2007-02-16 11:23 UTC (permalink / raw)
To: u-boot
In message <528646bc0702151722xc107d6fq4a388265002c5bd2@mail.gmail.com> you wrote:
>
> > Are you the maintainer of the sbc8349 baord?
> >
> > Did you discuss such a change with the maintainer?
>
> Ummm... Isn't that what this mailing list is for? To discuss changes?
Yes, but there is different types of changes.
There is no need to discuss a bug fix - it should always be applied to
all affected boards, of course.
But this is not a bug fix - it is a change of the board configura-
tion, i. e. of the board customization. I think it is NOT a good idea
if anybody meddles with the configuration of someone elses board
without discussing this explicitely with the respective board
maintainer. In the current case, it was totally unclear to me if
"foreign" boards would be changed, or not.
As a complication there is the problem that this patch does not even
apply to the current U-Boot tree, which does not contain such files
like include/configs/MPC832XEMDS.h or include/configs/sbc8349.h; and
the patch did not contain any indication which tree it was against
and/or which previous patches it requires.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I can't understand it. I can't even understand the people who can
understand it. - Queen Juliana of the Netherlands.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default
2007-02-16 11:23 ` Wolfgang Denk
@ 2007-02-21 1:03 ` Kim Phillips
2007-02-21 18:03 ` Paul Gortmaker
0 siblings, 1 reply; 6+ messages in thread
From: Kim Phillips @ 2007-02-21 1:03 UTC (permalink / raw)
To: u-boot
On Fri, 16 Feb 2007 12:23:06 +0100
Wolfgang Denk <wd@denx.de> wrote:
> In message <528646bc0702151722xc107d6fq4a388265002c5bd2@mail.gmail.com> you wrote:
> >
> > > Are you the maintainer of the sbc8349 baord?
> > >
> > > Did you discuss such a change with the maintainer?
> >
> > Ummm... Isn't that what this mailing list is for? To discuss changes?
>
> Yes, but there is different types of changes.
>
> There is no need to discuss a bug fix - it should always be applied to
> all affected boards, of course.
>
> But this is not a bug fix - it is a change of the board configura-
> tion, i. e. of the board customization. I think it is NOT a good idea
> if anybody meddles with the configuration of someone elses board
> without discussing this explicitely with the respective board
> maintainer. In the current case, it was totally unclear to me if
> "foreign" boards would be changed, or not.
I tried communicating with Paul Gortmaker without success, so I removed the sbc8349 board config from the patch. The mpc83xx branch on:
http://opensource.freescale.com/pub/scm/u-boot-83xx.git
contains the revised patch:
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default
2007-02-21 1:03 ` Kim Phillips
@ 2007-02-21 18:03 ` Paul Gortmaker
0 siblings, 0 replies; 6+ messages in thread
From: Paul Gortmaker @ 2007-02-21 18:03 UTC (permalink / raw)
To: u-boot
On 2/20/07, Kim Phillips <kim.phillips@freescale.com> wrote:
>
> I tried communicating with Paul Gortmaker without success, so I removed the sbc8349 board config from the patch. The mpc83xx branch on:
>
> http://opensource.freescale.com/pub/scm/u-boot-83xx.git
>
> contains the revised patch:
>
Sorry for not jumping in sooner. I'm fine with the sbc8349 having command
line editing support enabled. In fact I explicitly tried to make the sbc8349.h
track the MPC8349MDS as much as possible to ease maintenance on
behalf of the 83xx maintainer(s) and myself.
Paul.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-21 18:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-15 16:48 [U-Boot-Users] [PATCH] mpc83xx: add command line editing by default Kim Phillips
2007-02-16 0:54 ` Wolfgang Denk
2007-02-16 1:22 ` Grant Likely
2007-02-16 11:23 ` Wolfgang Denk
2007-02-21 1:03 ` Kim Phillips
2007-02-21 18:03 ` Paul Gortmaker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.