All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>,
	Markus Mayer <mmayer@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Brian Norris <computersforpeace@gmail.com>,
	Gregory Fong <gregory.0xf0@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: [PATCH 06/27] cpufreq: brcmstb: Don't validate the frequency table twice
Date: Mon, 26 Feb 2018 10:38:49 +0530	[thread overview]
Message-ID: <7d2bc4de102c81503c30a64503179c4ccebe6287.1519620578.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1519620578.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1519620578.git.viresh.kumar@linaro.org>

The cpufreq core is already validating the CPU frequency table after
calling the ->init() callback of the cpufreq drivers and the drivers
don't need to do the same anymore. Though they need to set the
policy->freq_table field directly from the ->init() callback now.

Stop validating the frequency table from brcmstb driver.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/brcmstb-avs-cpufreq.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
index 7281a2c19c36..6cdac1aaf23c 100644
--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
+++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
@@ -902,11 +902,7 @@ static int brcm_avs_cpufreq_init(struct cpufreq_policy *policy)
 		return ret;
 	}
 
-	ret = cpufreq_table_validate_and_show(policy, freq_table);
-	if (ret) {
-		dev_err(dev, "invalid frequency table: %d\n", ret);
-		return ret;
-	}
+	policy->freq_table = freq_table;
 
 	/* All cores share the same clock and thus the same policy. */
 	cpumask_setall(policy->cpus);
-- 
2.15.0.194.g9af6a3dea062

WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/27] cpufreq: brcmstb: Don't validate the frequency table twice
Date: Mon, 26 Feb 2018 10:38:49 +0530	[thread overview]
Message-ID: <7d2bc4de102c81503c30a64503179c4ccebe6287.1519620578.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1519620578.git.viresh.kumar@linaro.org>

The cpufreq core is already validating the CPU frequency table after
calling the ->init() callback of the cpufreq drivers and the drivers
don't need to do the same anymore. Though they need to set the
policy->freq_table field directly from the ->init() callback now.

Stop validating the frequency table from brcmstb driver.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/cpufreq/brcmstb-avs-cpufreq.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
index 7281a2c19c36..6cdac1aaf23c 100644
--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
+++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
@@ -902,11 +902,7 @@ static int brcm_avs_cpufreq_init(struct cpufreq_policy *policy)
 		return ret;
 	}
 
-	ret = cpufreq_table_validate_and_show(policy, freq_table);
-	if (ret) {
-		dev_err(dev, "invalid frequency table: %d\n", ret);
-		return ret;
-	}
+	policy->freq_table = freq_table;
 
 	/* All cores share the same clock and thus the same policy. */
 	cpumask_setall(policy->cpus);
-- 
2.15.0.194.g9af6a3dea062

  reply	other threads:[~2018-02-26  5:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26  5:08 [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
2018-02-26  5:08 ` Viresh Kumar
2018-02-26  5:08 ` Viresh Kumar
2018-02-26  5:08 ` Viresh Kumar [this message]
2018-02-26  5:08   ` [PATCH 06/27] cpufreq: brcmstb: Don't validate the frequency table twice Viresh Kumar
2018-02-26  5:08 ` [PATCH 12/27] cpufreq: mediatek: " Viresh Kumar
2018-02-26  5:08   ` Viresh Kumar
2018-02-26  5:08 ` [PATCH 15/27] cpufreq: powerenv: " Viresh Kumar
2018-02-26  5:08   ` Viresh Kumar
2018-02-26 11:53   ` Michael Ellerman
2018-02-26 11:53     ` Michael Ellerman
2018-02-27  3:45     ` Viresh Kumar
2018-02-27  3:45       ` Viresh Kumar
2018-02-28 10:45       ` Michael Ellerman
2018-02-28 10:45         ` Michael Ellerman
2018-03-05  4:19   ` [PATCH V2 15/27] cpufreq: powernv: " Viresh Kumar
2018-03-05  4:19     ` Viresh Kumar
2018-02-26  5:09 ` [PATCH 19/27] cpufreq: s3c24xx: " Viresh Kumar
2018-02-26  5:09   ` Viresh Kumar
2018-02-26  5:09 ` [PATCH 21/27] cpufreq: scpi: " Viresh Kumar
2018-02-26  5:09   ` Viresh Kumar
2018-03-12 12:43   ` Sudeep Holla
2018-03-12 12:43     ` Sudeep Holla
     [not found] ` <cover.1519620578.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-03-09 10:00   ` [PATCH 00/27] cpufreq: Stop validating cpufreq table in drivers Viresh Kumar
2018-03-09 10:00     ` Viresh Kumar
2018-03-09 10:00     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d2bc4de102c81503c30a64503179c4ccebe6287.1519620578.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=computersforpeace@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregory.0xf0@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mmayer@broadcom.com \
    --cc=rjw@rjwysocki.net \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.