* [igt-dev] [PATCH i-g-t 0/1] tests/kms_concurrent: Move simultaneously allowed
@ 2020-01-24 6:10 Mohammed Khajapasha
2020-01-24 6:10 ` [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread Mohammed Khajapasha
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Mohammed Khajapasha @ 2020-01-24 6:10 UTC (permalink / raw)
To: igt-dev; +Cc: juha-pekka.heikkila
High resolution consumes more bandwidth so if amount of max planes is
calculated during low resolution switch back to high resolution will
immediately fail with bandwidth problem.
To avoid bandwidth exceed,move the simultaneously allowed planes to
before switching to low resolution mode in main thread.
Mohammed Khajapasha (1):
tests/kms_concurrent: Move simultaneously allowed planes to main
thread
tests/kms_concurrent.c | 65 +++++++++++++++++++-----------------------
1 file changed, 30 insertions(+), 35 deletions(-)
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread
2020-01-24 6:10 [igt-dev] [PATCH i-g-t 0/1] tests/kms_concurrent: Move simultaneously allowed Mohammed Khajapasha
@ 2020-01-24 6:10 ` Mohammed Khajapasha
2020-01-27 11:37 ` Juha-Pekka Heikkila
2020-01-24 8:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Move simultaneously allowed Patchwork
2020-01-26 7:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Mohammed Khajapasha @ 2020-01-24 6:10 UTC (permalink / raw)
To: igt-dev; +Cc: juha-pekka.heikkila
High resolution consumes more bandwidth so if amount of max planes is
calculated during low resolution switch back to high resolution will
immediately fail with bandwidth problem.
To avoid bandwidth exceed,move the simultaneously allowed planes to
before switching to low resolution mode in main thread.
Signed-off-by: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
---
tests/kms_concurrent.c | 65 +++++++++++++++++++-----------------------
1 file changed, 30 insertions(+), 35 deletions(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index a0280d15..14ca5fab 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -57,33 +57,11 @@ struct {
static void test_init(data_t *data, enum pipe pipe, int n_planes,
igt_output_t *output)
{
- drmModeModeInfo *mode;
- igt_plane_t *primary;
- int ret;
-
data->plane = calloc(n_planes, sizeof(*data->plane));
igt_assert_f(data->plane != NULL, "Failed to allocate memory for planes\n");
data->fb = calloc(n_planes, sizeof(struct igt_fb));
igt_assert_f(data->fb != NULL, "Failed to allocate memory for FBs\n");
-
- igt_output_set_pipe(output, pipe);
-
- primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
- data->plane[primary->index] = primary;
-
- mode = igt_output_get_mode(output);
-
- igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888,
- LOCAL_I915_FORMAT_MOD_X_TILED,
- 0.0f, 0.0f, 1.0f,
- &data->fb[primary->index]);
-
- igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
-
- ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
- igt_skip_on(ret != 0);
}
static void test_fini(data_t *data, enum pipe pipe, int n_planes,
@@ -184,7 +162,6 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
y[primary->index] = 0;
for (i = 0; i < max_planes; i++) {
igt_plane_t *plane = igt_output_get_plane(output, i);
- int ret;
if (plane->type == DRM_PLANE_TYPE_PRIMARY)
continue;
@@ -207,18 +184,7 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
igt_plane_set_position(data->plane[i], x[i], y[i]);
igt_plane_set_fb(data->plane[i], &data->fb[i]);
-
- ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
- if (ret) {
- igt_plane_set_fb(data->plane[i], NULL);
- igt_remove_fb(data->drm_fd, &data->fb[i]);
- data->plane[i] = NULL;
- break;
- }
}
- max_planes = i;
-
- igt_assert_lt(0, max_planes);
/* primary plane */
data->plane[primary->index] = primary;
@@ -282,10 +248,39 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
const drmModeModeInfo *mode_hi, *mode_lo;
int iterations = opt.iterations < 1 ? 1 : opt.iterations;
bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
- int i;
+ int i, c, ret;
+ int max_planes = data->display.pipes[pipe].n_planes;
+ igt_plane_t *primary;
+ drmModeModeInfo *mode;
i = 0;
while (i < iterations || loop_forever) {
+ igt_output_set_pipe(output, pipe);
+ for (c = 0; c < max_planes; c++) {
+ igt_plane_t *plane = igt_output_get_plane(output, c);
+
+ if (plane->type != DRM_PLANE_TYPE_PRIMARY)
+ continue;
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ data->plane[primary->index] = primary;
+ mode = igt_output_get_mode(output);
+ igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ LOCAL_I915_FORMAT_MOD_X_TILED,
+ 0.0f, 0.0f, 1.0f,
+ &data->fb[primary->index]);
+ igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
+ ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+ if (ret) {
+ igt_plane_set_fb(data->plane[i], NULL);
+ igt_remove_fb(data->drm_fd, &data->fb[i]);
+ data->plane[i] = NULL;
+ break;
+ }
+ }
+ max_planes = c;
+ igt_assert_lt(0, max_planes);
+
mode_hi = igt_output_get_mode(output);
mode_lo = get_lowres_mode(data, mode_hi, output);
--
2.24.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Move simultaneously allowed
2020-01-24 6:10 [igt-dev] [PATCH i-g-t 0/1] tests/kms_concurrent: Move simultaneously allowed Mohammed Khajapasha
2020-01-24 6:10 ` [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread Mohammed Khajapasha
@ 2020-01-24 8:59 ` Patchwork
2020-01-26 7:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-24 8:59 UTC (permalink / raw)
To: Mohammed Khajapasha; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Move simultaneously allowed
URL : https://patchwork.freedesktop.org/series/72511/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806 -> IGTPW_3985
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/index.html
Known issues
------------
Here are the changes found in IGTPW_3985 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-tgl-y: [PASS][1] -> [FAIL][2] ([CI#94])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-tgl-y/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_module_load@reload-with-fault-injection:
- fi-cfl-guc: [PASS][3] -> [INCOMPLETE][4] ([i915#505] / [i915#671])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-cfl-guc/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_addfb_basic@clobberred-modifier:
- fi-tgl-y: [PASS][5] -> [DMESG-WARN][6] ([CI#94] / [i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-tgl-y/igt@kms_addfb_basic@clobberred-modifier.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-tgl-y/igt@kms_addfb_basic@clobberred-modifier.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-bsw-nick: [DMESG-FAIL][7] ([i915#723]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-bsw-nick/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-bsw-nick/igt@i915_selftest@live_blt.html
- fi-ivb-3770: [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-ivb-3770/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@prime_self_import@basic-with_one_bo_two_files:
- fi-tgl-y: [DMESG-WARN][11] ([CI#94] / [i915#402]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
#### Warnings ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [TIMEOUT][13] ([fdo#112271] / [i915#816]) -> [INCOMPLETE][14] ([i915#45])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-byt-j1900/igt@gem_close_race@basic-threads.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-byt-j1900/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][15] ([i915#563]) -> [DMESG-FAIL][16] ([i915#725])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-hsw-4770r/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [DMESG-FAIL][17] ([i915#770]) -> [DMESG-FAIL][18] ([i915#553] / [i915#725])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/fi-hsw-4770/igt@i915_selftest@live_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/fi-hsw-4770/igt@i915_selftest@live_blt.html
[CI#94]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/94
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#505]: https://gitlab.freedesktop.org/drm/intel/issues/505
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#563]: https://gitlab.freedesktop.org/drm/intel/issues/563
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
Participating hosts (52 -> 43)
------------------------------
Additional (1): fi-snb-2520m
Missing (10): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-kbl-x1275 fi-kbl-7560u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5382 -> IGTPW_3985
CI-20190529: 20190529
CI_DRM_7806: 0b551226df5e5b84044705d5fd76571da70f3163 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3985: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/index.html
IGT_5382: 8dbe5ce61baa2d563d4dd7c56a018bb1e1077467 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_concurrent: Move simultaneously allowed
2020-01-24 6:10 [igt-dev] [PATCH i-g-t 0/1] tests/kms_concurrent: Move simultaneously allowed Mohammed Khajapasha
2020-01-24 6:10 ` [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread Mohammed Khajapasha
2020-01-24 8:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Move simultaneously allowed Patchwork
@ 2020-01-26 7:04 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2020-01-26 7:04 UTC (permalink / raw)
To: Mohammed Khajapasha; +Cc: igt-dev
== Series Details ==
Series: tests/kms_concurrent: Move simultaneously allowed
URL : https://patchwork.freedesktop.org/series/72511/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7806_full -> IGTPW_3985_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/index.html
Known issues
------------
Here are the changes found in IGTPW_3985_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@close-race:
- shard-tglb: [PASS][1] -> [TIMEOUT][2] ([fdo#112126] / [fdo#112271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb5/igt@gem_busy@close-race.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-tglb1/igt@gem_busy@close-race.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb2/igt@gem_ctx_isolation@vcs1-dirty-create.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +5 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb3/igt@gem_exec_async@concurrent-writes-bsd.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb1/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +11 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@gem_exec_schedule@promotion-bsd1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb5/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [PASS][9] -> [INCOMPLETE][10] ([i915#61]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][11] -> [FAIL][12] ([i915#520]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870] / [i915#478]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-snb5/igt@gem_userptr_blits@sync-unmap.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-snb4/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rps@reset:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#413])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb6/igt@i915_pm_rps@reset.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-tglb8/igt@i915_pm_rps@reset.html
* igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#54])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk3/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk3/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html
- shard-apl: [PASS][19] -> [FAIL][20] ([i915#54])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html
- shard-kbl: [PASS][21] -> [FAIL][22] ([i915#54])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-64x64-onscreen.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: [PASS][23] -> [FAIL][24] ([i915#96])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw5/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy.html
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
- shard-glk: [PASS][25] -> [FAIL][26] ([i915#169] / [i915#52] / [i915#54])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk9/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk3/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-render:
- shard-glk: [PASS][27] -> [FAIL][28] ([i915#49])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-render.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk8/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-iclb: [PASS][29] -> [INCOMPLETE][30] ([i915#140]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt:
- shard-tglb: [PASS][31] -> [FAIL][32] ([i915#49]) +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#180]) +5 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#109441]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb8/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@perf_pmu@busy-vcs1:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#112080]) +9 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@perf_pmu@busy-vcs1.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb5/igt@perf_pmu@busy-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +5 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-kbl3/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-iclb: [SKIP][41] ([fdo#109276] / [fdo#112080]) -> [PASS][42] +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb3/igt@gem_ctx_isolation@vcs1-s3.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb1/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_persistence@vecs0-mixed-process:
- shard-glk: [FAIL][43] ([i915#679]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk3/igt@gem_ctx_persistence@vecs0-mixed-process.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk1/igt@gem_ctx_persistence@vecs0-mixed-process.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][45] ([fdo#110854]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb5/igt@gem_exec_balancer@smoke.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@in-order-bsd2:
- shard-iclb: [SKIP][47] ([fdo#109276]) -> [PASS][48] +13 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb7/igt@gem_exec_schedule@in-order-bsd2.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb2/igt@gem_exec_schedule@in-order-bsd2.html
* igt@gem_exec_schedule@pi-shared-iova-bsd:
- shard-iclb: [SKIP][49] ([i915#677]) -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb4/igt@gem_exec_schedule@pi-shared-iova-bsd.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb8/igt@gem_exec_schedule@pi-shared-iova-bsd.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][51] ([fdo#112146]) -> [PASS][52] +7 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-hsw: [INCOMPLETE][53] ([i915#530] / [i915#61]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-thrashing:
- shard-apl: [INCOMPLETE][55] ([fdo#103927]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl8/igt@gem_persistent_relocs@forked-thrashing.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-apl3/igt@gem_persistent_relocs@forked-thrashing.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][57] ([fdo#111870] / [i915#478]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][59] ([fdo#110789] / [fdo#111870] / [i915#478]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][61] ([i915#454]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rps@waitboost:
- shard-iclb: [FAIL][63] ([i915#413]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb3/igt@i915_pm_rps@waitboost.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb3/igt@i915_pm_rps@waitboost.html
* igt@i915_selftest@mock_requests:
- shard-glk: [INCOMPLETE][65] ([i915#58] / [k.org#198133]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk7/igt@i915_selftest@mock_requests.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk6/igt@i915_selftest@mock_requests.html
- shard-tglb: [INCOMPLETE][67] ([i915#472]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb6/igt@i915_selftest@mock_requests.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-tglb4/igt@i915_selftest@mock_requests.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [FAIL][69] ([i915#72]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-suspend:
- shard-apl: [DMESG-WARN][71] ([i915#180]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-apl8/igt@kms_flip@flip-vs-suspend.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-apl6/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: [FAIL][73] ([i915#407]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-glk6/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-glk2/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc:
- shard-snb: [DMESG-WARN][75] ([i915#478]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-snb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-tglb: [FAIL][77] ([i915#49]) -> [PASS][78] +5 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb4/igt@kms_psr@psr2_cursor_render.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-b-wait-busy-hang:
- shard-hsw: [INCOMPLETE][81] ([CI#80] / [i915#61]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw7/igt@kms_vblank@pipe-b-wait-busy-hang.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw1/igt@kms_vblank@pipe-b-wait-busy-hang.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][83] ([fdo#112080]) -> [PASS][84] +9 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb3/igt@perf_pmu@busy-no-semaphores-vcs1.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb2/igt@perf_pmu@busy-no-semaphores-vcs1.html
* igt@prime_mmap_coherency@ioctl-errors:
- shard-hsw: [FAIL][85] ([i915#831]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw2/igt@prime_mmap_coherency@ioctl-errors.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw7/igt@prime_mmap_coherency@ioctl-errors.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][87] ([fdo#109276] / [fdo#112080]) -> [FAIL][88] ([IGT#28])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-iclb1/igt@gem_ctx_isolation@vcs1-nonpriv.html
* igt@gem_tiled_blits@interruptible:
- shard-hsw: [FAIL][89] ([i915#818]) -> [FAIL][90] ([i915#694])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw1/igt@gem_tiled_blits@interruptible.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw2/igt@gem_tiled_blits@interruptible.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][91] ([fdo#111870] / [i915#478]) -> [DMESG-WARN][92] ([fdo#110789] / [fdo#111870] / [i915#478])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@kms_atomic_transition@3x-modeset-transitions:
- shard-hsw: [SKIP][93] ([fdo#109271] / [i915#439]) -> [SKIP][94] ([fdo#109271])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-hsw5/igt@kms_atomic_transition@3x-modeset-transitions.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-hsw7/igt@kms_atomic_transition@3x-modeset-transitions.html
* igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary:
- shard-tglb: [FAIL][95] ([i915#160]) -> [FAIL][96] ([i915#49])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7806/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-shrfb-scaledprimary.html
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271
[i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140
[i915#160]: https://gitlab.freedesktop.org/drm/intel/issues/160
[i915#169]: https://gitlab.freedesktop.org/drm/intel/issues/169
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#407]: https://gitlab.freedesktop.org/drm/intel/issues/407
[i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413
[i915#439]: https://gitlab.freedesktop.org/drm/intel/issues/439
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#478]: https://gitlab.freedesktop.org/drm/intel/issues/478
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#520]: https://gitlab.freedesktop.org/drm/intel/issues/520
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#818]: https://gitlab.freedesktop.org/drm/intel/issues/818
[i915#831]: https://gitlab.freedesktop.org/drm/intel/issues/831
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5382 -> IGTPW_3985
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7806: 0b551226df5e5b84044705d5fd76571da70f3163 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3985: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/index.html
IGT_5382: 8dbe5ce61baa2d563d4dd7c56a018bb1e1077467 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3985/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread
2020-01-24 6:10 ` [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread Mohammed Khajapasha
@ 2020-01-27 11:37 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 5+ messages in thread
From: Juha-Pekka Heikkila @ 2020-01-27 11:37 UTC (permalink / raw)
To: Mohammed Khajapasha, igt-dev; +Cc: juha-pekka.heikkila
Look ok to me.
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 24.1.2020 8.10, Mohammed Khajapasha wrote:
> High resolution consumes more bandwidth so if amount of max planes is
> calculated during low resolution switch back to high resolution will
> immediately fail with bandwidth problem.
>
> To avoid bandwidth exceed,move the simultaneously allowed planes to
> before switching to low resolution mode in main thread.
>
> Signed-off-by: Mohammed Khajapasha <mohammed.khajapasha@intel.com>
> ---
> tests/kms_concurrent.c | 65 +++++++++++++++++++-----------------------
> 1 file changed, 30 insertions(+), 35 deletions(-)
>
> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> index a0280d15..14ca5fab 100644
> --- a/tests/kms_concurrent.c
> +++ b/tests/kms_concurrent.c
> @@ -57,33 +57,11 @@ struct {
> static void test_init(data_t *data, enum pipe pipe, int n_planes,
> igt_output_t *output)
> {
> - drmModeModeInfo *mode;
> - igt_plane_t *primary;
> - int ret;
> -
> data->plane = calloc(n_planes, sizeof(*data->plane));
> igt_assert_f(data->plane != NULL, "Failed to allocate memory for planes\n");
>
> data->fb = calloc(n_planes, sizeof(struct igt_fb));
> igt_assert_f(data->fb != NULL, "Failed to allocate memory for FBs\n");
> -
> - igt_output_set_pipe(output, pipe);
> -
> - primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> - data->plane[primary->index] = primary;
> -
> - mode = igt_output_get_mode(output);
> -
> - igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
> - DRM_FORMAT_XRGB8888,
> - LOCAL_I915_FORMAT_MOD_X_TILED,
> - 0.0f, 0.0f, 1.0f,
> - &data->fb[primary->index]);
> -
> - igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
> -
> - ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> - igt_skip_on(ret != 0);
> }
>
> static void test_fini(data_t *data, enum pipe pipe, int n_planes,
> @@ -184,7 +162,6 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
> y[primary->index] = 0;
> for (i = 0; i < max_planes; i++) {
> igt_plane_t *plane = igt_output_get_plane(output, i);
> - int ret;
>
> if (plane->type == DRM_PLANE_TYPE_PRIMARY)
> continue;
> @@ -207,18 +184,7 @@ prepare_planes(data_t *data, enum pipe pipe, int max_planes,
>
> igt_plane_set_position(data->plane[i], x[i], y[i]);
> igt_plane_set_fb(data->plane[i], &data->fb[i]);
> -
> - ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> - if (ret) {
> - igt_plane_set_fb(data->plane[i], NULL);
> - igt_remove_fb(data->drm_fd, &data->fb[i]);
> - data->plane[i] = NULL;
> - break;
> - }
> }
> - max_planes = i;
> -
> - igt_assert_lt(0, max_planes);
>
> /* primary plane */
> data->plane[primary->index] = primary;
> @@ -282,10 +248,39 @@ test_resolution_with_output(data_t *data, enum pipe pipe, igt_output_t *output)
> const drmModeModeInfo *mode_hi, *mode_lo;
> int iterations = opt.iterations < 1 ? 1 : opt.iterations;
> bool loop_forever = opt.iterations == LOOP_FOREVER ? true : false;
> - int i;
> + int i, c, ret;
> + int max_planes = data->display.pipes[pipe].n_planes;
> + igt_plane_t *primary;
> + drmModeModeInfo *mode;
>
> i = 0;
> while (i < iterations || loop_forever) {
> + igt_output_set_pipe(output, pipe);
> + for (c = 0; c < max_planes; c++) {
> + igt_plane_t *plane = igt_output_get_plane(output, c);
> +
> + if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> + continue;
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + data->plane[primary->index] = primary;
> + mode = igt_output_get_mode(output);
> + igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
> + DRM_FORMAT_XRGB8888,
> + LOCAL_I915_FORMAT_MOD_X_TILED,
> + 0.0f, 0.0f, 1.0f,
> + &data->fb[primary->index]);
> + igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
> + ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
> + if (ret) {
> + igt_plane_set_fb(data->plane[i], NULL);
> + igt_remove_fb(data->drm_fd, &data->fb[i]);
> + data->plane[i] = NULL;
> + break;
> + }
> + }
> + max_planes = c;
> + igt_assert_lt(0, max_planes);
> +
> mode_hi = igt_output_get_mode(output);
> mode_lo = get_lowres_mode(data, mode_hi, output);
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-27 11:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-24 6:10 [igt-dev] [PATCH i-g-t 0/1] tests/kms_concurrent: Move simultaneously allowed Mohammed Khajapasha
2020-01-24 6:10 ` [igt-dev] [PATCH i-g-t 1/1] tests/kms_concurrent: Move simultaneously allowed planes to main thread Mohammed Khajapasha
2020-01-27 11:37 ` Juha-Pekka Heikkila
2020-01-24 8:59 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_concurrent: Move simultaneously allowed Patchwork
2020-01-26 7:04 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.