[Intel-wired-lan] [PATCH v1] igc: Fix the typo in the comment

[Intel-wired-lan] [PATCH v1] igc: Fix the typo in the comment

[Sasha Neftin]

Fix the typo and comment to be correspond to the i225 device

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
---
 drivers/net/ethernet/intel/igc/igc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
index 5d38d0faeced..6fb222e76293 100644
--- a/drivers/net/ethernet/intel/igc/igc.h
+++ b/drivers/net/ethernet/intel/igc/igc.h
@@ -112,7 +112,7 @@ extern char igc_driver_version[];
 #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
 
 /* Transmit and receive latency (for PTP timestamps) */
-/* FIXME: These values were estimated using the ones that i210 has as
+/* These values were estimated using the ones that i225 has as
  * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
  * need to confirm them.
  */
-- 
2.11.0

[Intel-wired-lan] [PATCH v1] igc: Fix the typo in the comment

[Paul Menzel]

Dear Sasha,


Thank you for the patch. The article *the* could be removed from the 
commit message summary.

 > Fix typo in comment

Am 19.01.20 um 09:44 schrieb Sasha Neftin:
> Fix the typo and comment to be correspond to the i225 device

*to correspond*

Please mention *why* the FIXME is removed. The comment still says, they 
need to be confirmed. If the values were confirmed in the mean-time, 
please document in the commit message by whom, and remove the whole comment.

> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>   drivers/net/ethernet/intel/igc/igc.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h
> index 5d38d0faeced..6fb222e76293 100644
> --- a/drivers/net/ethernet/intel/igc/igc.h
> +++ b/drivers/net/ethernet/intel/igc/igc.h
> @@ -112,7 +112,7 @@ extern char igc_driver_version[];
>   #define IGC_RX_HDR_LEN			IGC_RXBUFFER_256
>   
>   /* Transmit and receive latency (for PTP timestamps) */
> -/* FIXME: These values were estimated using the ones that i210 has as
> +/* These values were estimated using the ones that i225 has as
>    * basis, they seem to provide good numbers with ptp4l/phc2sys, but we
>    * need to confirm them.
>    */


Kind regards,

Paul

[Intel-wired-lan] [PATCH v1] igc: Fix the typo in the comment

[Neftin, Sasha]

On 1/19/2020 13:06, Paul Menzel wrote:
> Fix typo in comment
We need to do more tests with PTP tools to confirm that. I will return 
meanwhile "FIXME". Thanks Paul - I will send v2.