From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com> To: "liwei.song@windriver.com" <liwei.song@windriver.com>, "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>, "Brandeburg, Jesse" <jesse.brandeburg@intel.com> Cc: "davem@davemloft.net" <davem@davemloft.net>, "kuba@kernel.org" <kuba@kernel.org>, "Venkataramanan, Anirudh" <anirudh.venkataramanan@intel.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] ice: set the value of global config lock timeout longer Date: Tue, 20 Apr 2021 22:48:29 +0000 [thread overview] Message-ID: <7d85412de58342e4469efdfdc6196925ce770993.camel@intel.com> (raw) In-Reply-To: <20210419093106.6487-1-liwei.song@windriver.com> On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote: > It may need hold Global Config Lock a longer time when download DDP > package file, extend the timeout value to 5000ms to ensure that > download can be finished before other AQ command got time to run, > this will fix the issue below when probe the device, 5000ms is a test > value that work with both Backplane and BreakoutCable NVM image: > > ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG > ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: > ICE_ERR_AQ_TIMEOUT > ice 0000:f4:00.0: probe failed due to setup PF switch: -12 > ice: probe of 0000:f4:00.0 failed with error -12 Hi Liwei, We haven't encountered this issue before. Can you provide some more info on your setup or how you're coming across this issue? Perhaps, lspci output and some more of the dmesg log? We'd like to try to reproduce this so we can invesitgate it further. Thanks, Tony > Signed-off-by: Liwei Song <liwei.song@windriver.com> > --- > drivers/net/ethernet/intel/ice/ice_type.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_type.h > b/drivers/net/ethernet/intel/ice/ice_type.h > index 266036b7a49a..8a90c47e337d 100644 > --- a/drivers/net/ethernet/intel/ice/ice_type.h > +++ b/drivers/net/ethernet/intel/ice/ice_type.h > @@ -63,7 +63,7 @@ enum ice_aq_res_ids { > /* FW update timeout definitions are in milliseconds */ > #define ICE_NVM_TIMEOUT 180000 > #define ICE_CHANGE_LOCK_TIMEOUT 1000 > -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 3000 > +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 5000 > > enum ice_aq_res_access_type { > ICE_RES_READ = 1,
WARNING: multiple messages have this Message-ID (diff)
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH] ice: set the value of global config lock timeout longer Date: Tue, 20 Apr 2021 22:48:29 +0000 [thread overview] Message-ID: <7d85412de58342e4469efdfdc6196925ce770993.camel@intel.com> (raw) In-Reply-To: <20210419093106.6487-1-liwei.song@windriver.com> On Mon, 2021-04-19 at 17:31 +0800, Liwei Song wrote: > It may need hold Global Config Lock a longer time when download DDP > package file, extend the timeout value to 5000ms to ensure that > download can be finished before other AQ command got time to run, > this will fix the issue below when probe the device, 5000ms is a test > value that work with both Backplane and BreakoutCable NVM image: > > ice 0000:f4:00.0: VSI 12 failed lan queue config, error ICE_ERR_CFG > ice 0000:f4:00.0: Failed to delete VSI 12 in FW - error: > ICE_ERR_AQ_TIMEOUT > ice 0000:f4:00.0: probe failed due to setup PF switch: -12 > ice: probe of 0000:f4:00.0 failed with error -12 Hi Liwei, We haven't encountered this issue before. Can you provide some more info on your setup or how you're coming across this issue? Perhaps, lspci output and some more of the dmesg log? We'd like to try to reproduce this so we can invesitgate it further. Thanks, Tony > Signed-off-by: Liwei Song <liwei.song@windriver.com> > --- > drivers/net/ethernet/intel/ice/ice_type.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ice/ice_type.h > b/drivers/net/ethernet/intel/ice/ice_type.h > index 266036b7a49a..8a90c47e337d 100644 > --- a/drivers/net/ethernet/intel/ice/ice_type.h > +++ b/drivers/net/ethernet/intel/ice/ice_type.h > @@ -63,7 +63,7 @@ enum ice_aq_res_ids { > /* FW update timeout definitions are in milliseconds */ > #define ICE_NVM_TIMEOUT 180000 > #define ICE_CHANGE_LOCK_TIMEOUT 1000 > -#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 3000 > +#define ICE_GLOBAL_CFG_LOCK_TIMEOUT 5000 > > enum ice_aq_res_access_type { > ICE_RES_READ = 1,
next prev parent reply other threads:[~2021-04-20 22:48 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 9:31 [PATCH] ice: set the value of global config lock timeout longer Liwei Song 2021-04-19 9:31 ` [Intel-wired-lan] " Liwei Song 2021-04-20 22:48 ` Nguyen, Anthony L [this message] 2021-04-20 22:48 ` Nguyen, Anthony L 2021-04-21 2:29 ` Liwei Song 2021-04-21 2:29 ` [Intel-wired-lan] " Liwei Song 2021-04-22 18:16 ` Nguyen, Anthony L 2021-04-22 18:16 ` [Intel-wired-lan] " Nguyen, Anthony L 2021-05-04 0:44 ` Nguyen, Anthony L 2021-05-04 0:44 ` [Intel-wired-lan] " Nguyen, Anthony L 2021-05-06 1:54 ` Liwei Song 2021-05-06 1:54 ` [Intel-wired-lan] " Liwei Song 2021-05-12 21:48 ` Brelinski, TonyX 2021-05-12 21:48 ` Brelinski, TonyX
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7d85412de58342e4469efdfdc6196925ce770993.camel@intel.com \ --to=anthony.l.nguyen@intel.com \ --cc=anirudh.venkataramanan@intel.com \ --cc=davem@davemloft.net \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jesse.brandeburg@intel.com \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=liwei.song@windriver.com \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.