* [PATCH v3 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency
@ 2022-08-27 14:56 Bryan O'Donoghue
2022-08-27 14:56 ` [PATCH v3 1/2] dt-bindings: spmi: " Bryan O'Donoghue
2022-08-27 14:56 ` [PATCH v3 2/2] arm64: dts: qcom: pm8350c: Drop PWM reg declaration Bryan O'Donoghue
0 siblings, 2 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2022-08-27 14:56 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree
Cc: bryan.odonoghue
V3:
- Splits dtsi and yaml
- Uses Krzysztof's suggested commit log in the yaml
V2:
The accompanying patch removes reg = <> and pwm@reg from the yaml and dtsi.
This follows on from discussions between Bupesh, Dmitry, Bjorn, Krzysztof and myself.
https://lore.kernel.org/all/20220719205058.1004942-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220721195502.1525214-1-bhupesh.sharma@linaro.org/
https://lore.kernel.org/all/20220822120300.2633790-1-bryan.odonoghue@linaro.org/
The previous discussion tended towards either removing pwm@reg and reg = <> or
extending out the yaml to support multiple reg declarations for PWM compatible.
This patch does the former. I've left node: label in place, dropped both pwm@reg
and reg = <> I kept "label: nodename" though because it looked more like what we
already have for rpm regulators.
Per our previous discussion I've modified the yaml and dtsi in one go.
Bryan O'Donoghue (2):
dt-bindings: spmi: Drop PWM reg dependency
arm64: dts: qcom: pm8350c: Drop PWM reg declaration
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 +--
2 files changed, 5 insertions(+), 6 deletions(-)
--
2.37.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 1/2] dt-bindings: spmi: Drop PWM reg dependency
2022-08-27 14:56 [PATCH v3 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency Bryan O'Donoghue
@ 2022-08-27 14:56 ` Bryan O'Donoghue
2022-08-28 6:42 ` Krzysztof Kozlowski
2022-08-28 6:50 ` Krzysztof Kozlowski
2022-08-27 14:56 ` [PATCH v3 2/2] arm64: dts: qcom: pm8350c: Drop PWM reg declaration Bryan O'Donoghue
1 sibling, 2 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2022-08-27 14:56 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree
Cc: bryan.odonoghue, Krzysztof Kozlowski
The PWM node is not a separate device and is expected to be part of parent
SPMI PMIC node, thus it obtains the address space from the parent. One IO
address in "reg" is also not correct description because LPG block maps to
several regions.
Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC")
Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 65cbc6dee545e..2a5bafe0660a0 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -92,6 +92,10 @@ properties:
type: object
$ref: /schemas/regulator/regulator.yaml#
+ pwm:
+ type: object
+ $ref: /schemas/leds/leds-qcom-lpg.yaml#
+
patternProperties:
"^adc@[0-9a-f]+$":
type: object
@@ -117,10 +121,6 @@ patternProperties:
type: object
$ref: /schemas/power/reset/qcom,pon.yaml#
- "pwm@[0-9a-f]+$":
- type: object
- $ref: /schemas/leds/leds-qcom-lpg.yaml#
-
"^rtc@[0-9a-f]+$":
type: object
$ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
--
2.37.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: spmi: Drop PWM reg dependency
2022-08-27 14:56 ` [PATCH v3 1/2] dt-bindings: spmi: " Bryan O'Donoghue
@ 2022-08-28 6:42 ` Krzysztof Kozlowski
2022-08-28 6:50 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-28 6:42 UTC (permalink / raw)
To: Bryan O'Donoghue, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree
On 27/08/2022 17:56, Bryan O'Donoghue wrote:
> The PWM node is not a separate device and is expected to be part of parent
> SPMI PMIC node, thus it obtains the address space from the parent. One IO
> address in "reg" is also not correct description because LPG block maps to
> several regions.
>
> Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC")
> Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 1/2] dt-bindings: spmi: Drop PWM reg dependency
2022-08-27 14:56 ` [PATCH v3 1/2] dt-bindings: spmi: " Bryan O'Donoghue
2022-08-28 6:42 ` Krzysztof Kozlowski
@ 2022-08-28 6:50 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-28 6:50 UTC (permalink / raw)
To: Bryan O'Donoghue, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree
On 27/08/2022 17:56, Bryan O'Donoghue wrote:
> The PWM node is not a separate device and is expected to be part of parent
> SPMI PMIC node, thus it obtains the address space from the parent. One IO
> address in "reg" is also not correct description because LPG block maps to
> several regions.
>
The subject prefix is no correct:
dt-biindings: mfd: qcom,spmi-pmic:
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 2/2] arm64: dts: qcom: pm8350c: Drop PWM reg declaration
2022-08-27 14:56 [PATCH v3 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency Bryan O'Donoghue
2022-08-27 14:56 ` [PATCH v3 1/2] dt-bindings: spmi: " Bryan O'Donoghue
@ 2022-08-27 14:56 ` Bryan O'Donoghue
2022-08-28 6:42 ` Krzysztof Kozlowski
1 sibling, 1 reply; 6+ messages in thread
From: Bryan O'Donoghue @ 2022-08-27 14:56 UTC (permalink / raw)
To: agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree
Cc: bryan.odonoghue
The PWM is a part of the SPMI PMIC block and maps several different
addresses within the SPMI block. It is not accurate to describe as pwm@reg
as a result.
Fixes: 5be66d2dc887 ("arm64: dts: qcom: pm8350c: Add pwm support")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
arch/arm64/boot/dts/qcom/pm8350c.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
index e0bbb67717fec..f28e71487d5c7 100644
--- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
@@ -30,9 +30,8 @@ pm8350c_gpios: gpio@8800 {
#interrupt-cells = <2>;
};
- pm8350c_pwm: pwm@e800 {
+ pm8350c_pwm: pwm {
compatible = "qcom,pm8350c-pwm";
- reg = <0xe800>;
#pwm-cells = <2>;
status = "disabled";
};
--
2.37.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/2] arm64: dts: qcom: pm8350c: Drop PWM reg declaration
2022-08-27 14:56 ` [PATCH v3 2/2] arm64: dts: qcom: pm8350c: Drop PWM reg declaration Bryan O'Donoghue
@ 2022-08-28 6:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-28 6:42 UTC (permalink / raw)
To: Bryan O'Donoghue, agross, andersson, konrad.dybcio, robh+dt,
krzysztof.kozlowski+dt, linux-arm-msm, devicetree
On 27/08/2022 17:56, Bryan O'Donoghue wrote:
> The PWM is a part of the SPMI PMIC block and maps several different
> addresses within the SPMI block. It is not accurate to describe as pwm@reg
> as a result.
>
> Fixes: 5be66d2dc887 ("arm64: dts: qcom: pm8350c: Add pwm support")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-08-28 6:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-27 14:56 [PATCH v3 0/2] arm64: dts: qcom: pwm: Drop PWM reg dependency Bryan O'Donoghue
2022-08-27 14:56 ` [PATCH v3 1/2] dt-bindings: spmi: " Bryan O'Donoghue
2022-08-28 6:42 ` Krzysztof Kozlowski
2022-08-28 6:50 ` Krzysztof Kozlowski
2022-08-27 14:56 ` [PATCH v3 2/2] arm64: dts: qcom: pm8350c: Drop PWM reg declaration Bryan O'Donoghue
2022-08-28 6:42 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.