[PATCH net-next] net: phy: Do not check Link status when loopback is enabled

[PATCH net-next] net: phy: Do not check Link status when loopback is enabled

[Jose Abreu]

While running stmmac selftests I found that in my 1G setup some tests
were failling when running with PHY loopback enabled.

It looks like when loopback is enabled the PHY will report that Link is
down even though there is a valid connection.

As in loopback mode the data will not be sent anywhere we can bypass the
logic of checking if Link is valid thus saving unecessary reads.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>

---
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/net/phy/phy.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 35d29a823af8..7c92afd36bbe 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -525,6 +525,12 @@ static int phy_check_link_status(struct phy_device *phydev)
 
 	WARN_ON(!mutex_is_locked(&phydev->lock));
 
+	/* Keep previous state if loopback is enabled because some PHYs
+	 * report that Link is Down when loopback is enabled.
+	 */
+	if (phydev->loopback_enabled)
+		return 0;
+
 	err = phy_read_status(phydev);
 	if (err)
 		return err;
-- 
2.7.4

Re: [PATCH net-next] net: phy: Do not check Link status when loopback is enabled

[David Miller]

From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Thu,  5 Sep 2019 13:43:10 +0200

> While running stmmac selftests I found that in my 1G setup some tests
> were failling when running with PHY loopback enabled.
> 
> It looks like when loopback is enabled the PHY will report that Link is
> down even though there is a valid connection.
> 
> As in loopback mode the data will not be sent anywhere we can bypass the
> logic of checking if Link is valid thus saving unecessary reads.
> 
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>

Applied to net-next.