All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo Noronha Silva" <gustavo@noronha.eti.br>
To: "'Markus Armbruster '" <armbru@redhat.com>
Cc: 'Peter Maydell ' <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, 'Gerd Hoffmann ' <kraxel@redhat.com>
Subject: Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed
Date: Fri, 30 Apr 2021 09:02:23 -0300	[thread overview]
Message-ID: <7debaf60-9f07-41c3-948e-1fe19196d4bc@www.fastmail.com> (raw)
In-Reply-To: <87r1isxcm2.fsf@dusky.pond.sub.org>

Hey,

On Fri, Apr 30, 2021, at 7:58 AM, Markus Armbruster wrote:
> > I did not add a Since: here because I wasn't sure how that is handled. Should I add something or is that taken care of at the time of release somehow?
> 
> You should add (since 6.1) at the end, like this
> 
> # @full-grab: Capture all key presses, including system combos. This
> #             requires accessibility permissions, since it performs
> #             a global grab on key events. (default: off)
> #             See https://support.apple.com/en-in/guide/mac-help/mh32356/mac
> #             (Since 6.1)
> 
> Same for @swap-option-command in the next patch.
> 
> Glad you asked, I'm quite prone to not noticing missing these in
> review...

One last question, please bear with me =). Looking at the other options I see that some have a single Since tag for the whole thing, I assume because they were all added in one go. For instance, @DisplayGLMode has a single Since: 3.0 at the bottom and not one for each of the options. Should I do that as well considering I'm adding @DisplayCocoa, or is the per-option Since still preferred?

Thanks again,

Gustavo


  reply	other threads:[~2021-04-30 13:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 23:47 [PATCH 0/2] cocoa: keyboard quality of life gustavo
2021-04-29 23:47 ` [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed gustavo
2021-04-30  7:20   ` Markus Armbruster
2021-04-30 10:02     ` Gustavo Noronha Silva
2021-04-30 10:10       ` Gustavo Noronha Silva
2021-04-30 10:58         ` Markus Armbruster
2021-04-30 12:02           ` Gustavo Noronha Silva [this message]
2021-04-30 14:36             ` Markus Armbruster
2021-04-30 10:54       ` Markus Armbruster
2021-04-30  8:05   ` 'Gerd Hoffmann '
2021-04-30  9:43     ` Gustavo Noronha Silva
2021-04-29 23:47 ` [PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default gustavo
2021-04-30  7:25   ` Markus Armbruster
2021-04-30  8:04   ` 'Gerd Hoffmann '
2021-04-30 10:36     ` Gustavo Noronha Silva
2022-03-06 11:11 [PATCH 0/2] cocoa: keyboard quality of life Akihiko Odaki
2022-03-06 11:11 ` [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed Akihiko Odaki
2022-03-06 11:28   ` BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7debaf60-9f07-41c3-948e-1fe19196d4bc@www.fastmail.com \
    --to=gustavo@noronha.eti.br \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.