All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: "Gustavo Noronha Silva" <gustavo@noronha.eti.br>
Cc: 'Peter Maydell ' <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, 'Gerd Hoffmann ' <kraxel@redhat.com>
Subject: Re: [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed
Date: Fri, 30 Apr 2021 12:54:56 +0200	[thread overview]
Message-ID: <87y2d0xcsf.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <9e59000c-eb07-45b2-8b39-3a705561c440@www.fastmail.com> (Gustavo Noronha Silva's message of "Fri, 30 Apr 2021 07:02:46 -0300")

"Gustavo Noronha Silva" <gustavo@noronha.eti.br> writes:

> Hey Markus,
>
> On Fri, Apr 30, 2021, at 4:20 AM, Markus Armbruster wrote:
>> Please indent like this
>> 
>>    # @full-grab: Capture all key presses, including system combos. This
>>    #             requires accessibility permissions, since it performs
>>    #             a global grab on key events. (default: off)
>>    #             See https://support.apple.com/en-in/guide/mac-help/mh32356/mac
>
> Will do, but just to be sure, the surrounding comments have the second to last lines lined up to the C in Capture there, I assume that is what you mean?

Yes.

qapi-gen will complain when you indent subsequent lines too little.
Indenting them too much will be (mis-)interpreted as a definition list.

[...]



  parent reply	other threads:[~2021-04-30 11:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-29 23:47 [PATCH 0/2] cocoa: keyboard quality of life gustavo
2021-04-29 23:47 ` [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed gustavo
2021-04-30  7:20   ` Markus Armbruster
2021-04-30 10:02     ` Gustavo Noronha Silva
2021-04-30 10:10       ` Gustavo Noronha Silva
2021-04-30 10:58         ` Markus Armbruster
2021-04-30 12:02           ` Gustavo Noronha Silva
2021-04-30 14:36             ` Markus Armbruster
2021-04-30 10:54       ` Markus Armbruster [this message]
2021-04-30  8:05   ` 'Gerd Hoffmann '
2021-04-30  9:43     ` Gustavo Noronha Silva
2021-04-29 23:47 ` [PATCH 2/2] ui/cocoa: add option to swap Option and Command, enable by default gustavo
2021-04-30  7:25   ` Markus Armbruster
2021-04-30  8:04   ` 'Gerd Hoffmann '
2021-04-30 10:36     ` Gustavo Noronha Silva
2022-03-06 11:11 [PATCH 0/2] cocoa: keyboard quality of life Akihiko Odaki
2022-03-06 11:11 ` [PATCH 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed Akihiko Odaki
2022-03-06 11:28   ` BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y2d0xcsf.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=gustavo@noronha.eti.br \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.