All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH iproute2-next] tc: Fix compilation error with old iptables
@ 2018-03-27  9:20 Roi Dayan
  2018-03-27 13:40 ` David Ahern
  0 siblings, 1 reply; 2+ messages in thread
From: Roi Dayan @ 2018-03-27  9:20 UTC (permalink / raw)
  To: David Ahern; +Cc: netdev, Stephen Hemminger, Eyal Birger, Roi Dayan

The compat_rev field does not exists in old versions of iptables.
e.g. iptables 1.4.

Fixes: dd29621578d2 ("tc: add em_ipt ematch for calling xtables matches from tc matching context")
Signed-off-by: Roi Dayan <roid@mellanox.com>
---
 tc/em_ipt.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tc/em_ipt.c b/tc/em_ipt.c
index 9d2b2f9b46d4..aa2edd63c550 100644
--- a/tc/em_ipt.c
+++ b/tc/em_ipt.c
@@ -41,7 +41,9 @@ static struct xtables_globals em_tc_ipt_globals = {
 	.program_version = "0.1",
 	.orig_opts = original_opts,
 	.opts = original_opts,
+#if (XTABLES_VERSION_CODE >= 11)
 	.compat_rev = xtables_compatible_revision,
+#endif
 };
 
 static struct xt_entry_match *fake_xt_entry_match(int data_size, void *data)
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH iproute2-next] tc: Fix compilation error with old iptables
  2018-03-27  9:20 [PATCH iproute2-next] tc: Fix compilation error with old iptables Roi Dayan
@ 2018-03-27 13:40 ` David Ahern
  0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2018-03-27 13:40 UTC (permalink / raw)
  To: Roi Dayan; +Cc: netdev, Stephen Hemminger, Eyal Birger

On 3/27/18 3:20 AM, Roi Dayan wrote:
> The compat_rev field does not exists in old versions of iptables.
> e.g. iptables 1.4.
> 
> Fixes: dd29621578d2 ("tc: add em_ipt ematch for calling xtables matches from tc matching context")
> Signed-off-by: Roi Dayan <roid@mellanox.com>
> ---
>  tc/em_ipt.c | 2 ++
>  1 file changed, 2 insertions(+)
> 

Applied to iproute2-next. Thanks,

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-27 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-27  9:20 [PATCH iproute2-next] tc: Fix compilation error with old iptables Roi Dayan
2018-03-27 13:40 ` David Ahern

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.