All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 17/41] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2
Date: Wed, 22 Mar 2017 08:13:12 +0100	[thread overview]
Message-ID: <7e2e83b7-2b4b-6683-a394-cf3b844a8999@denx.de> (raw)
In-Reply-To: <CANr=Z=ZUkNikRxuE0doSh+gOwvwNS1U2dykS_8ZDK-rUobdQyA@mail.gmail.com>

On 21.03.2017 18:21, Joe Hershberger wrote:
> On Tue, Mar 21, 2017 at 9:27 AM, Stefan Roese <sr@denx.de> wrote:
>> From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>>
>> The MVPP2_RXQ_CONFIG_REG register has a slightly different layout
>> between PPv2.1 and PPv2.2, so this commit adapts the functions modifying
>> this register to accommodate for both the PPv2.1 and PPv2.2 cases.
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>
> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
>
>> ---
>>
>>  drivers/net/mvpp2.c | 19 ++++++++++++-------
>>  1 file changed, 12 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/net/mvpp2.c b/drivers/net/mvpp2.c
>> index c5ac6d1b7f..edd985910c 100644
>> --- a/drivers/net/mvpp2.c
>> +++ b/drivers/net/mvpp2.c
>> @@ -91,9 +91,11 @@ do {                                                                 \
>>  #define     MVPP2_SNOOP_PKT_SIZE_MASK          0x1ff
>>  #define     MVPP2_SNOOP_BUF_HDR_MASK           BIT(9)
>>  #define     MVPP2_RXQ_POOL_SHORT_OFFS          20
>> -#define     MVPP2_RXQ_POOL_SHORT_MASK          0x700000
>> +#define     MVPP21_RXQ_POOL_SHORT_MASK         0x700000
>> +#define     MVPP22_RXQ_POOL_SHORT_MASK         0xf00000
>
> I guess these are just defined for completeness? Never used? Maybe
> just drop them?
>
> Obviously not important, so up to you.

Thanks for spotting. If it comes to a v2, then I'll remove those
defines.

Thanks,
Stefan

  reply	other threads:[~2017-03-22  7:13 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 14:27 [U-Boot] [PATCH v1 00/41] Add PPv2.2 support to the mvpp2 ethernet driver and enable it for A7k/8k Stefan Roese
2017-03-21 14:27 ` [U-Boot] [PATCH v1 01/41] bitops.h: Include bitsperlong.h as needed for GENMASK_ULL Stefan Roese
2017-03-21 15:02   ` Tom Rini
2017-03-21 16:53   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 02/41] net: mvpp2: Round up top tx buffer boundaries for dcache ops Stefan Roese
2017-03-21 16:55   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 03/41] net: mvpp2: simplify mvpp2_bm_bufs_add() Stefan Roese
2017-03-21 16:57   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 04/41] net: mvpp2: remove unused register definitions Stefan Roese
2017-03-21 16:58   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 05/41] net: mvpp2: fix indentation of MVPP2_EXT_GLOBAL_CTRL_DEFAULT Stefan Roese
2017-03-21 16:59   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 06/41] net: mvpp2: simplify MVPP2_PRS_RI_* definitions Stefan Roese
2017-03-21 17:01   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 07/41] net: mvpp2: enable building on 64-bit platforms Stefan Roese
2017-03-21 17:02   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 08/41] net: mvpp2: enable building on 64-bit platforms (more U-Boot specific) Stefan Roese
2017-03-21 17:03   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 09/41] net: mvpp2: use "dma" instead of "phys" where appropriate Stefan Roese
2017-03-21 17:04   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 10/41] net: mvpp2: remove support for buffer header Stefan Roese
2017-03-21 17:04   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 11/41] net: mvpp2: store physical address of buffer in rx_desc->buf_cookie Stefan Roese
2017-03-21 17:06   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 12/41] net: mvpp2: add and use accessors for TX/RX descriptors Stefan Roese
2017-03-21 17:07   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 13/41] net: mvpp2: add hw_version field in "struct mvpp2" Stefan Roese
2017-03-21 17:09   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 14/41] net: mvpp2: introduce an intermediate union for the TX/RX descriptors Stefan Roese
2017-03-21 17:10   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 15/41] net: mvpp2: introduce PPv2.2 HW descriptors and adapt accessors Stefan Roese
2017-03-21 17:13   ` Joe Hershberger
2017-03-22  7:11     ` Stefan Roese
2017-03-22  8:03       ` Thomas Petazzoni
2017-03-22  8:13         ` Stefan Roese
2017-03-21 14:27 ` [U-Boot] [PATCH v1 16/41] net: mvpp2: adjust the allocation/free of BM pools for PPv2.2 Stefan Roese
2017-03-21 17:18   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 17/41] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2 Stefan Roese
2017-03-21 17:21   ` Joe Hershberger
2017-03-22  7:13     ` Stefan Roese [this message]
2017-03-21 14:27 ` [U-Boot] [PATCH v1 18/41] net: mvpp2: adapt mvpp2_defaults_set() " Stefan Roese
2017-03-21 17:21   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 19/41] net: mvpp2: adjust mvpp2_{rxq, txq}_init for PPv2.2 Stefan Roese
2017-03-21 17:25   ` Joe Hershberger
2017-03-22  7:17     ` Stefan Roese
2017-03-21 14:27 ` [U-Boot] [PATCH v1 20/41] net: mvpp2: handle register mapping and access " Stefan Roese
2017-03-21 17:33   ` Joe Hershberger
2017-03-22  7:19     ` Stefan Roese
2017-03-21 14:27 ` [U-Boot] [PATCH v1 21/41] net: mvpp2: handle misc PPv2.1/PPv2.2 differences Stefan Roese
2017-03-21 17:35   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 22/41] net: mvpp2: add AXI bridge initialization for PPv2.2 Stefan Roese
2017-03-21 17:36   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 23/41] net: mvpp2: rework RXQ interrupt group " Stefan Roese
2017-03-21 17:38   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 24/41] net: mvpp2: adapt rxq distribution to PPv2.2 Stefan Roese
2017-03-21 17:42   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 25/41] net: mvpp2: finally add the PPv2.2 compatible string Stefan Roese
2017-03-21 17:42   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 26/41] net: mvpp2: Add MDIO support for PPv2.2 Stefan Roese
2017-03-21 17:44   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 27/41] net: mvpp2: Move probe function from MISC to ETH DM driver Stefan Roese
2017-03-21 17:47   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 28/41] net: mvpp2.c: Clear all buffer / descriptor areas before usage Stefan Roese
2017-03-21 17:47   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 29/41] net: mvpp2: Enable compilation for Armada 7K/8K platforms Stefan Roese
2017-03-21 17:50   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 30/41] arm64: marvell: dts: add PPv2.2 description to Armada 7K/8K Stefan Roese
2017-03-21 17:52   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 31/41] arm64: mvebu: armada-7k/8k: Enable MVPP2 ethernet driver Stefan Roese
2017-03-21 17:54   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 32/41] net: mvpp2: Handle eth device naming in multi-CP case correctly Stefan Roese
2017-03-21 17:56   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 33/41] net: mvpp2: Add remove function that is called before the OS is started Stefan Roese
2017-03-21 17:57   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 34/41] net: mvpp2: Add RX and TX FIFO configuration for PPv2.2 Stefan Roese
2017-03-21 17:59   ` Joe Hershberger
2017-03-22  7:27     ` Stefan Roese
2017-03-21 14:27 ` [U-Boot] [PATCH v1 35/41] net: include/phy.h: Add new PHY interface modes Stefan Roese
2017-03-21 18:00   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 36/41] net: mvpp2: Add Group-of-Ports and Net-Compex configuration for PPv2.2 Stefan Roese
2017-03-21 18:03   ` Joe Hershberger
2017-03-22  7:50     ` Stefan Roese
2017-03-21 14:27 ` [U-Boot] [PATCH v1 37/41] net: mvpp2: Enable PHY polling mode on PPv2.2 Stefan Roese
2017-03-21 18:04   ` Joe Hershberger
2017-03-21 14:27 ` [U-Boot] [PATCH v1 38/41] net: mvpp2: Configure SMI PHY address needed for PHY polling Stefan Roese
2017-03-21 18:05   ` Joe Hershberger
2017-03-21 14:28 ` [U-Boot] [PATCH v1 39/41] net: mvpp2: Remove unreferenced in_use_thresh from struct mvpp2_bm_pool Stefan Roese
2017-03-21 18:06   ` Joe Hershberger
2017-03-21 14:28 ` [U-Boot] [PATCH v1 40/41] arm64: mvebu: armada-7040-db.dts: Change eth1 speed from 2.5G to 1G Stefan Roese
2017-03-21 18:06   ` Joe Hershberger
2017-03-21 14:28 ` [U-Boot] [PATCH v1 41/41] arm64: mvebu: Enable CONFIG_PHY_MARVELL in Armada7k/8k-DB defconfig Stefan Roese
2017-03-21 18:07   ` Joe Hershberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e2e83b7-2b4b-6683-a394-cf3b844a8999@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.