* [PATCH -fixes] drm/vmwgfx: Fix buffer object eviction
@ 2018-09-14 7:35 Thomas Hellstrom
2018-09-14 7:45 ` Christian König
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Hellstrom @ 2018-09-14 7:35 UTC (permalink / raw)
To: linux-graphics-maintainer
Cc: pv-drivers, Thomas Hellstrom, Christian König, dri-devel
Commit 19be55701071 ("drm/ttm: add operation ctx to ttm_bo_validate v2")
introduced a regression where the vmwgfx driver refused to evict a
buffer that was still busy instead of waiting for it to become idle.
Fix this.
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
---
drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 1f134570b759..f0ab6b2313bb 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -3729,7 +3729,7 @@ int vmw_validate_single_buffer(struct vmw_private *dev_priv,
{
struct vmw_buffer_object *vbo =
container_of(bo, struct vmw_buffer_object, base);
- struct ttm_operation_ctx ctx = { interruptible, true };
+ struct ttm_operation_ctx ctx = { interruptible, false };
int ret;
if (vbo->pin_count > 0)
--
2.19.0.rc1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -fixes] drm/vmwgfx: Fix buffer object eviction
2018-09-14 7:35 [PATCH -fixes] drm/vmwgfx: Fix buffer object eviction Thomas Hellstrom
@ 2018-09-14 7:45 ` Christian König
2018-09-14 16:02 ` Thomas Hellstrom
0 siblings, 1 reply; 3+ messages in thread
From: Christian König @ 2018-09-14 7:45 UTC (permalink / raw)
To: Thomas Hellstrom, linux-graphics-maintainer; +Cc: pv-drivers, dri-devel
Am 14.09.2018 um 09:35 schrieb Thomas Hellstrom:
> Commit 19be55701071 ("drm/ttm: add operation ctx to ttm_bo_validate v2")
> introduced a regression where the vmwgfx driver refused to evict a
> buffer that was still busy instead of waiting for it to become idle.
>
> Fix this.
>
> Cc: Christian König <christian.koenig@amd.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
Ups, sorry for that. Patch is Reviewed-by: Christian König
<christian.koenig@amd.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 1f134570b759..f0ab6b2313bb 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> @@ -3729,7 +3729,7 @@ int vmw_validate_single_buffer(struct vmw_private *dev_priv,
> {
> struct vmw_buffer_object *vbo =
> container_of(bo, struct vmw_buffer_object, base);
> - struct ttm_operation_ctx ctx = { interruptible, true };
> + struct ttm_operation_ctx ctx = { interruptible, false };
> int ret;
>
> if (vbo->pin_count > 0)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -fixes] drm/vmwgfx: Fix buffer object eviction
2018-09-14 7:45 ` Christian König
@ 2018-09-14 16:02 ` Thomas Hellstrom
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Hellstrom @ 2018-09-14 16:02 UTC (permalink / raw)
To: Christian König, linux-graphics-maintainer; +Cc: pv-drivers, dri-devel
On 09/14/2018 09:45 AM, Christian König wrote:
> Am 14.09.2018 um 09:35 schrieb Thomas Hellstrom:
>> Commit 19be55701071 ("drm/ttm: add operation ctx to ttm_bo_validate v2")
>> introduced a regression where the vmwgfx driver refused to evict a
>> buffer that was still busy instead of waiting for it to become idle.
>>
>> Fix this.
>>
>> Cc: Christian König <christian.koenig@amd.com>
>> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
>
> Ups, sorry for that. Patch is Reviewed-by: Christian König
> <christian.koenig@amd.com>
Thanks!
/Thomas
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-14 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14 7:35 [PATCH -fixes] drm/vmwgfx: Fix buffer object eviction Thomas Hellstrom
2018-09-14 7:45 ` Christian König
2018-09-14 16:02 ` Thomas Hellstrom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.