All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <quic_wgong@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>
Cc: <ath11k@lists.infradead.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 01/15] mac80211: split bss_info_changed method
Date: Tue, 18 Oct 2022 17:50:43 +0800	[thread overview]
Message-ID: <7e72034a-497a-000c-d7bf-3ec974af9e1c@quicinc.com> (raw)
In-Reply-To: <d0994456d3a9ea00b5cc472df7822d53d189399e.camel@sipsolutions.net>

On 10/18/2022 4:53 PM, Johannes Berg wrote:
> On Tue, 2022-10-18 at 16:52 +0800, Wen Gong wrote:
>> On 10/18/2022 4:50 PM, Johannes Berg wrote:
>>> On Tue, 2022-10-18 at 16:47 +0800, Wen Gong wrote:
>>>>> +	if (changed & ~BSS_CHANGED_VIF_CFG_FLAGS) {
>>>>> +		/* FIXME: should be for each link */
>>>>> +		trace_drv_link_info_changed(local, sdata, 0, changed);
>>>>> +		if (local->ops->link_info_changed)
>>>>> +			local->ops->link_info_changed(&local->hw, &sdata->vif,
>>>>> +						      0, changed);
>>>> I think you/someone will change here later for the "/* FIXME: should be
>>>> for each link */", right?
>>> Maybe. I'm not actually sure it's really needed, it depends how we use
>>> this in the future.
>>>
>>>> It lead error/kernel crash as below while reconfig single MLO link which
>>>> link id is 2.
>>>> When test with single MLO link which link id is 0, not found
>>>> error/kernel crash.
>>> I'm not surprised, I just worked on fixing reconfig in the last few
>>> days, will post it after some more review/testing.
>> Thanks.
>>> So I think that might not need changes *here*, but rather a proper FW
>>> restart. Which I haven't tested in AP mode though -- was the crash in AP
>>> mode?
>> It is crash in station mode.
> try this?
>
> https://p.sipsolutions.net/0652bbbbe350b126.txt
>
> johannes

Conflict happened while run "git am" the patch.

Because missing the  "changed |= BSS_CHANGED_EHT_PUNCTURING;" in my 
local code,

also it is missing in 
https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/tree/net/mac80211/util.c

Maybe "changed |= BSS_CHANGED_EHT_PUNCTURING;" is only existed in your 
local code?


-- 
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <quic_wgong@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>
Cc: <ath11k@lists.infradead.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 01/15] mac80211: split bss_info_changed method
Date: Tue, 18 Oct 2022 17:50:43 +0800	[thread overview]
Message-ID: <7e72034a-497a-000c-d7bf-3ec974af9e1c@quicinc.com> (raw)
In-Reply-To: <d0994456d3a9ea00b5cc472df7822d53d189399e.camel@sipsolutions.net>

On 10/18/2022 4:53 PM, Johannes Berg wrote:
> On Tue, 2022-10-18 at 16:52 +0800, Wen Gong wrote:
>> On 10/18/2022 4:50 PM, Johannes Berg wrote:
>>> On Tue, 2022-10-18 at 16:47 +0800, Wen Gong wrote:
>>>>> +	if (changed & ~BSS_CHANGED_VIF_CFG_FLAGS) {
>>>>> +		/* FIXME: should be for each link */
>>>>> +		trace_drv_link_info_changed(local, sdata, 0, changed);
>>>>> +		if (local->ops->link_info_changed)
>>>>> +			local->ops->link_info_changed(&local->hw, &sdata->vif,
>>>>> +						      0, changed);
>>>> I think you/someone will change here later for the "/* FIXME: should be
>>>> for each link */", right?
>>> Maybe. I'm not actually sure it's really needed, it depends how we use
>>> this in the future.
>>>
>>>> It lead error/kernel crash as below while reconfig single MLO link which
>>>> link id is 2.
>>>> When test with single MLO link which link id is 0, not found
>>>> error/kernel crash.
>>> I'm not surprised, I just worked on fixing reconfig in the last few
>>> days, will post it after some more review/testing.
>> Thanks.
>>> So I think that might not need changes *here*, but rather a proper FW
>>> restart. Which I haven't tested in AP mode though -- was the crash in AP
>>> mode?
>> It is crash in station mode.
> try this?
>
> https://p.sipsolutions.net/0652bbbbe350b126.txt
>
> johannes

Conflict happened while run "git am" the patch.

Because missing the  "changed |= BSS_CHANGED_EHT_PUNCTURING;" in my 
local code,

also it is missing in 
https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/tree/net/mac80211/util.c

Maybe "changed |= BSS_CHANGED_EHT_PUNCTURING;" is only existed in your 
local code?


-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <quic_wgong@quicinc.com>
To: Johannes Berg <johannes@sipsolutions.net>,
	<linux-wireless@vger.kernel.org>
Cc: <ath11k@lists.infradead.org>, <ath12k@lists.infradead.org>
Subject: Re: [PATCH 01/15] mac80211: split bss_info_changed method
Date: Tue, 18 Oct 2022 17:50:43 +0800	[thread overview]
Message-ID: <7e72034a-497a-000c-d7bf-3ec974af9e1c@quicinc.com> (raw)
In-Reply-To: <d0994456d3a9ea00b5cc472df7822d53d189399e.camel@sipsolutions.net>

On 10/18/2022 4:53 PM, Johannes Berg wrote:
> On Tue, 2022-10-18 at 16:52 +0800, Wen Gong wrote:
>> On 10/18/2022 4:50 PM, Johannes Berg wrote:
>>> On Tue, 2022-10-18 at 16:47 +0800, Wen Gong wrote:
>>>>> +	if (changed & ~BSS_CHANGED_VIF_CFG_FLAGS) {
>>>>> +		/* FIXME: should be for each link */
>>>>> +		trace_drv_link_info_changed(local, sdata, 0, changed);
>>>>> +		if (local->ops->link_info_changed)
>>>>> +			local->ops->link_info_changed(&local->hw, &sdata->vif,
>>>>> +						      0, changed);
>>>> I think you/someone will change here later for the "/* FIXME: should be
>>>> for each link */", right?
>>> Maybe. I'm not actually sure it's really needed, it depends how we use
>>> this in the future.
>>>
>>>> It lead error/kernel crash as below while reconfig single MLO link which
>>>> link id is 2.
>>>> When test with single MLO link which link id is 0, not found
>>>> error/kernel crash.
>>> I'm not surprised, I just worked on fixing reconfig in the last few
>>> days, will post it after some more review/testing.
>> Thanks.
>>> So I think that might not need changes *here*, but rather a proper FW
>>> restart. Which I haven't tested in AP mode though -- was the crash in AP
>>> mode?
>> It is crash in station mode.
> try this?
>
> https://p.sipsolutions.net/0652bbbbe350b126.txt
>
> johannes

Conflict happened while run "git am" the patch.

Because missing the  "changed |= BSS_CHANGED_EHT_PUNCTURING;" in my 
local code,

also it is missing in 
https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/tree/net/mac80211/util.c

Maybe "changed |= BSS_CHANGED_EHT_PUNCTURING;" is only existed in your 
local code?


  reply	other threads:[~2022-10-18  9:50 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  7:39 [PATCH 00/15] mac80211 MLO updates Johannes Berg
2022-06-01  7:39 ` [PATCH 01/15] mac80211: split bss_info_changed method Johannes Berg
2022-06-01 19:31   ` Jeff Johnson
2022-06-01 19:39     ` Johannes Berg
2022-10-18  8:47   ` Wen Gong
2022-10-18  8:47     ` Wen Gong
2022-10-18  8:47     ` Wen Gong
2022-10-18  8:50     ` Johannes Berg
2022-10-18  8:50       ` Johannes Berg
2022-10-18  8:50       ` Johannes Berg
2022-10-18  8:52       ` Wen Gong
2022-10-18  8:52         ` Wen Gong
2022-10-18  8:52         ` Wen Gong
2022-10-18  8:53         ` Johannes Berg
2022-10-18  8:53           ` Johannes Berg
2022-10-18  8:53           ` Johannes Berg
2022-10-18  9:50           ` Wen Gong [this message]
2022-10-18  9:50             ` Wen Gong
2022-10-18  9:50             ` Wen Gong
2022-10-18  9:51             ` Johannes Berg
2022-10-18  9:51               ` Johannes Berg
2022-10-18  9:51               ` Johannes Berg
2022-10-18 10:10               ` Wen Gong
2022-10-18 10:10                 ` Wen Gong
2022-10-18 10:10                 ` Wen Gong
2022-10-19  4:32                 ` Wen Gong
2022-10-19  4:32                   ` Wen Gong
2022-10-19  4:32                   ` Wen Gong
2022-12-15 15:04                   ` Wen Gong
2022-12-15 15:04                     ` Wen Gong
2022-12-15 15:04                     ` Wen Gong
2022-06-01  7:39 ` [PATCH 02/15] mac80211: add per-link configuration pointer Johannes Berg
2022-06-01  7:39 ` [PATCH 03/15] mac80211: pass link ID where already present Johannes Berg
2022-06-01  7:39 ` [PATCH 04/15] mac80211: make channel context code MLO-aware Johannes Berg
2023-02-14  7:57   ` Wen Gong
2023-02-14  7:57     ` Wen Gong
2023-02-14  8:04     ` Johannes Berg
2023-02-14  8:04       ` Johannes Berg
2023-02-14  8:09       ` Wen Gong
2023-02-14  8:09         ` Wen Gong
2023-02-14  8:13         ` Johannes Berg
2023-02-14  8:13           ` Johannes Berg
2022-06-01  7:39 ` [PATCH 05/15] mac80211: remove sta_info_tx_streams() Johannes Berg
2022-06-01  7:39 ` [PATCH 06/15] mac80211: refactor some sta_info link handling Johannes Berg
2022-06-01  7:39 ` [PATCH 07/15] mac80211: use IEEE80211_MLD_MAX_NUM_LINKS Johannes Berg
2022-06-01  7:39 ` [PATCH 08/15] mac80211: validate some driver features for MLO Johannes Berg
2022-06-01  7:39 ` [PATCH 09/15] mac80211: refactor some link setup code Johannes Berg
2022-06-01  7:39 ` [PATCH 10/15] mac80211: add link_id to vht.c code for MLO Johannes Berg
2022-06-01  7:39 ` [PATCH 11/15] mac80211: add link_id to eht.c " Johannes Berg
2022-06-01  7:39 ` [PATCH 12/15] mac80211: HT: make ieee80211_ht_cap_ie_to_sta_ht_cap() MLO-aware Johannes Berg
2022-06-01  7:39 ` [PATCH 13/15] mac80211: make some SMPS code MLD-aware Johannes Berg
2022-06-01  7:39 ` [PATCH 14/15] mac80211: make ieee80211_he_cap_ie_to_sta_he_cap() MLO-aware Johannes Berg
2022-06-01  7:39 ` [PATCH 15/15] mac80211: correct link config data in tracing Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e72034a-497a-000c-d7bf-3ec974af9e1c@quicinc.com \
    --to=quic_wgong@quicinc.com \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.